You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by sterlingann <gi...@git.apache.org> on 2017/01/04 18:37:00 UTC
[GitHub] cordova-ios pull request #285: CB-12098(iOS) removed spaces
GitHub user sterlingann opened a pull request:
https://github.com/apache/cordova-ios/pull/285
CB-12098(iOS) removed spaces
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### What does this PR do?
12098 updates supported interface return types. This PR is simply removing some extra spaces which were created when 12098 was initially submitted per @shazron 's suggestion
### What testing has been done on this change?
npm test
### Checklist
- [x ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sterlingann/cordova-ios spaces12098
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/285.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #285
----
commit 902c7f8cc662cce31c37a11e85071ec8843c0d49
Author: Sterling <st...@gmail.com>
Date: 2017-01-04T18:31:11Z
fixed merge conflicts
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request #285: CB-12098 (iOS) removed spaces
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/285
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #285: CB-12098 (iOS) removed spaces
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/285
## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/285?src=pr) is 64.11% (diff: 100%)
> Merging [#285](https://codecov.io/gh/apache/cordova-ios/pull/285?src=pr) into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) will not change coverage
```diff
@@ master #285 diff @@
==========================================
Files 12 12
Lines 1360 1360
Methods 208 208
Messages 0 0
Branches 229 229
==========================================
Hits 872 872
Misses 488 488
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [5463937...902c7f8](https://codecov.io/gh/apache/cordova-ios/compare/5463937695f783e72f32d4953e13bfe4d79855ab...902c7f8cc662cce31c37a11e85071ec8843c0d49?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org