You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2020/03/17 02:13:14 UTC
[kudu-CR] KUDU-3068 Add atomic operations for aarch64
huangtianhua223@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15455
Change subject: KUDU-3068 Add atomic operations for aarch64
......................................................................
KUDU-3068 Add atomic operations for aarch64
This patch adds atomic implementation for aarch64.
Change-Id: I3b31cdfd1daacbe2fef614c74baf0fc825a39377
---
A src/kudu/gutil/atomicops-internals-arm64.h
M src/kudu/gutil/atomicops.h
2 files changed, 358 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/15455/1
--
To view, visit http://gerrit.cloudera.org:8080/15455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b31cdfd1daacbe2fef614c74baf0fc825a39377
Gerrit-Change-Number: 15455
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
[kudu-CR] KUDU-3068 Add atomic operations for aarch64
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15455 )
Change subject: KUDU-3068 Add atomic operations for aarch64
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15455/1/src/kudu/gutil/atomicops-internals-arm64.h
File src/kudu/gutil/atomicops-internals-arm64.h:
PS1:
What's the origin of this file? What modifications (if any) were made to it after it was imported?
--
To view, visit http://gerrit.cloudera.org:8080/15455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b31cdfd1daacbe2fef614c74baf0fc825a39377
Gerrit-Change-Number: 15455
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 17 Mar 2020 04:08:37 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3068 Add atomic operations for aarch64
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15455 )
Change subject: KUDU-3068 Add atomic operations for aarch64
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15455/1/src/kudu/gutil/atomicops-internals-arm64.h
File src/kudu/gutil/atomicops-internals-arm64.h:
PS1:
> It base on https://github.com/protocolbuffers/protobuf/blob/3.5.x/src/googl
Gotcha. Could you split this up into two commits then?
- First commit that imports the pristine file from protobuf
- Second commit that makes any Kudu-specific changes to it, and hooks it into atomicops.h.
The second commit is the more interesting one to review, hence the desire to split it up.
--
To view, visit http://gerrit.cloudera.org:8080/15455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b31cdfd1daacbe2fef614c74baf0fc825a39377
Gerrit-Change-Number: 15455
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 17 Mar 2020 16:58:46 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3068 Add atomic operations for aarch64
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
huangtianhua223@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/15455 )
Change subject: KUDU-3068 Add atomic operations for aarch64
......................................................................
Patch Set 1:
(1 comment)
@Adar, Or is there newer file of aarch64 we can find?
http://gerrit.cloudera.org:8080/#/c/15455/1/src/kudu/gutil/atomicops-internals-arm64.h
File src/kudu/gutil/atomicops-internals-arm64.h:
PS1:
> What's the origin of this file? What modifications (if any) were made to it
It base on https://github.com/protocolbuffers/protobuf/blob/3.5.x/src/google/protobuf/stubs/atomicops_internals_arm64_gcc.h and I add Acquire_AtomicExchange function reference other platforms files.
--
To view, visit http://gerrit.cloudera.org:8080/15455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b31cdfd1daacbe2fef614c74baf0fc825a39377
Gerrit-Change-Number: 15455
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 17 Mar 2020 06:20:55 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3068 Add atomic operations for aarch64
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
huangtianhua223@gmail.com has abandoned this change. ( http://gerrit.cloudera.org:8080/15455 )
Change subject: KUDU-3068 Add atomic operations for aarch64
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/15455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I3b31cdfd1daacbe2fef614c74baf0fc825a39377
Gerrit-Change-Number: 15455
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)