You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2021/06/11 23:43:46 UTC

[Impala-ASF-CR] [PROTOTYPE] IMPALA-9690 addendum: Add a legacy AVX mode 

Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17588


Change subject: [PROTOTYPE] IMPALA-9690 addendum: Add a legacy AVX mode
......................................................................

[PROTOTYPE] IMPALA-9690 addendum: Add a legacy AVX mode

Impala 4 introduced a requirement that x86_64 machines
support AVX2. This adds a startup parameter
enable_legacy_avx_support that relaxes the AVX2 requirement
to require only AVX. By default, enable_legacy_avx_support
is false. enabled_legacy_avx_support will be removed in a
future release, but it seems like a sensible way to support
older machines for now.

Testing:
  - TODO

Change-Id: I44051720697a2a497f9017e4b31289be77fb6b05
---
M be/src/codegen/CMakeLists.txt
M be/src/codegen/impala-ir-data.h
M be/src/codegen/llvm-codegen.cc
M be/src/common/global-flags.cc
M be/src/util/cpu-info.cc
5 files changed, 81 insertions(+), 13 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/17588/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I44051720697a2a497f9017e4b31289be77fb6b05
Gerrit-Change-Number: 17588
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-9690 addendum: Add a legacy AVX mode

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17588

to look at the new patch set (#3).

Change subject: IMPALA-9690 addendum: Add a legacy AVX mode
......................................................................

IMPALA-9690 addendum: Add a legacy AVX mode

Impala 4 introduced a requirement that x86_64 machines
support AVX2. This adds a startup parameter
enable_legacy_avx_support that relaxes the AVX2 requirement
to require only AVX. By default, enable_legacy_avx_support
is false. enable_legacy_avx_support will be removed in a
future release, but it seems like a sensible way to support
older machines for now.

Testing:
  - Ran with enable_legacy_avx_support on a pool of machines
    that includes machines without AVX2
  - Ran a core job on a machine with AVX2

Change-Id: I44051720697a2a497f9017e4b31289be77fb6b05
---
M be/src/codegen/CMakeLists.txt
M be/src/codegen/impala-ir-data.h
M be/src/codegen/llvm-codegen.cc
M be/src/common/global-flags.cc
M be/src/util/cpu-info.cc
5 files changed, 82 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/17588/3
-- 
To view, visit http://gerrit.cloudera.org:8080/17588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I44051720697a2a497f9017e4b31289be77fb6b05
Gerrit-Change-Number: 17588
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] [PROTOTYPE] IMPALA-9690 addendum: Add a legacy AVX mode

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17588 )

Change subject: [PROTOTYPE] IMPALA-9690 addendum: Add a legacy AVX mode
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44051720697a2a497f9017e4b31289be77fb6b05
Gerrit-Change-Number: 17588
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 15 Jun 2021 01:52:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] [PROTOTYPE] IMPALA-9690 addendum: Add a legacy AVX mode

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/17588 )

Change subject: [PROTOTYPE] IMPALA-9690 addendum: Add a legacy AVX mode
......................................................................

[PROTOTYPE] IMPALA-9690 addendum: Add a legacy AVX mode

Impala 4 introduced a requirement that x86_64 machines
support AVX2. This adds a startup parameter
enable_legacy_avx_support that relaxes the AVX2 requirement
to require only AVX. By default, enable_legacy_avx_support
is false. enabled_legacy_avx_support will be removed in a
future release, but it seems like a sensible way to support
older machines for now.

Testing:
  - TODO

Change-Id: I44051720697a2a497f9017e4b31289be77fb6b05
---
M be/src/codegen/CMakeLists.txt
M be/src/codegen/impala-ir-data.h
M be/src/codegen/llvm-codegen.cc
M be/src/common/global-flags.cc
M be/src/util/cpu-info.cc
5 files changed, 82 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/17588/2
-- 
To view, visit http://gerrit.cloudera.org:8080/17588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I44051720697a2a497f9017e4b31289be77fb6b05
Gerrit-Change-Number: 17588
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-9690 addendum: Add a legacy AVX mode

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17588 )

Change subject: IMPALA-9690 addendum: Add a legacy AVX mode
......................................................................


Patch Set 3: Code-Review+2

Carry Daniel's +1 and mine to +2.


-- 
To view, visit http://gerrit.cloudera.org:8080/17588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44051720697a2a497f9017e4b31289be77fb6b05
Gerrit-Change-Number: 17588
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 16 Jun 2021 14:35:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9690 addendum: Add a legacy AVX mode

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17588 )

Change subject: IMPALA-9690 addendum: Add a legacy AVX mode
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44051720697a2a497f9017e4b31289be77fb6b05
Gerrit-Change-Number: 17588
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 15 Jun 2021 08:07:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9690 addendum: Add a legacy AVX mode

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17588 )

Change subject: IMPALA-9690 addendum: Add a legacy AVX mode
......................................................................

IMPALA-9690 addendum: Add a legacy AVX mode

Impala 4 introduced a requirement that x86_64 machines
support AVX2. This adds a startup parameter
enable_legacy_avx_support that relaxes the AVX2 requirement
to require only AVX. By default, enable_legacy_avx_support
is false. enable_legacy_avx_support will be removed in a
future release, but it seems like a sensible way to support
older machines for now.

Testing:
  - Ran with enable_legacy_avx_support on a pool of machines
    that includes machines without AVX2
  - Ran a core job on a machine with AVX2

Change-Id: I44051720697a2a497f9017e4b31289be77fb6b05
Reviewed-on: http://gerrit.cloudera.org:8080/17588
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Reviewed-by: Daniel Becker <da...@cloudera.com>
Reviewed-by: Quanlong Huang <hu...@gmail.com>
---
M be/src/codegen/CMakeLists.txt
M be/src/codegen/impala-ir-data.h
M be/src/codegen/llvm-codegen.cc
M be/src/common/global-flags.cc
M be/src/util/cpu-info.cc
5 files changed, 82 insertions(+), 12 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Joe McDonnell: Looks good to me, but someone else must approve
  Daniel Becker: Looks good to me, but someone else must approve
  Quanlong Huang: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/17588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I44051720697a2a497f9017e4b31289be77fb6b05
Gerrit-Change-Number: 17588
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-9690 addendum: Add a legacy AVX mode

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17588 )

Change subject: IMPALA-9690 addendum: Add a legacy AVX mode
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/8914/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44051720697a2a497f9017e4b31289be77fb6b05
Gerrit-Change-Number: 17588
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 15 Jun 2021 02:32:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9690 addendum: Add a legacy AVX mode

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17588 )

Change subject: IMPALA-9690 addendum: Add a legacy AVX mode
......................................................................


Patch Set 3: Code-Review+1

Carry +1


-- 
To view, visit http://gerrit.cloudera.org:8080/17588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44051720697a2a497f9017e4b31289be77fb6b05
Gerrit-Change-Number: 17588
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 15 Jun 2021 15:45:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9690 addendum: Add a legacy AVX mode

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/17588 )

Change subject: IMPALA-9690 addendum: Add a legacy AVX mode
......................................................................


Patch Set 3: Code-Review+1

Seems good to me.


-- 
To view, visit http://gerrit.cloudera.org:8080/17588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44051720697a2a497f9017e4b31289be77fb6b05
Gerrit-Change-Number: 17588
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 16 Jun 2021 10:57:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9690 addendum: Add a legacy AVX mode

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17588 )

Change subject: IMPALA-9690 addendum: Add a legacy AVX mode
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7226/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/17588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44051720697a2a497f9017e4b31289be77fb6b05
Gerrit-Change-Number: 17588
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 15 Jun 2021 02:09:57 +0000
Gerrit-HasComments: No