You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2023/07/10 14:58:53 UTC
[GitHub] [pulsar-helm-chart] lhotari opened a new pull request, #370: Fix CI checks
lhotari opened a new pull request, #370:
URL: https://github.com/apache/pulsar-helm-chart/pull/370
### Motivation
The current CI checks always fail. This PR attemps to fix this
### Modifications
- upgrade kind, helm chart and chart releaser versions
- disable podMonitor for remaining check
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] lhotari commented on a diff in pull request #370: Fix CI checks
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #370:
URL: https://github.com/apache/pulsar-helm-chart/pull/370#discussion_r1258805473
##########
.github/workflows/lint.yml:
##########
@@ -24,7 +24,7 @@ on:
- '*'
jobs:
lint-test:
- runs-on: ubuntu-latest
+ runs-on: ubuntu-20.04
Review Comment:
Using 22.04 now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] lhotari commented on pull request #370: Fix GitHub Actions based CI checks which have been failing
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #370:
URL: https://github.com/apache/pulsar-helm-chart/pull/370#issuecomment-1629628031
I think that the original reason for it to break is that ubuntu-latest switched to ubuntu-22.04 at some point. ubuntu-22.04 defaults to cgroup v2. The oldest k8s version to support cgroup v2 is k8s 1.19 . I'm not sure which kind version starts supporting cgroup v2. I also found out that for kind, you need to use supported versions of the kindest/node docker images which are documented in the kind release notes at https://github.com/kubernetes-sigs/kind/releases .
The reason to switch to 1.21 as the base line is the fact that the oldest k8s version supported by kind 0.20.0 is k8s 1.21. Anyways old k8s versions are end-of-life in many ways so there shouldn't be a good reason to keep support for very old k8s versions around.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] dave2wave commented on a diff in pull request #370: Fix CI checks
Posted by "dave2wave (via GitHub)" <gi...@apache.org>.
dave2wave commented on code in PR #370:
URL: https://github.com/apache/pulsar-helm-chart/pull/370#discussion_r1258436783
##########
.github/workflows/lint.yml:
##########
@@ -24,7 +24,7 @@ on:
- '*'
jobs:
lint-test:
- runs-on: ubuntu-latest
+ runs-on: ubuntu-20.04
Review Comment:
Why not 22.04?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] dave2wave merged pull request #370: Fix GitHub Actions based CI checks which have been failing
Posted by "dave2wave (via GitHub)" <gi...@apache.org>.
dave2wave merged PR #370:
URL: https://github.com/apache/pulsar-helm-chart/pull/370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] lhotari commented on a diff in pull request #370: Fix CI checks
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #370:
URL: https://github.com/apache/pulsar-helm-chart/pull/370#discussion_r1258445000
##########
.github/workflows/lint.yml:
##########
@@ -24,7 +24,7 @@ on:
- '*'
jobs:
lint-test:
- runs-on: ubuntu-latest
+ runs-on: ubuntu-20.04
Review Comment:
Trying to find out the reason why things fail. btw. ubuntu-20.04 EoL is Apr 2025 so it's still valid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org