You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by gi...@apache.org on 2018/08/18 14:48:16 UTC
[08/41] hbase-site git commit: Published site at
d159b1f8bb9a29f7786a96c910157e12583768a2.
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/7cafc412/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestHStoreFile.html
----------------------------------------------------------------------
diff --git a/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestHStoreFile.html b/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestHStoreFile.html
index 7c754a9..8f7596e 100644
--- a/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestHStoreFile.html
+++ b/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestHStoreFile.html
@@ -39,15 +39,15 @@
<span class="sourceLineNo">031</span>import java.util.OptionalLong;<a name="line.31"></a>
<span class="sourceLineNo">032</span>import java.util.TreeSet;<a name="line.32"></a>
<span class="sourceLineNo">033</span>import java.util.concurrent.atomic.AtomicInteger;<a name="line.33"></a>
-<span class="sourceLineNo">034</span>import org.apache.hadoop.conf.Configuration;<a name="line.34"></a>
-<span class="sourceLineNo">035</span>import org.apache.hadoop.fs.FileSystem;<a name="line.35"></a>
-<span class="sourceLineNo">036</span>import org.apache.hadoop.fs.Path;<a name="line.36"></a>
-<span class="sourceLineNo">037</span>import org.apache.hadoop.hbase.Cell;<a name="line.37"></a>
-<span class="sourceLineNo">038</span>import org.apache.hadoop.hbase.CellUtil;<a name="line.38"></a>
-<span class="sourceLineNo">039</span>import org.apache.hadoop.hbase.HBaseClassTestRule;<a name="line.39"></a>
-<span class="sourceLineNo">040</span>import org.apache.hadoop.hbase.HBaseTestCase;<a name="line.40"></a>
-<span class="sourceLineNo">041</span>import org.apache.hadoop.hbase.HBaseTestingUtility;<a name="line.41"></a>
-<span class="sourceLineNo">042</span>import org.apache.hadoop.hbase.HColumnDescriptor;<a name="line.42"></a>
+<span class="sourceLineNo">034</span><a name="line.34"></a>
+<span class="sourceLineNo">035</span>import org.apache.hadoop.conf.Configuration;<a name="line.35"></a>
+<span class="sourceLineNo">036</span>import org.apache.hadoop.fs.FileSystem;<a name="line.36"></a>
+<span class="sourceLineNo">037</span>import org.apache.hadoop.fs.Path;<a name="line.37"></a>
+<span class="sourceLineNo">038</span>import org.apache.hadoop.hbase.Cell;<a name="line.38"></a>
+<span class="sourceLineNo">039</span>import org.apache.hadoop.hbase.CellUtil;<a name="line.39"></a>
+<span class="sourceLineNo">040</span>import org.apache.hadoop.hbase.HBaseClassTestRule;<a name="line.40"></a>
+<span class="sourceLineNo">041</span>import org.apache.hadoop.hbase.HBaseTestCase;<a name="line.41"></a>
+<span class="sourceLineNo">042</span>import org.apache.hadoop.hbase.HBaseTestingUtility;<a name="line.42"></a>
<span class="sourceLineNo">043</span>import org.apache.hadoop.hbase.HConstants;<a name="line.43"></a>
<span class="sourceLineNo">044</span>import org.apache.hadoop.hbase.HRegionInfo;<a name="line.44"></a>
<span class="sourceLineNo">045</span>import org.apache.hadoop.hbase.KeyValue;<a name="line.45"></a>
@@ -56,1065 +56,1095 @@
<span class="sourceLineNo">048</span>import org.apache.hadoop.hbase.TableName;<a name="line.48"></a>
<span class="sourceLineNo">049</span>import org.apache.hadoop.hbase.client.ColumnFamilyDescriptor;<a name="line.49"></a>
<span class="sourceLineNo">050</span>import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;<a name="line.50"></a>
-<span class="sourceLineNo">051</span>import org.apache.hadoop.hbase.client.Scan;<a name="line.51"></a>
-<span class="sourceLineNo">052</span>import org.apache.hadoop.hbase.io.HFileLink;<a name="line.52"></a>
-<span class="sourceLineNo">053</span>import org.apache.hadoop.hbase.io.encoding.DataBlockEncoding;<a name="line.53"></a>
-<span class="sourceLineNo">054</span>import org.apache.hadoop.hbase.io.hfile.BlockCache;<a name="line.54"></a>
-<span class="sourceLineNo">055</span>import org.apache.hadoop.hbase.io.hfile.CacheConfig;<a name="line.55"></a>
-<span class="sourceLineNo">056</span>import org.apache.hadoop.hbase.io.hfile.CacheStats;<a name="line.56"></a>
-<span class="sourceLineNo">057</span>import org.apache.hadoop.hbase.io.hfile.HFileContext;<a name="line.57"></a>
-<span class="sourceLineNo">058</span>import org.apache.hadoop.hbase.io.hfile.HFileContextBuilder;<a name="line.58"></a>
-<span class="sourceLineNo">059</span>import org.apache.hadoop.hbase.io.hfile.HFileDataBlockEncoder;<a name="line.59"></a>
-<span class="sourceLineNo">060</span>import org.apache.hadoop.hbase.io.hfile.HFileDataBlockEncoderImpl;<a name="line.60"></a>
-<span class="sourceLineNo">061</span>import org.apache.hadoop.hbase.io.hfile.HFileScanner;<a name="line.61"></a>
-<span class="sourceLineNo">062</span>import org.apache.hadoop.hbase.testclassification.RegionServerTests;<a name="line.62"></a>
-<span class="sourceLineNo">063</span>import org.apache.hadoop.hbase.testclassification.SmallTests;<a name="line.63"></a>
-<span class="sourceLineNo">064</span>import org.apache.hadoop.hbase.util.BloomFilterFactory;<a name="line.64"></a>
-<span class="sourceLineNo">065</span>import org.apache.hadoop.hbase.util.Bytes;<a name="line.65"></a>
-<span class="sourceLineNo">066</span>import org.apache.hadoop.hbase.util.ChecksumType;<a name="line.66"></a>
-<span class="sourceLineNo">067</span>import org.apache.hadoop.hbase.util.FSUtils;<a name="line.67"></a>
-<span class="sourceLineNo">068</span>import org.junit.After;<a name="line.68"></a>
-<span class="sourceLineNo">069</span>import org.junit.Before;<a name="line.69"></a>
-<span class="sourceLineNo">070</span>import org.junit.ClassRule;<a name="line.70"></a>
-<span class="sourceLineNo">071</span>import org.junit.Test;<a name="line.71"></a>
-<span class="sourceLineNo">072</span>import org.junit.experimental.categories.Category;<a name="line.72"></a>
-<span class="sourceLineNo">073</span>import org.mockito.Mockito;<a name="line.73"></a>
-<span class="sourceLineNo">074</span>import org.slf4j.Logger;<a name="line.74"></a>
-<span class="sourceLineNo">075</span>import org.slf4j.LoggerFactory;<a name="line.75"></a>
-<span class="sourceLineNo">076</span><a name="line.76"></a>
-<span class="sourceLineNo">077</span>import org.apache.hbase.thirdparty.com.google.common.base.Joiner;<a name="line.77"></a>
-<span class="sourceLineNo">078</span>import org.apache.hbase.thirdparty.com.google.common.collect.Iterables;<a name="line.78"></a>
-<span class="sourceLineNo">079</span>import org.apache.hbase.thirdparty.com.google.common.collect.Lists;<a name="line.79"></a>
-<span class="sourceLineNo">080</span><a name="line.80"></a>
-<span class="sourceLineNo">081</span>/**<a name="line.81"></a>
-<span class="sourceLineNo">082</span> * Test HStoreFile<a name="line.82"></a>
-<span class="sourceLineNo">083</span> */<a name="line.83"></a>
-<span class="sourceLineNo">084</span>@Category({RegionServerTests.class, SmallTests.class})<a name="line.84"></a>
-<span class="sourceLineNo">085</span>public class TestHStoreFile extends HBaseTestCase {<a name="line.85"></a>
-<span class="sourceLineNo">086</span><a name="line.86"></a>
-<span class="sourceLineNo">087</span> @ClassRule<a name="line.87"></a>
-<span class="sourceLineNo">088</span> public static final HBaseClassTestRule CLASS_RULE =<a name="line.88"></a>
-<span class="sourceLineNo">089</span> HBaseClassTestRule.forClass(TestHStoreFile.class);<a name="line.89"></a>
-<span class="sourceLineNo">090</span><a name="line.90"></a>
-<span class="sourceLineNo">091</span> private static final Logger LOG = LoggerFactory.getLogger(TestHStoreFile.class);<a name="line.91"></a>
-<span class="sourceLineNo">092</span> private static final HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility();<a name="line.92"></a>
-<span class="sourceLineNo">093</span> private CacheConfig cacheConf = new CacheConfig(TEST_UTIL.getConfiguration());<a name="line.93"></a>
-<span class="sourceLineNo">094</span> private static String ROOT_DIR = TEST_UTIL.getDataTestDir("TestStoreFile").toString();<a name="line.94"></a>
-<span class="sourceLineNo">095</span> private static final ChecksumType CKTYPE = ChecksumType.CRC32C;<a name="line.95"></a>
-<span class="sourceLineNo">096</span> private static final int CKBYTES = 512;<a name="line.96"></a>
-<span class="sourceLineNo">097</span> private static String TEST_FAMILY = "cf";<a name="line.97"></a>
-<span class="sourceLineNo">098</span><a name="line.98"></a>
-<span class="sourceLineNo">099</span> @Override<a name="line.99"></a>
-<span class="sourceLineNo">100</span> @Before<a name="line.100"></a>
-<span class="sourceLineNo">101</span> public void setUp() throws Exception {<a name="line.101"></a>
-<span class="sourceLineNo">102</span> super.setUp();<a name="line.102"></a>
-<span class="sourceLineNo">103</span> }<a name="line.103"></a>
-<span class="sourceLineNo">104</span><a name="line.104"></a>
-<span class="sourceLineNo">105</span> @Override<a name="line.105"></a>
-<span class="sourceLineNo">106</span> @After<a name="line.106"></a>
-<span class="sourceLineNo">107</span> public void tearDown() throws Exception {<a name="line.107"></a>
-<span class="sourceLineNo">108</span> super.tearDown();<a name="line.108"></a>
-<span class="sourceLineNo">109</span> }<a name="line.109"></a>
-<span class="sourceLineNo">110</span><a name="line.110"></a>
-<span class="sourceLineNo">111</span> /**<a name="line.111"></a>
-<span class="sourceLineNo">112</span> * Write a file and then assert that we can read from top and bottom halves<a name="line.112"></a>
-<span class="sourceLineNo">113</span> * using two HalfMapFiles.<a name="line.113"></a>
-<span class="sourceLineNo">114</span> * @throws Exception<a name="line.114"></a>
-<span class="sourceLineNo">115</span> */<a name="line.115"></a>
-<span class="sourceLineNo">116</span> @Test<a name="line.116"></a>
-<span class="sourceLineNo">117</span> public void testBasicHalfMapFile() throws Exception {<a name="line.117"></a>
-<span class="sourceLineNo">118</span> final HRegionInfo hri =<a name="line.118"></a>
-<span class="sourceLineNo">119</span> new HRegionInfo(TableName.valueOf("testBasicHalfMapFileTb"));<a name="line.119"></a>
-<span class="sourceLineNo">120</span> HRegionFileSystem regionFs = HRegionFileSystem.createRegionOnFileSystem(<a name="line.120"></a>
-<span class="sourceLineNo">121</span> conf, fs, new Path(testDir, hri.getTable().getNameAsString()), hri);<a name="line.121"></a>
-<span class="sourceLineNo">122</span><a name="line.122"></a>
-<span class="sourceLineNo">123</span> HFileContext meta = new HFileContextBuilder().withBlockSize(2*1024).build();<a name="line.123"></a>
-<span class="sourceLineNo">124</span> StoreFileWriter writer = new StoreFileWriter.Builder(conf, cacheConf, this.fs)<a name="line.124"></a>
-<span class="sourceLineNo">125</span> .withFilePath(regionFs.createTempName())<a name="line.125"></a>
-<span class="sourceLineNo">126</span> .withFileContext(meta)<a name="line.126"></a>
-<span class="sourceLineNo">127</span> .build();<a name="line.127"></a>
-<span class="sourceLineNo">128</span> writeStoreFile(writer);<a name="line.128"></a>
-<span class="sourceLineNo">129</span><a name="line.129"></a>
-<span class="sourceLineNo">130</span> Path sfPath = regionFs.commitStoreFile(TEST_FAMILY, writer.getPath());<a name="line.130"></a>
-<span class="sourceLineNo">131</span> HStoreFile sf = new HStoreFile(this.fs, sfPath, conf, cacheConf, BloomType.NONE, true);<a name="line.131"></a>
-<span class="sourceLineNo">132</span> checkHalfHFile(regionFs, sf);<a name="line.132"></a>
-<span class="sourceLineNo">133</span> }<a name="line.133"></a>
-<span class="sourceLineNo">134</span><a name="line.134"></a>
-<span class="sourceLineNo">135</span> private void writeStoreFile(final StoreFileWriter writer) throws IOException {<a name="line.135"></a>
-<span class="sourceLineNo">136</span> writeStoreFile(writer, Bytes.toBytes(getName()), Bytes.toBytes(getName()));<a name="line.136"></a>
-<span class="sourceLineNo">137</span> }<a name="line.137"></a>
-<span class="sourceLineNo">138</span><a name="line.138"></a>
-<span class="sourceLineNo">139</span> // pick an split point (roughly halfway)<a name="line.139"></a>
-<span class="sourceLineNo">140</span> byte[] SPLITKEY = new byte[] { (LAST_CHAR + FIRST_CHAR)/2, FIRST_CHAR};<a name="line.140"></a>
-<span class="sourceLineNo">141</span><a name="line.141"></a>
-<span class="sourceLineNo">142</span> /*<a name="line.142"></a>
-<span class="sourceLineNo">143</span> * Writes HStoreKey and ImmutableBytes data to passed writer and<a name="line.143"></a>
-<span class="sourceLineNo">144</span> * then closes it.<a name="line.144"></a>
-<span class="sourceLineNo">145</span> * @param writer<a name="line.145"></a>
-<span class="sourceLineNo">146</span> * @throws IOException<a name="line.146"></a>
-<span class="sourceLineNo">147</span> */<a name="line.147"></a>
-<span class="sourceLineNo">148</span> public static void writeStoreFile(final StoreFileWriter writer, byte[] fam, byte[] qualifier)<a name="line.148"></a>
-<span class="sourceLineNo">149</span> throws IOException {<a name="line.149"></a>
-<span class="sourceLineNo">150</span> long now = System.currentTimeMillis();<a name="line.150"></a>
-<span class="sourceLineNo">151</span> try {<a name="line.151"></a>
-<span class="sourceLineNo">152</span> for (char d = FIRST_CHAR; d <= LAST_CHAR; d++) {<a name="line.152"></a>
-<span class="sourceLineNo">153</span> for (char e = FIRST_CHAR; e <= LAST_CHAR; e++) {<a name="line.153"></a>
-<span class="sourceLineNo">154</span> byte[] b = new byte[] { (byte) d, (byte) e };<a name="line.154"></a>
-<span class="sourceLineNo">155</span> writer.append(new KeyValue(b, fam, qualifier, now, b));<a name="line.155"></a>
-<span class="sourceLineNo">156</span> }<a name="line.156"></a>
-<span class="sourceLineNo">157</span> }<a name="line.157"></a>
-<span class="sourceLineNo">158</span> } finally {<a name="line.158"></a>
-<span class="sourceLineNo">159</span> writer.close();<a name="line.159"></a>
-<span class="sourceLineNo">160</span> }<a name="line.160"></a>
-<span class="sourceLineNo">161</span> }<a name="line.161"></a>
-<span class="sourceLineNo">162</span><a name="line.162"></a>
-<span class="sourceLineNo">163</span> /**<a name="line.163"></a>
-<span class="sourceLineNo">164</span> * Test that our mechanism of writing store files in one region to reference<a name="line.164"></a>
-<span class="sourceLineNo">165</span> * store files in other regions works.<a name="line.165"></a>
-<span class="sourceLineNo">166</span> * @throws IOException<a name="line.166"></a>
-<span class="sourceLineNo">167</span> */<a name="line.167"></a>
-<span class="sourceLineNo">168</span> @Test<a name="line.168"></a>
-<span class="sourceLineNo">169</span> public void testReference() throws IOException {<a name="line.169"></a>
-<span class="sourceLineNo">170</span> final HRegionInfo hri = new HRegionInfo(TableName.valueOf("testReferenceTb"));<a name="line.170"></a>
-<span class="sourceLineNo">171</span> HRegionFileSystem regionFs = HRegionFileSystem.createRegionOnFileSystem(<a name="line.171"></a>
-<span class="sourceLineNo">172</span> conf, fs, new Path(testDir, hri.getTable().getNameAsString()), hri);<a name="line.172"></a>
-<span class="sourceLineNo">173</span><a name="line.173"></a>
-<span class="sourceLineNo">174</span> HFileContext meta = new HFileContextBuilder().withBlockSize(8 * 1024).build();<a name="line.174"></a>
-<span class="sourceLineNo">175</span> // Make a store file and write data to it.<a name="line.175"></a>
-<span class="sourceLineNo">176</span> StoreFileWriter writer = new StoreFileWriter.Builder(conf, cacheConf, this.fs)<a name="line.176"></a>
-<span class="sourceLineNo">177</span> .withFilePath(regionFs.createTempName())<a name="line.177"></a>
-<span class="sourceLineNo">178</span> .withFileContext(meta)<a name="line.178"></a>
-<span class="sourceLineNo">179</span> .build();<a name="line.179"></a>
-<span class="sourceLineNo">180</span> writeStoreFile(writer);<a name="line.180"></a>
-<span class="sourceLineNo">181</span><a name="line.181"></a>
-<span class="sourceLineNo">182</span> Path hsfPath = regionFs.commitStoreFile(TEST_FAMILY, writer.getPath());<a name="line.182"></a>
-<span class="sourceLineNo">183</span> HStoreFile hsf = new HStoreFile(this.fs, hsfPath, conf, cacheConf, BloomType.NONE, true);<a name="line.183"></a>
-<span class="sourceLineNo">184</span> hsf.initReader();<a name="line.184"></a>
-<span class="sourceLineNo">185</span> StoreFileReader reader = hsf.getReader();<a name="line.185"></a>
-<span class="sourceLineNo">186</span> // Split on a row, not in middle of row. Midkey returned by reader<a name="line.186"></a>
-<span class="sourceLineNo">187</span> // may be in middle of row. Create new one with empty column and<a name="line.187"></a>
-<span class="sourceLineNo">188</span> // timestamp.<a name="line.188"></a>
-<span class="sourceLineNo">189</span> byte [] midRow = CellUtil.cloneRow(reader.midKey().get());<a name="line.189"></a>
-<span class="sourceLineNo">190</span> byte [] finalRow = CellUtil.cloneRow(reader.getLastKey().get());<a name="line.190"></a>
-<span class="sourceLineNo">191</span> hsf.closeStoreFile(true);<a name="line.191"></a>
-<span class="sourceLineNo">192</span><a name="line.192"></a>
-<span class="sourceLineNo">193</span> // Make a reference<a name="line.193"></a>
-<span class="sourceLineNo">194</span> HRegionInfo splitHri = new HRegionInfo(hri.getTable(), null, midRow);<a name="line.194"></a>
-<span class="sourceLineNo">195</span> Path refPath = splitStoreFile(regionFs, splitHri, TEST_FAMILY, hsf, midRow, true);<a name="line.195"></a>
-<span class="sourceLineNo">196</span> HStoreFile refHsf = new HStoreFile(this.fs, refPath, conf, cacheConf, BloomType.NONE, true);<a name="line.196"></a>
-<span class="sourceLineNo">197</span> refHsf.initReader();<a name="line.197"></a>
-<span class="sourceLineNo">198</span> // Now confirm that I can read from the reference and that it only gets<a name="line.198"></a>
-<span class="sourceLineNo">199</span> // keys from top half of the file.<a name="line.199"></a>
-<span class="sourceLineNo">200</span> HFileScanner s = refHsf.getReader().getScanner(false, false);<a name="line.200"></a>
-<span class="sourceLineNo">201</span> Cell kv = null;<a name="line.201"></a>
-<span class="sourceLineNo">202</span> for (boolean first = true; (!s.isSeeked() && s.seekTo()) || s.next();) {<a name="line.202"></a>
-<span class="sourceLineNo">203</span> ByteBuffer bb = ByteBuffer.wrap(((KeyValue) s.getKey()).getKey());<a name="line.203"></a>
-<span class="sourceLineNo">204</span> kv = KeyValueUtil.createKeyValueFromKey(bb);<a name="line.204"></a>
-<span class="sourceLineNo">205</span> if (first) {<a name="line.205"></a>
-<span class="sourceLineNo">206</span> assertTrue(Bytes.equals(kv.getRowArray(), kv.getRowOffset(), kv.getRowLength(), midRow, 0,<a name="line.206"></a>
-<span class="sourceLineNo">207</span> midRow.length));<a name="line.207"></a>
-<span class="sourceLineNo">208</span> first = false;<a name="line.208"></a>
-<span class="sourceLineNo">209</span> }<a name="line.209"></a>
-<span class="sourceLineNo">210</span> }<a name="line.210"></a>
-<span class="sourceLineNo">211</span> assertTrue(Bytes.equals(kv.getRowArray(), kv.getRowOffset(), kv.getRowLength(), finalRow, 0,<a name="line.211"></a>
-<span class="sourceLineNo">212</span> finalRow.length));<a name="line.212"></a>
-<span class="sourceLineNo">213</span> }<a name="line.213"></a>
-<span class="sourceLineNo">214</span><a name="line.214"></a>
-<span class="sourceLineNo">215</span> @Test<a name="line.215"></a>
-<span class="sourceLineNo">216</span> public void testEmptyStoreFileRestrictKeyRanges() throws Exception {<a name="line.216"></a>
-<span class="sourceLineNo">217</span> StoreFileReader reader = mock(StoreFileReader.class);<a name="line.217"></a>
-<span class="sourceLineNo">218</span> HStore store = mock(HStore.class);<a name="line.218"></a>
-<span class="sourceLineNo">219</span> byte[] cf = Bytes.toBytes("ty");<a name="line.219"></a>
-<span class="sourceLineNo">220</span> ColumnFamilyDescriptor cfd = ColumnFamilyDescriptorBuilder.of(cf);<a name="line.220"></a>
-<span class="sourceLineNo">221</span> when(store.getColumnFamilyDescriptor()).thenReturn(cfd);<a name="line.221"></a>
-<span class="sourceLineNo">222</span> StoreFileScanner scanner =<a name="line.222"></a>
-<span class="sourceLineNo">223</span> new StoreFileScanner(reader, mock(HFileScanner.class), false, false, 0, 0, true);<a name="line.223"></a>
-<span class="sourceLineNo">224</span> Scan scan = new Scan();<a name="line.224"></a>
-<span class="sourceLineNo">225</span> scan.setColumnFamilyTimeRange(cf, 0, 1);<a name="line.225"></a>
-<span class="sourceLineNo">226</span> assertFalse(scanner.shouldUseScanner(scan, store, 0));<a name="line.226"></a>
-<span class="sourceLineNo">227</span> }<a name="line.227"></a>
-<span class="sourceLineNo">228</span><a name="line.228"></a>
-<span class="sourceLineNo">229</span> @Test<a name="line.229"></a>
-<span class="sourceLineNo">230</span> public void testHFileLink() throws IOException {<a name="line.230"></a>
-<span class="sourceLineNo">231</span> final HRegionInfo hri = new HRegionInfo(TableName.valueOf("testHFileLinkTb"));<a name="line.231"></a>
-<span class="sourceLineNo">232</span> // force temp data in hbase/target/test-data instead of /tmp/hbase-xxxx/<a name="line.232"></a>
-<span class="sourceLineNo">233</span> Configuration testConf = new Configuration(this.conf);<a name="line.233"></a>
-<span class="sourceLineNo">234</span> FSUtils.setRootDir(testConf, testDir);<a name="line.234"></a>
-<span class="sourceLineNo">235</span> HRegionFileSystem regionFs = HRegionFileSystem.createRegionOnFileSystem(<a name="line.235"></a>
-<span class="sourceLineNo">236</span> testConf, fs, FSUtils.getTableDir(testDir, hri.getTable()), hri);<a name="line.236"></a>
-<span class="sourceLineNo">237</span> HFileContext meta = new HFileContextBuilder().withBlockSize(8 * 1024).build();<a name="line.237"></a>
-<span class="sourceLineNo">238</span><a name="line.238"></a>
-<span class="sourceLineNo">239</span> // Make a store file and write data to it.<a name="line.239"></a>
-<span class="sourceLineNo">240</span> StoreFileWriter writer = new StoreFileWriter.Builder(conf, cacheConf, this.fs)<a name="line.240"></a>
-<span class="sourceLineNo">241</span> .withFilePath(regionFs.createTempName())<a name="line.241"></a>
-<span class="sourceLineNo">242</span> .withFileContext(meta)<a name="line.242"></a>
-<span class="sourceLineNo">243</span> .build();<a name="line.243"></a>
-<span class="sourceLineNo">244</span> writeStoreFile(writer);<a name="line.244"></a>
-<span class="sourceLineNo">245</span><a name="line.245"></a>
-<span class="sourceLineNo">246</span> Path storeFilePath = regionFs.commitStoreFile(TEST_FAMILY, writer.getPath());<a name="line.246"></a>
-<span class="sourceLineNo">247</span> Path dstPath = new Path(regionFs.getTableDir(), new Path("test-region", TEST_FAMILY));<a name="line.247"></a>
-<span class="sourceLineNo">248</span> HFileLink.create(testConf, this.fs, dstPath, hri, storeFilePath.getName());<a name="line.248"></a>
-<span class="sourceLineNo">249</span> Path linkFilePath = new Path(dstPath,<a name="line.249"></a>
-<span class="sourceLineNo">250</span> HFileLink.createHFileLinkName(hri, storeFilePath.getName()));<a name="line.250"></a>
-<span class="sourceLineNo">251</span><a name="line.251"></a>
-<span class="sourceLineNo">252</span> // Try to open store file from link<a name="line.252"></a>
-<span class="sourceLineNo">253</span> StoreFileInfo storeFileInfo = new StoreFileInfo(testConf, this.fs, linkFilePath);<a name="line.253"></a>
-<span class="sourceLineNo">254</span> HStoreFile hsf =<a name="line.254"></a>
-<span class="sourceLineNo">255</span> new HStoreFile(this.fs, storeFileInfo, testConf, cacheConf, BloomType.NONE, true);<a name="line.255"></a>
-<span class="sourceLineNo">256</span> assertTrue(storeFileInfo.isLink());<a name="line.256"></a>
-<span class="sourceLineNo">257</span> hsf.initReader();<a name="line.257"></a>
+<span class="sourceLineNo">051</span>import org.apache.hadoop.hbase.client.RegionInfo;<a name="line.51"></a>
+<span class="sourceLineNo">052</span>import org.apache.hadoop.hbase.client.RegionInfoBuilder;<a name="line.52"></a>
+<span class="sourceLineNo">053</span>import org.apache.hadoop.hbase.client.Scan;<a name="line.53"></a>
+<span class="sourceLineNo">054</span>import org.apache.hadoop.hbase.io.HFileLink;<a name="line.54"></a>
+<span class="sourceLineNo">055</span>import org.apache.hadoop.hbase.io.encoding.DataBlockEncoding;<a name="line.55"></a>
+<span class="sourceLineNo">056</span>import org.apache.hadoop.hbase.io.hfile.BlockCache;<a name="line.56"></a>
+<span class="sourceLineNo">057</span>import org.apache.hadoop.hbase.io.hfile.CacheConfig;<a name="line.57"></a>
+<span class="sourceLineNo">058</span>import org.apache.hadoop.hbase.io.hfile.CacheStats;<a name="line.58"></a>
+<span class="sourceLineNo">059</span>import org.apache.hadoop.hbase.io.hfile.HFileContext;<a name="line.59"></a>
+<span class="sourceLineNo">060</span>import org.apache.hadoop.hbase.io.hfile.HFileContextBuilder;<a name="line.60"></a>
+<span class="sourceLineNo">061</span>import org.apache.hadoop.hbase.io.hfile.HFileDataBlockEncoder;<a name="line.61"></a>
+<span class="sourceLineNo">062</span>import org.apache.hadoop.hbase.io.hfile.HFileDataBlockEncoderImpl;<a name="line.62"></a>
+<span class="sourceLineNo">063</span>import org.apache.hadoop.hbase.io.hfile.HFileScanner;<a name="line.63"></a>
+<span class="sourceLineNo">064</span>import org.apache.hadoop.hbase.testclassification.RegionServerTests;<a name="line.64"></a>
+<span class="sourceLineNo">065</span>import org.apache.hadoop.hbase.testclassification.SmallTests;<a name="line.65"></a>
+<span class="sourceLineNo">066</span>import org.apache.hadoop.hbase.util.BloomFilterFactory;<a name="line.66"></a>
+<span class="sourceLineNo">067</span>import org.apache.hadoop.hbase.util.Bytes;<a name="line.67"></a>
+<span class="sourceLineNo">068</span>import org.apache.hadoop.hbase.util.ChecksumType;<a name="line.68"></a>
+<span class="sourceLineNo">069</span>import org.apache.hadoop.hbase.util.FSUtils;<a name="line.69"></a>
+<span class="sourceLineNo">070</span>import org.apache.hbase.thirdparty.com.google.common.base.Joiner;<a name="line.70"></a>
+<span class="sourceLineNo">071</span>import org.apache.hbase.thirdparty.com.google.common.collect.Iterables;<a name="line.71"></a>
+<span class="sourceLineNo">072</span>import org.apache.hbase.thirdparty.com.google.common.collect.Lists;<a name="line.72"></a>
+<span class="sourceLineNo">073</span>import org.junit.After;<a name="line.73"></a>
+<span class="sourceLineNo">074</span>import org.junit.Before;<a name="line.74"></a>
+<span class="sourceLineNo">075</span>import org.junit.ClassRule;<a name="line.75"></a>
+<span class="sourceLineNo">076</span>import org.junit.Test;<a name="line.76"></a>
+<span class="sourceLineNo">077</span>import org.junit.experimental.categories.Category;<a name="line.77"></a>
+<span class="sourceLineNo">078</span>import org.mockito.Mockito;<a name="line.78"></a>
+<span class="sourceLineNo">079</span>import org.slf4j.Logger;<a name="line.79"></a>
+<span class="sourceLineNo">080</span>import org.slf4j.LoggerFactory;<a name="line.80"></a>
+<span class="sourceLineNo">081</span><a name="line.81"></a>
+<span class="sourceLineNo">082</span>/**<a name="line.82"></a>
+<span class="sourceLineNo">083</span> * Test HStoreFile<a name="line.83"></a>
+<span class="sourceLineNo">084</span> */<a name="line.84"></a>
+<span class="sourceLineNo">085</span>@Category({RegionServerTests.class, SmallTests.class})<a name="line.85"></a>
+<span class="sourceLineNo">086</span>public class TestHStoreFile extends HBaseTestCase {<a name="line.86"></a>
+<span class="sourceLineNo">087</span><a name="line.87"></a>
+<span class="sourceLineNo">088</span> @ClassRule<a name="line.88"></a>
+<span class="sourceLineNo">089</span> public static final HBaseClassTestRule CLASS_RULE =<a name="line.89"></a>
+<span class="sourceLineNo">090</span> HBaseClassTestRule.forClass(TestHStoreFile.class);<a name="line.90"></a>
+<span class="sourceLineNo">091</span><a name="line.91"></a>
+<span class="sourceLineNo">092</span> private static final Logger LOG = LoggerFactory.getLogger(TestHStoreFile.class);<a name="line.92"></a>
+<span class="sourceLineNo">093</span> private static final HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility();<a name="line.93"></a>
+<span class="sourceLineNo">094</span> private CacheConfig cacheConf = new CacheConfig(TEST_UTIL.getConfiguration());<a name="line.94"></a>
+<span class="sourceLineNo">095</span> private static String ROOT_DIR = TEST_UTIL.getDataTestDir("TestStoreFile").toString();<a name="line.95"></a>
+<span class="sourceLineNo">096</span> private static final ChecksumType CKTYPE = ChecksumType.CRC32C;<a name="line.96"></a>
+<span class="sourceLineNo">097</span> private static final int CKBYTES = 512;<a name="line.97"></a>
+<span class="sourceLineNo">098</span> private static String TEST_FAMILY = "cf";<a name="line.98"></a>
+<span class="sourceLineNo">099</span><a name="line.99"></a>
+<span class="sourceLineNo">100</span> @Override<a name="line.100"></a>
+<span class="sourceLineNo">101</span> @Before<a name="line.101"></a>
+<span class="sourceLineNo">102</span> public void setUp() throws Exception {<a name="line.102"></a>
+<span class="sourceLineNo">103</span> super.setUp();<a name="line.103"></a>
+<span class="sourceLineNo">104</span> }<a name="line.104"></a>
+<span class="sourceLineNo">105</span><a name="line.105"></a>
+<span class="sourceLineNo">106</span> @Override<a name="line.106"></a>
+<span class="sourceLineNo">107</span> @After<a name="line.107"></a>
+<span class="sourceLineNo">108</span> public void tearDown() throws Exception {<a name="line.108"></a>
+<span class="sourceLineNo">109</span> super.tearDown();<a name="line.109"></a>
+<span class="sourceLineNo">110</span> }<a name="line.110"></a>
+<span class="sourceLineNo">111</span><a name="line.111"></a>
+<span class="sourceLineNo">112</span> /**<a name="line.112"></a>
+<span class="sourceLineNo">113</span> * Write a file and then assert that we can read from top and bottom halves<a name="line.113"></a>
+<span class="sourceLineNo">114</span> * using two HalfMapFiles.<a name="line.114"></a>
+<span class="sourceLineNo">115</span> * @throws Exception<a name="line.115"></a>
+<span class="sourceLineNo">116</span> */<a name="line.116"></a>
+<span class="sourceLineNo">117</span> @Test<a name="line.117"></a>
+<span class="sourceLineNo">118</span> public void testBasicHalfMapFile() throws Exception {<a name="line.118"></a>
+<span class="sourceLineNo">119</span> final HRegionInfo hri =<a name="line.119"></a>
+<span class="sourceLineNo">120</span> new HRegionInfo(TableName.valueOf("testBasicHalfMapFileTb"));<a name="line.120"></a>
+<span class="sourceLineNo">121</span> HRegionFileSystem regionFs = HRegionFileSystem.createRegionOnFileSystem(<a name="line.121"></a>
+<span class="sourceLineNo">122</span> conf, fs, new Path(testDir, hri.getTable().getNameAsString()), hri);<a name="line.122"></a>
+<span class="sourceLineNo">123</span><a name="line.123"></a>
+<span class="sourceLineNo">124</span> HFileContext meta = new HFileContextBuilder().withBlockSize(2*1024).build();<a name="line.124"></a>
+<span class="sourceLineNo">125</span> StoreFileWriter writer = new StoreFileWriter.Builder(conf, cacheConf, this.fs)<a name="line.125"></a>
+<span class="sourceLineNo">126</span> .withFilePath(regionFs.createTempName())<a name="line.126"></a>
+<span class="sourceLineNo">127</span> .withFileContext(meta)<a name="line.127"></a>
+<span class="sourceLineNo">128</span> .build();<a name="line.128"></a>
+<span class="sourceLineNo">129</span> writeStoreFile(writer);<a name="line.129"></a>
+<span class="sourceLineNo">130</span><a name="line.130"></a>
+<span class="sourceLineNo">131</span> Path sfPath = regionFs.commitStoreFile(TEST_FAMILY, writer.getPath());<a name="line.131"></a>
+<span class="sourceLineNo">132</span> HStoreFile sf = new HStoreFile(this.fs, sfPath, conf, cacheConf, BloomType.NONE, true);<a name="line.132"></a>
+<span class="sourceLineNo">133</span> checkHalfHFile(regionFs, sf);<a name="line.133"></a>
+<span class="sourceLineNo">134</span> }<a name="line.134"></a>
+<span class="sourceLineNo">135</span><a name="line.135"></a>
+<span class="sourceLineNo">136</span> private void writeStoreFile(final StoreFileWriter writer) throws IOException {<a name="line.136"></a>
+<span class="sourceLineNo">137</span> writeStoreFile(writer, Bytes.toBytes(getName()), Bytes.toBytes(getName()));<a name="line.137"></a>
+<span class="sourceLineNo">138</span> }<a name="line.138"></a>
+<span class="sourceLineNo">139</span><a name="line.139"></a>
+<span class="sourceLineNo">140</span> // pick an split point (roughly halfway)<a name="line.140"></a>
+<span class="sourceLineNo">141</span> byte[] SPLITKEY = new byte[] { (LAST_CHAR + FIRST_CHAR)/2, FIRST_CHAR};<a name="line.141"></a>
+<span class="sourceLineNo">142</span><a name="line.142"></a>
+<span class="sourceLineNo">143</span> /*<a name="line.143"></a>
+<span class="sourceLineNo">144</span> * Writes HStoreKey and ImmutableBytes data to passed writer and<a name="line.144"></a>
+<span class="sourceLineNo">145</span> * then closes it.<a name="line.145"></a>
+<span class="sourceLineNo">146</span> * @param writer<a name="line.146"></a>
+<span class="sourceLineNo">147</span> * @throws IOException<a name="line.147"></a>
+<span class="sourceLineNo">148</span> */<a name="line.148"></a>
+<span class="sourceLineNo">149</span> public static void writeStoreFile(final StoreFileWriter writer, byte[] fam, byte[] qualifier)<a name="line.149"></a>
+<span class="sourceLineNo">150</span> throws IOException {<a name="line.150"></a>
+<span class="sourceLineNo">151</span> long now = System.currentTimeMillis();<a name="line.151"></a>
+<span class="sourceLineNo">152</span> try {<a name="line.152"></a>
+<span class="sourceLineNo">153</span> for (char d = FIRST_CHAR; d <= LAST_CHAR; d++) {<a name="line.153"></a>
+<span class="sourceLineNo">154</span> for (char e = FIRST_CHAR; e <= LAST_CHAR; e++) {<a name="line.154"></a>
+<span class="sourceLineNo">155</span> byte[] b = new byte[] { (byte) d, (byte) e };<a name="line.155"></a>
+<span class="sourceLineNo">156</span> writer.append(new KeyValue(b, fam, qualifier, now, b));<a name="line.156"></a>
+<span class="sourceLineNo">157</span> }<a name="line.157"></a>
+<span class="sourceLineNo">158</span> }<a name="line.158"></a>
+<span class="sourceLineNo">159</span> } finally {<a name="line.159"></a>
+<span class="sourceLineNo">160</span> writer.close();<a name="line.160"></a>
+<span class="sourceLineNo">161</span> }<a name="line.161"></a>
+<span class="sourceLineNo">162</span> }<a name="line.162"></a>
+<span class="sourceLineNo">163</span><a name="line.163"></a>
+<span class="sourceLineNo">164</span> /**<a name="line.164"></a>
+<span class="sourceLineNo">165</span> * Test that our mechanism of writing store files in one region to reference<a name="line.165"></a>
+<span class="sourceLineNo">166</span> * store files in other regions works.<a name="line.166"></a>
+<span class="sourceLineNo">167</span> * @throws IOException<a name="line.167"></a>
+<span class="sourceLineNo">168</span> */<a name="line.168"></a>
+<span class="sourceLineNo">169</span> @Test<a name="line.169"></a>
+<span class="sourceLineNo">170</span> public void testReference() throws IOException {<a name="line.170"></a>
+<span class="sourceLineNo">171</span> final HRegionInfo hri = new HRegionInfo(TableName.valueOf("testReferenceTb"));<a name="line.171"></a>
+<span class="sourceLineNo">172</span> HRegionFileSystem regionFs = HRegionFileSystem.createRegionOnFileSystem(<a name="line.172"></a>
+<span class="sourceLineNo">173</span> conf, fs, new Path(testDir, hri.getTable().getNameAsString()), hri);<a name="line.173"></a>
+<span class="sourceLineNo">174</span><a name="line.174"></a>
+<span class="sourceLineNo">175</span> HFileContext meta = new HFileContextBuilder().withBlockSize(8 * 1024).build();<a name="line.175"></a>
+<span class="sourceLineNo">176</span> // Make a store file and write data to it.<a name="line.176"></a>
+<span class="sourceLineNo">177</span> StoreFileWriter writer = new StoreFileWriter.Builder(conf, cacheConf, this.fs)<a name="line.177"></a>
+<span class="sourceLineNo">178</span> .withFilePath(regionFs.createTempName())<a name="line.178"></a>
+<span class="sourceLineNo">179</span> .withFileContext(meta)<a name="line.179"></a>
+<span class="sourceLineNo">180</span> .build();<a name="line.180"></a>
+<span class="sourceLineNo">181</span> writeStoreFile(writer);<a name="line.181"></a>
+<span class="sourceLineNo">182</span><a name="line.182"></a>
+<span class="sourceLineNo">183</span> Path hsfPath = regionFs.commitStoreFile(TEST_FAMILY, writer.getPath());<a name="line.183"></a>
+<span class="sourceLineNo">184</span> HStoreFile hsf = new HStoreFile(this.fs, hsfPath, conf, cacheConf, BloomType.NONE, true);<a name="line.184"></a>
+<span class="sourceLineNo">185</span> hsf.initReader();<a name="line.185"></a>
+<span class="sourceLineNo">186</span> StoreFileReader reader = hsf.getReader();<a name="line.186"></a>
+<span class="sourceLineNo">187</span> // Split on a row, not in middle of row. Midkey returned by reader<a name="line.187"></a>
+<span class="sourceLineNo">188</span> // may be in middle of row. Create new one with empty column and<a name="line.188"></a>
+<span class="sourceLineNo">189</span> // timestamp.<a name="line.189"></a>
+<span class="sourceLineNo">190</span> byte [] midRow = CellUtil.cloneRow(reader.midKey().get());<a name="line.190"></a>
+<span class="sourceLineNo">191</span> byte [] finalRow = CellUtil.cloneRow(reader.getLastKey().get());<a name="line.191"></a>
+<span class="sourceLineNo">192</span> hsf.closeStoreFile(true);<a name="line.192"></a>
+<span class="sourceLineNo">193</span><a name="line.193"></a>
+<span class="sourceLineNo">194</span> // Make a reference<a name="line.194"></a>
+<span class="sourceLineNo">195</span> HRegionInfo splitHri = new HRegionInfo(hri.getTable(), null, midRow);<a name="line.195"></a>
+<span class="sourceLineNo">196</span> Path refPath = splitStoreFile(regionFs, splitHri, TEST_FAMILY, hsf, midRow, true);<a name="line.196"></a>
+<span class="sourceLineNo">197</span> HStoreFile refHsf = new HStoreFile(this.fs, refPath, conf, cacheConf, BloomType.NONE, true);<a name="line.197"></a>
+<span class="sourceLineNo">198</span> refHsf.initReader();<a name="line.198"></a>
+<span class="sourceLineNo">199</span> // Now confirm that I can read from the reference and that it only gets<a name="line.199"></a>
+<span class="sourceLineNo">200</span> // keys from top half of the file.<a name="line.200"></a>
+<span class="sourceLineNo">201</span> HFileScanner s = refHsf.getReader().getScanner(false, false);<a name="line.201"></a>
+<span class="sourceLineNo">202</span> Cell kv = null;<a name="line.202"></a>
+<span class="sourceLineNo">203</span> for (boolean first = true; (!s.isSeeked() && s.seekTo()) || s.next();) {<a name="line.203"></a>
+<span class="sourceLineNo">204</span> ByteBuffer bb = ByteBuffer.wrap(((KeyValue) s.getKey()).getKey());<a name="line.204"></a>
+<span class="sourceLineNo">205</span> kv = KeyValueUtil.createKeyValueFromKey(bb);<a name="line.205"></a>
+<span class="sourceLineNo">206</span> if (first) {<a name="line.206"></a>
+<span class="sourceLineNo">207</span> assertTrue(Bytes.equals(kv.getRowArray(), kv.getRowOffset(), kv.getRowLength(), midRow, 0,<a name="line.207"></a>
+<span class="sourceLineNo">208</span> midRow.length));<a name="line.208"></a>
+<span class="sourceLineNo">209</span> first = false;<a name="line.209"></a>
+<span class="sourceLineNo">210</span> }<a name="line.210"></a>
+<span class="sourceLineNo">211</span> }<a name="line.211"></a>
+<span class="sourceLineNo">212</span> assertTrue(Bytes.equals(kv.getRowArray(), kv.getRowOffset(), kv.getRowLength(), finalRow, 0,<a name="line.212"></a>
+<span class="sourceLineNo">213</span> finalRow.length));<a name="line.213"></a>
+<span class="sourceLineNo">214</span> }<a name="line.214"></a>
+<span class="sourceLineNo">215</span><a name="line.215"></a>
+<span class="sourceLineNo">216</span> @Test<a name="line.216"></a>
+<span class="sourceLineNo">217</span> public void testStoreFileReference() throws Exception {<a name="line.217"></a>
+<span class="sourceLineNo">218</span> final RegionInfo hri =<a name="line.218"></a>
+<span class="sourceLineNo">219</span> RegionInfoBuilder.newBuilder(TableName.valueOf("testStoreFileReference")).build();<a name="line.219"></a>
+<span class="sourceLineNo">220</span> HRegionFileSystem regionFs = HRegionFileSystem.createRegionOnFileSystem(conf, fs,<a name="line.220"></a>
+<span class="sourceLineNo">221</span> new Path(testDir, hri.getTable().getNameAsString()), hri);<a name="line.221"></a>
+<span class="sourceLineNo">222</span> HFileContext meta = new HFileContextBuilder().withBlockSize(8 * 1024).build();<a name="line.222"></a>
+<span class="sourceLineNo">223</span><a name="line.223"></a>
+<span class="sourceLineNo">224</span> // Make a store file and write data to it.<a name="line.224"></a>
+<span class="sourceLineNo">225</span> StoreFileWriter writer = new StoreFileWriter.Builder(conf, cacheConf, this.fs)<a name="line.225"></a>
+<span class="sourceLineNo">226</span> .withFilePath(regionFs.createTempName()).withFileContext(meta).build();<a name="line.226"></a>
+<span class="sourceLineNo">227</span> writeStoreFile(writer);<a name="line.227"></a>
+<span class="sourceLineNo">228</span> Path hsfPath = regionFs.commitStoreFile(TEST_FAMILY, writer.getPath());<a name="line.228"></a>
+<span class="sourceLineNo">229</span> writer.close();<a name="line.229"></a>
+<span class="sourceLineNo">230</span><a name="line.230"></a>
+<span class="sourceLineNo">231</span> HStoreFile file = new HStoreFile(this.fs, hsfPath, conf, cacheConf, BloomType.NONE, true);<a name="line.231"></a>
+<span class="sourceLineNo">232</span> file.initReader();<a name="line.232"></a>
+<span class="sourceLineNo">233</span> StoreFileReader r = file.getReader();<a name="line.233"></a>
+<span class="sourceLineNo">234</span> assertNotNull(r);<a name="line.234"></a>
+<span class="sourceLineNo">235</span> StoreFileScanner scanner =<a name="line.235"></a>
+<span class="sourceLineNo">236</span> new StoreFileScanner(r, mock(HFileScanner.class), false, false, 0, 0, false);<a name="line.236"></a>
+<span class="sourceLineNo">237</span><a name="line.237"></a>
+<span class="sourceLineNo">238</span> // Verify after instantiating scanner refCount is increased<a name="line.238"></a>
+<span class="sourceLineNo">239</span> assertTrue("Verify file is being referenced", file.isReferencedInReads());<a name="line.239"></a>
+<span class="sourceLineNo">240</span> scanner.close();<a name="line.240"></a>
+<span class="sourceLineNo">241</span> // Verify after closing scanner refCount is decreased<a name="line.241"></a>
+<span class="sourceLineNo">242</span> assertFalse("Verify file is not being referenced", file.isReferencedInReads());<a name="line.242"></a>
+<span class="sourceLineNo">243</span> }<a name="line.243"></a>
+<span class="sourceLineNo">244</span><a name="line.244"></a>
+<span class="sourceLineNo">245</span> @Test<a name="line.245"></a>
+<span class="sourceLineNo">246</span> public void testEmptyStoreFileRestrictKeyRanges() throws Exception {<a name="line.246"></a>
+<span class="sourceLineNo">247</span> StoreFileReader reader = mock(StoreFileReader.class);<a name="line.247"></a>
+<span class="sourceLineNo">248</span> HStore store = mock(HStore.class);<a name="line.248"></a>
+<span class="sourceLineNo">249</span> byte[] cf = Bytes.toBytes("ty");<a name="line.249"></a>
+<span class="sourceLineNo">250</span> ColumnFamilyDescriptor cfd = ColumnFamilyDescriptorBuilder.of(cf);<a name="line.250"></a>
+<span class="sourceLineNo">251</span> when(store.getColumnFamilyDescriptor()).thenReturn(cfd);<a name="line.251"></a>
+<span class="sourceLineNo">252</span> StoreFileScanner scanner =<a name="line.252"></a>
+<span class="sourceLineNo">253</span> new StoreFileScanner(reader, mock(HFileScanner.class), false, false, 0, 0, true);<a name="line.253"></a>
+<span class="sourceLineNo">254</span> Scan scan = new Scan();<a name="line.254"></a>
+<span class="sourceLineNo">255</span> scan.setColumnFamilyTimeRange(cf, 0, 1);<a name="line.255"></a>
+<span class="sourceLineNo">256</span> assertFalse(scanner.shouldUseScanner(scan, store, 0));<a name="line.256"></a>
+<span class="sourceLineNo">257</span> }<a name="line.257"></a>
<span class="sourceLineNo">258</span><a name="line.258"></a>
-<span class="sourceLineNo">259</span> // Now confirm that I can read from the link<a name="line.259"></a>
-<span class="sourceLineNo">260</span> int count = 1;<a name="line.260"></a>
-<span class="sourceLineNo">261</span> HFileScanner s = hsf.getReader().getScanner(false, false);<a name="line.261"></a>
-<span class="sourceLineNo">262</span> s.seekTo();<a name="line.262"></a>
-<span class="sourceLineNo">263</span> while (s.next()) {<a name="line.263"></a>
-<span class="sourceLineNo">264</span> count++;<a name="line.264"></a>
-<span class="sourceLineNo">265</span> }<a name="line.265"></a>
-<span class="sourceLineNo">266</span> assertEquals((LAST_CHAR - FIRST_CHAR + 1) * (LAST_CHAR - FIRST_CHAR + 1), count);<a name="line.266"></a>
-<span class="sourceLineNo">267</span> }<a name="line.267"></a>
+<span class="sourceLineNo">259</span> @Test<a name="line.259"></a>
+<span class="sourceLineNo">260</span> public void testHFileLink() throws IOException {<a name="line.260"></a>
+<span class="sourceLineNo">261</span> final HRegionInfo hri = new HRegionInfo(TableName.valueOf("testHFileLinkTb"));<a name="line.261"></a>
+<span class="sourceLineNo">262</span> // force temp data in hbase/target/test-data instead of /tmp/hbase-xxxx/<a name="line.262"></a>
+<span class="sourceLineNo">263</span> Configuration testConf = new Configuration(this.conf);<a name="line.263"></a>
+<span class="sourceLineNo">264</span> FSUtils.setRootDir(testConf, testDir);<a name="line.264"></a>
+<span class="sourceLineNo">265</span> HRegionFileSystem regionFs = HRegionFileSystem.createRegionOnFileSystem(<a name="line.265"></a>
+<span class="sourceLineNo">266</span> testConf, fs, FSUtils.getTableDir(testDir, hri.getTable()), hri);<a name="line.266"></a>
+<span class="sourceLineNo">267</span> HFileContext meta = new HFileContextBuilder().withBlockSize(8 * 1024).build();<a name="line.267"></a>
<span class="sourceLineNo">268</span><a name="line.268"></a>
-<span class="sourceLineNo">269</span> /**<a name="line.269"></a>
-<span class="sourceLineNo">270</span> * This test creates an hfile and then the dir structures and files to verify that references<a name="line.270"></a>
-<span class="sourceLineNo">271</span> * to hfilelinks (created by snapshot clones) can be properly interpreted.<a name="line.271"></a>
-<span class="sourceLineNo">272</span> */<a name="line.272"></a>
-<span class="sourceLineNo">273</span> @Test<a name="line.273"></a>
-<span class="sourceLineNo">274</span> public void testReferenceToHFileLink() throws IOException {<a name="line.274"></a>
-<span class="sourceLineNo">275</span> // force temp data in hbase/target/test-data instead of /tmp/hbase-xxxx/<a name="line.275"></a>
-<span class="sourceLineNo">276</span> Configuration testConf = new Configuration(this.conf);<a name="line.276"></a>
-<span class="sourceLineNo">277</span> FSUtils.setRootDir(testConf, testDir);<a name="line.277"></a>
-<span class="sourceLineNo">278</span><a name="line.278"></a>
-<span class="sourceLineNo">279</span> // adding legal table name chars to verify regex handles it.<a name="line.279"></a>
-<span class="sourceLineNo">280</span> HRegionInfo hri = new HRegionInfo(TableName.valueOf("_original-evil-name"));<a name="line.280"></a>
-<span class="sourceLineNo">281</span> HRegionFileSystem regionFs = HRegionFileSystem.createRegionOnFileSystem(<a name="line.281"></a>
-<span class="sourceLineNo">282</span> testConf, fs, FSUtils.getTableDir(testDir, hri.getTable()), hri);<a name="line.282"></a>
-<span class="sourceLineNo">283</span><a name="line.283"></a>
-<span class="sourceLineNo">284</span> HFileContext meta = new HFileContextBuilder().withBlockSize(8 * 1024).build();<a name="line.284"></a>
-<span class="sourceLineNo">285</span> // Make a store file and write data to it. <root>/<tablename>/<rgn>/<cf>/<file><a name="line.285"></a>
-<span class="sourceLineNo">286</span> StoreFileWriter writer = new StoreFileWriter.Builder(testConf, cacheConf, this.fs)<a name="line.286"></a>
-<span class="sourceLineNo">287</span> .withFilePath(regionFs.createTempName())<a name="line.287"></a>
-<span class="sourceLineNo">288</span> .withFileContext(meta)<a name="line.288"></a>
-<span class="sourceLineNo">289</span> .build();<a name="line.289"></a>
-<span class="sourceLineNo">290</span> writeStoreFile(writer);<a name="line.290"></a>
-<span class="sourceLineNo">291</span> Path storeFilePath = regionFs.commitStoreFile(TEST_FAMILY, writer.getPath());<a name="line.291"></a>
-<span class="sourceLineNo">292</span><a name="line.292"></a>
-<span class="sourceLineNo">293</span> // create link to store file. <root>/clone/region/<cf>/<hfile>-<region>-<table><a name="line.293"></a>
-<span class="sourceLineNo">294</span> HRegionInfo hriClone = new HRegionInfo(TableName.valueOf("clone"));<a name="line.294"></a>
-<span class="sourceLineNo">295</span> HRegionFileSystem cloneRegionFs = HRegionFileSystem.createRegionOnFileSystem(<a name="line.295"></a>
-<span class="sourceLineNo">296</span> testConf, fs, FSUtils.getTableDir(testDir, hri.getTable()),<a name="line.296"></a>
-<span class="sourceLineNo">297</span> hriClone);<a name="line.297"></a>
-<span class="sourceLineNo">298</span> Path dstPath = cloneRegionFs.getStoreDir(TEST_FAMILY);<a name="line.298"></a>
-<span class="sourceLineNo">299</span> HFileLink.create(testConf, this.fs, dstPath, hri, storeFilePath.getName());<a name="line.299"></a>
-<span class="sourceLineNo">300</span> Path linkFilePath = new Path(dstPath,<a name="line.300"></a>
-<span class="sourceLineNo">301</span> HFileLink.createHFileLinkName(hri, storeFilePath.getName()));<a name="line.301"></a>
-<span class="sourceLineNo">302</span><a name="line.302"></a>
-<span class="sourceLineNo">303</span> // create splits of the link.<a name="line.303"></a>
-<span class="sourceLineNo">304</span> // <root>/clone/splitA/<cf>/<reftohfilelink>,<a name="line.304"></a>
-<span class="sourceLineNo">305</span> // <root>/clone/splitB/<cf>/<reftohfilelink><a name="line.305"></a>
-<span class="sourceLineNo">306</span> HRegionInfo splitHriA = new HRegionInfo(hri.getTable(), null, SPLITKEY);<a name="line.306"></a>
-<span class="sourceLineNo">307</span> HRegionInfo splitHriB = new HRegionInfo(hri.getTable(), SPLITKEY, null);<a name="line.307"></a>
-<span class="sourceLineNo">308</span> HStoreFile f = new HStoreFile(fs, linkFilePath, testConf, cacheConf, BloomType.NONE, true);<a name="line.308"></a>
-<span class="sourceLineNo">309</span> f.initReader();<a name="line.309"></a>
-<span class="sourceLineNo">310</span> Path pathA = splitStoreFile(cloneRegionFs, splitHriA, TEST_FAMILY, f, SPLITKEY, true); // top<a name="line.310"></a>
-<span class="sourceLineNo">311</span> Path pathB = splitStoreFile(cloneRegionFs, splitHriB, TEST_FAMILY, f, SPLITKEY, false);// bottom<a name="line.311"></a>
-<span class="sourceLineNo">312</span> f.closeStoreFile(true);<a name="line.312"></a>
-<span class="sourceLineNo">313</span> // OK test the thing<a name="line.313"></a>
-<span class="sourceLineNo">314</span> FSUtils.logFileSystemState(fs, testDir, LOG);<a name="line.314"></a>
-<span class="sourceLineNo">315</span><a name="line.315"></a>
-<span class="sourceLineNo">316</span> // There is a case where a file with the hfilelink pattern is actually a daughter<a name="line.316"></a>
-<span class="sourceLineNo">317</span> // reference to a hfile link. This code in StoreFile that handles this case.<a name="line.317"></a>
-<span class="sourceLineNo">318</span><a name="line.318"></a>
-<span class="sourceLineNo">319</span> // Try to open store file from link<a name="line.319"></a>
-<span class="sourceLineNo">320</span> HStoreFile hsfA = new HStoreFile(this.fs, pathA, testConf, cacheConf, BloomType.NONE, true);<a name="line.320"></a>
-<span class="sourceLineNo">321</span> hsfA.initReader();<a name="line.321"></a>
+<span class="sourceLineNo">269</span> // Make a store file and write data to it.<a name="line.269"></a>
+<span class="sourceLineNo">270</span> StoreFileWriter writer = new StoreFileWriter.Builder(conf, cacheConf, this.fs)<a name="line.270"></a>
+<span class="sourceLineNo">271</span> .withFilePath(regionFs.createTempName())<a name="line.271"></a>
+<span class="sourceLineNo">272</span> .withFileContext(meta)<a name="line.272"></a>
+<span class="sourceLineNo">273</span> .build();<a name="line.273"></a>
+<span class="sourceLineNo">274</span> writeStoreFile(writer);<a name="line.274"></a>
+<span class="sourceLineNo">275</span><a name="line.275"></a>
+<span class="sourceLineNo">276</span> Path storeFilePath = regionFs.commitStoreFile(TEST_FAMILY, writer.getPath());<a name="line.276"></a>
+<span class="sourceLineNo">277</span> Path dstPath = new Path(regionFs.getTableDir(), new Path("test-region", TEST_FAMILY));<a name="line.277"></a>
+<span class="sourceLineNo">278</span> HFileLink.create(testConf, this.fs, dstPath, hri, storeFilePath.getName());<a name="line.278"></a>
+<span class="sourceLineNo">279</span> Path linkFilePath = new Path(dstPath,<a name="line.279"></a>
+<span class="sourceLineNo">280</span> HFileLink.createHFileLinkName(hri, storeFilePath.getName()));<a name="line.280"></a>
+<span class="sourceLineNo">281</span><a name="line.281"></a>
+<span class="sourceLineNo">282</span> // Try to open store file from link<a name="line.282"></a>
+<span class="sourceLineNo">283</span> StoreFileInfo storeFileInfo = new StoreFileInfo(testConf, this.fs, linkFilePath);<a name="line.283"></a>
+<span class="sourceLineNo">284</span> HStoreFile hsf =<a name="line.284"></a>
+<span class="sourceLineNo">285</span> new HStoreFile(this.fs, storeFileInfo, testConf, cacheConf, BloomType.NONE, true);<a name="line.285"></a>
+<span class="sourceLineNo">286</span> assertTrue(storeFileInfo.isLink());<a name="line.286"></a>
+<span class="sourceLineNo">287</span> hsf.initReader();<a name="line.287"></a>
+<span class="sourceLineNo">288</span><a name="line.288"></a>
+<span class="sourceLineNo">289</span> // Now confirm that I can read from the link<a name="line.289"></a>
+<span class="sourceLineNo">290</span> int count = 1;<a name="line.290"></a>
+<span class="sourceLineNo">291</span> HFileScanner s = hsf.getReader().getScanner(false, false);<a name="line.291"></a>
+<span class="sourceLineNo">292</span> s.seekTo();<a name="line.292"></a>
+<span class="sourceLineNo">293</span> while (s.next()) {<a name="line.293"></a>
+<span class="sourceLineNo">294</span> count++;<a name="line.294"></a>
+<span class="sourceLineNo">295</span> }<a name="line.295"></a>
+<span class="sourceLineNo">296</span> assertEquals((LAST_CHAR - FIRST_CHAR + 1) * (LAST_CHAR - FIRST_CHAR + 1), count);<a name="line.296"></a>
+<span class="sourceLineNo">297</span> }<a name="line.297"></a>
+<span class="sourceLineNo">298</span><a name="line.298"></a>
+<span class="sourceLineNo">299</span> /**<a name="line.299"></a>
+<span class="sourceLineNo">300</span> * This test creates an hfile and then the dir structures and files to verify that references<a name="line.300"></a>
+<span class="sourceLineNo">301</span> * to hfilelinks (created by snapshot clones) can be properly interpreted.<a name="line.301"></a>
+<span class="sourceLineNo">302</span> */<a name="line.302"></a>
+<span class="sourceLineNo">303</span> @Test<a name="line.303"></a>
+<span class="sourceLineNo">304</span> public void testReferenceToHFileLink() throws IOException {<a name="line.304"></a>
+<span class="sourceLineNo">305</span> // force temp data in hbase/target/test-data instead of /tmp/hbase-xxxx/<a name="line.305"></a>
+<span class="sourceLineNo">306</span> Configuration testConf = new Configuration(this.conf);<a name="line.306"></a>
+<span class="sourceLineNo">307</span> FSUtils.setRootDir(testConf, testDir);<a name="line.307"></a>
+<span class="sourceLineNo">308</span><a name="line.308"></a>
+<span class="sourceLineNo">309</span> // adding legal table name chars to verify regex handles it.<a name="line.309"></a>
+<span class="sourceLineNo">310</span> HRegionInfo hri = new HRegionInfo(TableName.valueOf("_original-evil-name"));<a name="line.310"></a>
+<span class="sourceLineNo">311</span> HRegionFileSystem regionFs = HRegionFileSystem.createRegionOnFileSystem(<a name="line.311"></a>
+<span class="sourceLineNo">312</span> testConf, fs, FSUtils.getTableDir(testDir, hri.getTable()), hri);<a name="line.312"></a>
+<span class="sourceLineNo">313</span><a name="line.313"></a>
+<span class="sourceLineNo">314</span> HFileContext meta = new HFileContextBuilder().withBlockSize(8 * 1024).build();<a name="line.314"></a>
+<span class="sourceLineNo">315</span> // Make a store file and write data to it. <root>/<tablename>/<rgn>/<cf>/<file><a name="line.315"></a>
+<span class="sourceLineNo">316</span> StoreFileWriter writer = new StoreFileWriter.Builder(testConf, cacheConf, this.fs)<a name="line.316"></a>
+<span class="sourceLineNo">317</span> .withFilePath(regionFs.createTempName())<a name="line.317"></a>
+<span class="sourceLineNo">318</span> .withFileContext(meta)<a name="line.318"></a>
+<span class="sourceLineNo">319</span> .build();<a name="line.319"></a>
+<span class="sourceLineNo">320</span> writeStoreFile(writer);<a name="line.320"></a>
+<span class="sourceLineNo">321</span> Path storeFilePath = regionFs.commitStoreFile(TEST_FAMILY, writer.getPath());<a name="line.321"></a>
<span class="sourceLineNo">322</span><a name="line.322"></a>
-<span class="sourceLineNo">323</span> // Now confirm that I can read from the ref to link<a name="line.323"></a>
-<span class="sourceLineNo">324</span> int count = 1;<a name="line.324"></a>
-<span class="sourceLineNo">325</span> HFileScanner s = hsfA.getReader().getScanner(false, false);<a name="line.325"></a>
-<span class="sourceLineNo">326</span> s.seekTo();<a name="line.326"></a>
-<span class="sourceLineNo">327</span> while (s.next()) {<a name="line.327"></a>
-<span class="sourceLineNo">328</span> count++;<a name="line.328"></a>
-<span class="sourceLineNo">329</span> }<a name="line.329"></a>
-<span class="sourceLineNo">330</span> assertTrue(count > 0); // read some rows here<a name="line.330"></a>
-<span class="sourceLineNo">331</span><a name="line.331"></a>
-<span class="sourceLineNo">332</span> // Try to open store file from link<a name="line.332"></a>
-<span class="sourceLineNo">333</span> HStoreFile hsfB = new HStoreFile(this.fs, pathB, testConf, cacheConf, BloomType.NONE, true);<a name="line.333"></a>
-<span class="sourceLineNo">334</span> hsfB.initReader();<a name="line.334"></a>
-<span class="sourceLineNo">335</span><a name="line.335"></a>
-<span class="sourceLineNo">336</span> // Now confirm that I can read from the ref to link<a name="line.336"></a>
-<span class="sourceLineNo">337</span> HFileScanner sB = hsfB.getReader().getScanner(false, false);<a name="line.337"></a>
-<span class="sourceLineNo">338</span> sB.seekTo();<a name="line.338"></a>
-<span class="sourceLineNo">339</span><a name="line.339"></a>
-<span class="sourceLineNo">340</span> //count++ as seekTo() will advance the scanner<a name="line.340"></a>
-<span class="sourceLineNo">341</span> count++;<a name="line.341"></a>
-<span class="sourceLineNo">342</span> while (sB.next()) {<a name="line.342"></a>
-<span class="sourceLineNo">343</span> count++;<a name="line.343"></a>
-<span class="sourceLineNo">344</span> }<a name="line.344"></a>
+<span class="sourceLineNo">323</span> // create link to store file. <root>/clone/region/<cf>/<hfile>-<region>-<table><a name="line.323"></a>
+<span class="sourceLineNo">324</span> HRegionInfo hriClone = new HRegionInfo(TableName.valueOf("clone"));<a name="line.324"></a>
+<span class="sourceLineNo">325</span> HRegionFileSystem cloneRegionFs = HRegionFileSystem.createRegionOnFileSystem(<a name="line.325"></a>
+<span class="sourceLineNo">326</span> testConf, fs, FSUtils.getTableDir(testDir, hri.getTable()),<a name="line.326"></a>
+<span class="sourceLineNo">327</span> hriClone);<a name="line.327"></a>
+<span class="sourceLineNo">328</span> Path dstPath = cloneRegionFs.getStoreDir(TEST_FAMILY);<a name="line.328"></a>
+<span class="sourceLineNo">329</span> HFileLink.create(testConf, this.fs, dstPath, hri, storeFilePath.getName());<a name="line.329"></a>
+<span class="sourceLineNo">330</span> Path linkFilePath = new Path(dstPath,<a name="line.330"></a>
+<span class="sourceLineNo">331</span> HFileLink.createHFileLinkName(hri, storeFilePath.getName()));<a name="line.331"></a>
+<span class="sourceLineNo">332</span><a name="line.332"></a>
+<span class="sourceLineNo">333</span> // create splits of the link.<a name="line.333"></a>
+<span class="sourceLineNo">334</span> // <root>/clone/splitA/<cf>/<reftohfilelink>,<a name="line.334"></a>
+<span class="sourceLineNo">335</span> // <root>/clone/splitB/<cf>/<reftohfilelink><a name="line.335"></a>
+<span class="sourceLineNo">336</span> HRegionInfo splitHriA = new HRegionInfo(hri.getTable(), null, SPLITKEY);<a name="line.336"></a>
+<span class="sourceLineNo">337</span> HRegionInfo splitHriB = new HRegionInfo(hri.getTable(), SPLITKEY, null);<a name="line.337"></a>
+<span class="sourceLineNo">338</span> HStoreFile f = new HStoreFile(fs, linkFilePath, testConf, cacheConf, BloomType.NONE, true);<a name="line.338"></a>
+<span class="sourceLineNo">339</span> f.initReader();<a name="line.339"></a>
+<span class="sourceLineNo">340</span> Path pathA = splitStoreFile(cloneRegionFs, splitHriA, TEST_FAMILY, f, SPLITKEY, true); // top<a name="line.340"></a>
+<span class="sourceLineNo">341</span> Path pathB = splitStoreFile(cloneRegionFs, splitHriB, TEST_FAMILY, f, SPLITKEY, false);// bottom<a name="line.341"></a>
+<span class="sourceLineNo">342</span> f.closeStoreFile(true);<a name="line.342"></a>
+<span class="sourceLineNo">343</span> // OK test the thing<a name="line.343"></a>
+<span class="sourceLineNo">344</span> FSUtils.logFileSystemState(fs, testDir, LOG);<a name="line.344"></a>
<span class="sourceLineNo">345</span><a name="line.345"></a>
-<span class="sourceLineNo">346</span> // read the rest of the rows<a name="line.346"></a>
-<span class="sourceLineNo">347</span> assertEquals((LAST_CHAR - FIRST_CHAR + 1) * (LAST_CHAR - FIRST_CHAR + 1), count);<a name="line.347"></a>
-<span class="sourceLineNo">348</span> }<a name="line.348"></a>
-<span class="sourceLineNo">349</span><a name="line.349"></a>
-<span class="sourceLineNo">350</span> private void checkHalfHFile(final HRegionFileSystem regionFs, final HStoreFile f)<a name="line.350"></a>
-<span class="sourceLineNo">351</span> throws IOException {<a name="line.351"></a>
-<span class="sourceLineNo">352</span> f.initReader();<a name="line.352"></a>
-<span class="sourceLineNo">353</span> Cell midkey = f.getReader().midKey().get();<a name="line.353"></a>
-<span class="sourceLineNo">354</span> KeyValue midKV = (KeyValue)midkey;<a name="line.354"></a>
-<span class="sourceLineNo">355</span> byte [] midRow = CellUtil.cloneRow(midKV);<a name="line.355"></a>
-<span class="sourceLineNo">356</span> // Create top split.<a name="line.356"></a>
-<span class="sourceLineNo">357</span> HRegionInfo topHri = new HRegionInfo(regionFs.getRegionInfo().getTable(),<a name="line.357"></a>
-<span class="sourceLineNo">358</span> null, midRow);<a name="line.358"></a>
-<span class="sourceLineNo">359</span> Path topPath = splitStoreFile(regionFs, topHri, TEST_FAMILY, f, midRow, true);<a name="line.359"></a>
-<span class="sourceLineNo">360</span> // Create bottom split.<a name="line.360"></a>
-<span class="sourceLineNo">361</span> HRegionInfo bottomHri = new HRegionInfo(regionFs.getRegionInfo().getTable(),<a name="line.361"></a>
-<span class="sourceLineNo">362</span> midRow, null);<a name="line.362"></a>
-<span class="sourceLineNo">363</span> Path bottomPath = splitStoreFile(regionFs, bottomHri, TEST_FAMILY, f, midRow, false);<a name="line.363"></a>
-<span class="sourceLineNo">364</span> // Make readers on top and bottom.<a name="line.364"></a>
-<span class="sourceLineNo">365</span> HStoreFile topF = new HStoreFile(this.fs, topPath, conf, cacheConf, BloomType.NONE, true);<a name="line.365"></a>
-<span class="sourceLineNo">366</span> topF.initReader();<a name="line.366"></a>
-<span class="sourceLineNo">367</span> StoreFileReader top = topF.getReader();<a name="line.367"></a>
-<span class="sourceLineNo">368</span> HStoreFile bottomF = new HStoreFile(this.fs, bottomPath, conf, cacheConf, BloomType.NONE, true);<a name="line.368"></a>
-<span class="sourceLineNo">369</span> bottomF.initReader();<a name="line.369"></a>
-<span class="sourceLineNo">370</span> StoreFileReader bottom = bottomF.getReader();<a name="line.370"></a>
-<span class="sourceLineNo">371</span> ByteBuffer previous = null;<a name="line.371"></a>
-<span class="sourceLineNo">372</span> LOG.info("Midkey: " + midKV.toString());<a name="line.372"></a>
-<span class="sourceLineNo">373</span> ByteBuffer bbMidkeyBytes = ByteBuffer.wrap(midKV.getKey());<a name="line.373"></a>
-<span class="sourceLineNo">374</span> try {<a name="line.374"></a>
-<span class="sourceLineNo">375</span> // Now make two HalfMapFiles and assert they can read the full backing<a name="line.375"></a>
-<span class="sourceLineNo">376</span> // file, one from the top and the other from the bottom.<a name="line.376"></a>
-<span class="sourceLineNo">377</span> // Test bottom half first.<a name="line.377"></a>
-<span class="sourceLineNo">378</span> // Now test reading from the top.<a name="line.378"></a>
-<span class="sourceLineNo">379</span> boolean first = true;<a name="line.379"></a>
-<span class="sourceLineNo">380</span> ByteBuffer key = null;<a name="line.380"></a>
-<span class="sourceLineNo">381</span> HFileScanner topScanner = top.getScanner(false, false);<a name="line.381"></a>
-<span class="sourceLineNo">382</span> while ((!topScanner.isSeeked() && topScanner.seekTo()) ||<a name="line.382"></a>
-<span class="sourceLineNo">383</span> (topScanner.isSeeked() && topScanner.next())) {<a name="line.383"></a>
-<span class="sourceLineNo">384</span> key = ByteBuffer.wrap(((KeyValue) topScanner.getKey()).getKey());<a name="line.384"></a>
-<span class="sourceLineNo">385</span><a name="line.385"></a>
-<span class="sourceLineNo">386</span> if ((PrivateCellUtil.compare(topScanner.getReader().getComparator(), midKV, key.array(),<a name="line.386"></a>
-<span class="sourceLineNo">387</span> key.arrayOffset(), key.limit())) > 0) {<a name="line.387"></a>
-<span class="sourceLineNo">388</span> fail("key=" + Bytes.toStringBinary(key) + " < midkey=" +<a name="line.388"></a>
-<span class="sourceLineNo">389</span> midkey);<a name="line.389"></a>
-<span class="sourceLineNo">390</span> }<a name="line.390"></a>
-<span class="sourceLineNo">391</span> if (first) {<a name="line.391"></a>
-<span class="sourceLineNo">392</span> first = false;<a name="line.392"></a>
-<span class="sourceLineNo">393</span> LOG.info("First in top: " + Bytes.toString(Bytes.toBytes(key)));<a name="line.393"></a>
-<span class="sourceLineNo">394</span> }<a name="line.394"></a>
-<span class="sourceLineNo">395</span> }<a name="line.395"></a>
-<span class="sourceLineNo">396</span> LOG.info("Last in top: " + Bytes.toString(Bytes.toBytes(key)));<a name="line.396"></a>
-<span class="sourceLineNo">397</span><a name="line.397"></a>
-<span class="sourceLineNo">398</span> first = true;<a name="line.398"></a>
-<span class="sourceLineNo">399</span> HFileScanner bottomScanner = bottom.getScanner(false, false);<a name="line.399"></a>
-<span class="sourceLineNo">400</span> while ((!bottomScanner.isSeeked() && bottomScanner.seekTo()) ||<a name="line.400"></a>
-<span class="sourceLineNo">401</span> bottomScanner.next()) {<a name="line.401"></a>
-<span class="sourceLineNo">402</span> previous = ByteBuffer.wrap(((KeyValue) bottomScanner.getKey()).getKey());<a name="line.402"></a>
-<span class="sourceLineNo">403</span> key = ByteBuffer.wrap(((KeyValue) bottomScanner.getKey()).getKey());<a name="line.403"></a>
-<span class="sourceLineNo">404</span> if (first) {<a name="line.404"></a>
-<span class="sourceLineNo">405</span> first = false;<a name="line.405"></a>
-<span class="sourceLineNo">406</span> LOG.info("First in bottom: " +<a name="line.406"></a>
-<span class="sourceLineNo">407</span> Bytes.toString(Bytes.toBytes(previous)));<a name="line.407"></a>
-<span class="sourceLineNo">408</span> }<a name="line.408"></a>
-<span class="sourceLineNo">409</span> assertTrue(key.compareTo(bbMidkeyBytes) < 0);<a name="line.409"></a>
-<span class="sourceLineNo">410</span> }<a name="line.410"></a>
-<span class="sourceLineNo">411</span> if (previous != null) {<a name="line.411"></a>
-<span class="sourceLineNo">412</span> LOG.info("Last in bottom: " + Bytes.toString(Bytes.toBytes(previous)));<a name="line.412"></a>
-<span class="sourceLineNo">413</span> }<a name="line.413"></a>
-<span class="sourceLineNo">414</span> // Remove references.<a name="line.414"></a>
-<span class="sourceLineNo">415</span> regionFs.cleanupDaughterRegion(topHri);<a name="line.415"></a>
-<span class="sourceLineNo">416</span> regionFs.cleanupDaughterRegion(bottomHri);<a name="line.416"></a>
-<span class="sourceLineNo">417</span><a name="line.417"></a>
-<span class="sourceLineNo">418</span> // Next test using a midkey that does not exist in the file.<a name="line.418"></a>
-<span class="sourceLineNo">419</span> // First, do a key that is < than first key. Ensure splits behave<a name="line.419"></a>
-<span class="sourceLineNo">420</span> // properly.<a name="line.420"></a>
-<span class="sourceLineNo">421</span> byte [] badmidkey = Bytes.toBytes(" .");<a name="line.421"></a>
-<span class="sourceLineNo">422</span> assertTrue(fs.exists(f.getPath()));<a name="line.422"></a>
-<span class="sourceLineNo">423</span> topPath = splitStoreFile(regionFs, topHri, TEST_FAMILY, f, badmidkey, true);<a name="line.423"></a>
-<span class="sourceLineNo">424</span> bottomPath = splitStoreFile(regionFs, bottomHri, TEST_FAMILY, f, badmidkey, false);<a name="line.424"></a>
-<span class="sourceLineNo">425</span><a name="line.425"></a>
-<span class="sourceLineNo">426</span> assertNull(bottomPath);<a name="line.426"></a>
+<span class="sourceLineNo">346</span> // There is a case where a file with the hfilelink pattern is actually a daughter<a name="line.346"></a>
+<span class="sourceLineNo">347</span> // reference to a hfile link. This code in StoreFile that handles this case.<a name="line.347"></a>
+<span class="sourceLineNo">348</span><a name="line.348"></a>
+<span class="sourceLineNo">349</span> // Try to open store file from link<a name="line.349"></a>
+<span class="sourceLineNo">350</span> HStoreFile hsfA = new HStoreFile(this.fs, pathA, testConf, cacheConf, BloomType.NONE, true);<a name="line.350"></a>
+<span class="sourceLineNo">351</span> hsfA.initReader();<a name="line.351"></a>
+<span class="sourceLineNo">352</span><a name="line.352"></a>
+<span class="sourceLineNo">353</span> // Now confirm that I can read from the ref to link<a name="line.353"></a>
+<span class="sourceLineNo">354</span> int count = 1;<a name="line.354"></a>
+<span class="sourceLineNo">355</span> HFileScanner s = hsfA.getReader().getScanner(false, false);<a name="line.355"></a>
+<span class="sourceLineNo">356</span> s.seekTo();<a name="line.356"></a>
+<span class="sourceLineNo">357</span> while (s.next()) {<a name="line.357"></a>
+<span class="sourceLineNo">358</span> count++;<a name="line.358"></a>
+<span class="sourceLineNo">359</span> }<a name="line.359"></a>
+<span class="sourceLineNo">360</span> assertTrue(count > 0); // read some rows here<a name="line.360"></a>
+<span class="sourceLineNo">361</span><a name="line.361"></a>
+<span class="sourceLineNo">362</span> // Try to open store file from link<a name="line.362"></a>
+<span class="sourceLineNo">363</span> HStoreFile hsfB = new HStoreFile(this.fs, pathB, testConf, cacheConf, BloomType.NONE, true);<a name="line.363"></a>
+<span class="sourceLineNo">364</span> hsfB.initReader();<a name="line.364"></a>
+<span class="sourceLineNo">365</span><a name="line.365"></a>
+<span class="sourceLineNo">366</span> // Now confirm that I can read from the ref to link<a name="line.366"></a>
+<span class="sourceLineNo">367</span> HFileScanner sB = hsfB.getReader().getScanner(false, false);<a name="line.367"></a>
+<span class="sourceLineNo">368</span> sB.seekTo();<a name="line.368"></a>
+<span class="sourceLineNo">369</span><a name="line.369"></a>
+<span class="sourceLineNo">370</span> //count++ as seekTo() will advance the scanner<a name="line.370"></a>
+<span class="sourceLineNo">371</span> count++;<a name="line.371"></a>
+<span class="sourceLineNo">372</span> while (sB.next()) {<a name="line.372"></a>
+<span class="sourceLineNo">373</span> count++;<a name="line.373"></a>
+<span class="sourceLineNo">374</span> }<a name="line.374"></a>
+<span class="sourceLineNo">375</span><a name="line.375"></a>
+<span class="sourceLineNo">376</span> // read the rest of the rows<a name="line.376"></a>
+<span class="sourceLineNo">377</span> assertEquals((LAST_CHAR - FIRST_CHAR + 1) * (LAST_CHAR - FIRST_CHAR + 1), count);<a name="line.377"></a>
+<span class="sourceLineNo">378</span> }<a name="line.378"></a>
+<span class="sourceLineNo">379</span><a name="line.379"></a>
+<span class="sourceLineNo">380</span> private void checkHalfHFile(final HRegionFileSystem regionFs, final HStoreFile f)<a name="line.380"></a>
+<span class="sourceLineNo">381</span> throws IOException {<a name="line.381"></a>
+<span class="sourceLineNo">382</span> f.initReader();<a name="line.382"></a>
+<span class="sourceLineNo">383</span> Cell midkey = f.getReader().midKey().get();<a name="line.383"></a>
+<span class="sourceLineNo">384</span> KeyValue midKV = (KeyValue)midkey;<a name="line.384"></a>
+<span class="sourceLineNo">385</span> byte [] midRow = CellUtil.cloneRow(midKV);<a name="line.385"></a>
+<span class="sourceLineNo">386</span> // Create top split.<a name="line.386"></a>
+<span class="sourceLineNo">387</span> HRegionInfo topHri = new HRegionInfo(regionFs.getRegionInfo().getTable(),<a name="line.387"></a>
+<span class="sourceLineNo">388</span> null, midRow);<a name="line.388"></a>
+<span class="sourceLineNo">389</span> Path topPath = splitStoreFile(regionFs, topHri, TEST_FAMILY, f, midRow, true);<a name="line.389"></a>
+<span class="sourceLineNo">390</span> // Create bottom split.<a name="line.390"></a>
+<span class="sourceLineNo">391</span> HRegionInfo bottomHri = new HRegionInfo(regionFs.getRegionInfo().getTable(),<a name="line.391"></a>
+<span class="sourceLineNo">392</span> midRow, null);<a name="line.392"></a>
+<span class="sourceLineNo">393</span> Path bottomPath = splitStoreFile(regionFs, bottomHri, TEST_FAMILY, f, midRow, false);<a name="line.393"></a>
+<span class="sourceLineNo">394</span> // Make readers on top and bottom.<a name="line.394"></a>
+<span class="sourceLineNo">395</span> HStoreFile topF = new HStoreFile(this.fs, topPath, conf, cacheConf, BloomType.NONE, true);<a name="line.395"></a>
+<span class="sourceLineNo">396</span> topF.initReader();<a name="line.396"></a>
+<span class="sourceLineNo">397</span> StoreFileReader top = topF.getReader();<a name="line.397"></a>
+<span class="sourceLineNo">398</span> HStoreFile bottomF = new HStoreFile(this.fs, bottomPath, conf, cacheConf, BloomType.NONE, true);<a name="line.398"></a>
+<span class="sourceLineNo">399</span> bottomF.initReader();<a name="line.399"></a>
+<span class="sourceLineNo">400</span> StoreFileReader bottom = bottomF.getReader();<a name="line.400"></a>
+<span class="sourceLineNo">401</span> ByteBuffer previous = null;<a name="line.401"></a>
+<span class="sourceLineNo">402</span> LOG.info("Midkey: " + midKV.toString());<a name="line.402"></a>
+<span class="sourceLineNo">403</span> ByteBuffer bbMidkeyBytes = ByteBuffer.wrap(midKV.getKey());<a name="line.403"></a>
+<span class="sourceLineNo">404</span> try {<a name="line.404"></a>
+<span class="sourceLineNo">405</span> // Now make two HalfMapFiles and assert they can read the full backing<a name="line.405"></a>
+<span class="sourceLineNo">406</span> // file, one from the top and the other from the bottom.<a name="line.406"></a>
+<span class="sourceLineNo">407</span> // Test bottom half first.<a name="line.407"></a>
+<span class="sourceLineNo">408</span> // Now test reading from the top.<a name="line.408"></a>
+<span class="sourceLineNo">409</span> boolean first = true;<a name="line.409"></a>
+<span class="sourceLineNo">410</span> ByteBuffer key = null;<a name="line.410"></a>
+<span class="sourceLineNo">411</span> HFileScanner topScanner = top.getScanner(false, false);<a name="line.411"></a>
+<span class="sourceLineNo">412</span> while ((!topScanner.isSeeked() && topScanner.seekTo()) ||<a name="line.412"></a>
+<span class="sourceLineNo">413</span> (topScanner.isSeeked() && topScanner.next())) {<a name="line.413"></a>
+<span class="sourceLineNo">414</span> key = ByteBuffer.wrap(((KeyValue) topScanner.getKey()).getKey());<a name="line.414"></a>
+<span class="sourceLineNo">415</span><a name="line.415"></a>
+<span class="sourceLineNo">416</span> if ((PrivateCellUtil.compare(topScanner.getReader().getComparator(), midKV, key.array(),<a name="line.416"></a>
+<span class="sourceLineNo">417</span> key.arrayOffset(), key.limit())) > 0) {<a name="line.417"></a>
+<span class="sourceLineNo">418</span> fail("key=" + Bytes.toStringBinary(key) + " < midkey=" +<a name="line.418"></a>
+<span class="sourceLineNo">419</span> midkey);<a name="line.419"></a>
+<span class="sourceLineNo">420</span> }<a name="line.420"></a>
+<span class="sourceLineNo">421</span> if (first) {<a name="line.421"></a>
+<span class="sourceLineNo">422</span> first = false;<a name="line.422"></a>
+<span class="sourceLineNo">423</span> LOG.info("First in top: " + Bytes.toString(Bytes.toBytes(key)));<a name="line.423"></a>
+<span class="sourceLineNo">424</span> }<a name="line.424"></a>
+<span class="sourceLineNo">425</span> }<a name="line.425"></a>
+<span class="sourceLineNo">426</span> LOG.info("Last in top: " + Bytes.toString(Bytes.toBytes(key)));<a name="line.426"></a>
<span class="sourceLineNo">427</span><a name="line.427"></a>
-<span class="sourceLineNo">428</span> topF = new HStoreFile(this.fs, topPath, conf, cacheConf, BloomType.NONE, true);<a name="line.428"></a>
-<span class="sourceLineNo">429</span> topF.initReader();<a name="line.429"></a>
-<span class="sourceLineNo">430</span> top = topF.getReader();<a name="line.430"></a>
-<span class="sourceLineNo">431</span> // Now read from the top.<a name="line.431"></a>
-<span class="sourceLineNo">432</span> first = true;<a name="line.432"></a>
-<span class="sourceLineNo">433</span> topScanner = top.getScanner(false, false);<a name="line.433"></a>
-<span class="sourceLineNo">434</span> KeyValue.KeyOnlyKeyValue keyOnlyKV = new KeyValue.KeyOnlyKeyValue();<a name="line.434"></a>
-<span class="sourceLineNo">435</span> while ((!topScanner.isSeeked() && topScanner.seekTo()) ||<a name="line.435"></a>
-<span class="sourceLineNo">436</span> topScanner.next()) {<a name="line.436"></a>
-<span class="sourceLineNo">437</span> key = ByteBuffer.wrap(((KeyValue) topScanner.getKey()).getKey());<a name="line.437"></a>
-<span class="sourceLineNo">438</span> keyOnlyKV.setKey(key.array(), 0 + key.arrayOffset(), key.limit());<a name="line.438"></a>
-<span class="sourceLineNo">439</span> assertTrue(PrivateCellUtil.compare(topScanner.getReader().getComparator(), keyOnlyKV,<a name="line.439"></a>
-<span class="sourceLineNo">440</span> badmidkey, 0, badmidkey.length) >= 0);<a name="line.440"></a>
-<span class="sourceLineNo">441</span> if (first) {<a name="line.441"></a>
-<span class="sourceLineNo">442</span> first = false;<a name="line.442"></a>
-<span class="sourceLineNo">443</span> KeyValue keyKV = KeyValueUtil.createKeyValueFromKey(key);<a name="line.443"></a>
-<span class="sourceLineNo">444</span> LOG.info("First top when key < bottom: " + keyKV);<a name="line.444"></a>
-<span class="sourceLineNo">445</span> String tmp =<a name="line.445"></a>
-<span class="sourceLineNo">446</span> Bytes.toString(keyKV.getRowArray(), keyKV.getRowOffset(), keyKV.getRowLength());<a name="line.446"></a>
-<span class="sourceLineNo">447</span> for (int i = 0; i < tmp.length(); i++) {<a name="line.447"></a>
-<span class="sourceLineNo">448</span> assertTrue(tmp.charAt(i) == 'a');<a name="line.448"></a>
-<span class="sourceLineNo">449</span> }<a name="line.449"></a>
-<span class="sourceLineNo">450</span> }<a name="line.450"></a>
-<span class="sourceLineNo">451</span> }<a name="line.451"></a>
-<span class="sourceLineNo">452</span> KeyValue keyKV = KeyValueUtil.createKeyValueFromKey(key);<a name="line.452"></a>
-<span class="sourceLineNo">453</span> LOG.info("Last top when key < bottom: " + keyKV);<a name="line.453"></a>
-<span class="sourceLineNo">454</span> String tmp = Bytes.toString(keyKV.getRowArray(), keyKV.getRowOffset(), keyKV.getRowLength());<a name="line.454"></a>
-<span class="sourceLineNo">455</span> for (int i = 0; i < tmp.length(); i++) {<a name="line.455"></a>
-<span class="sourceLineNo">456</span> assertTrue(tmp.charAt(i) == 'z');<a name="line.456"></a>
-<span class="sourceLineNo">457</span> }<a name="line.457"></a>
-<span class="sourceLineNo">458</span> // Remove references.<a name="line.458"></a>
-<span class="sourceLineNo">459</span> regionFs.cleanupDaughterRegion(topHri);<a name="line.459"></a>
-<span class="sourceLineNo">460</span> regionFs.cleanupDaughterRegion(bottomHri);<a name="line.460"></a>
-<span class="sourceLineNo">461</span><a name="line.461"></a>
-<span class="sourceLineNo">462</span> // Test when badkey is > than last key in file ('||' > 'zz').<a name="line.462"></a>
-<span class="sourceLineNo">463</span> badmidkey = Bytes.toBytes("|||");<a name="line.463"></a>
-<span class="sourceLineNo">464</span> topPath = splitStoreFile(regionFs,topHri, TEST_FAMILY, f, badmidkey, true);<a name="line.464"></a>
-<span class="sourceLineNo">465</span> bottomPath = splitStoreFile(regionFs, bottomHri, TEST_FAMILY, f, badmidkey, false);<a name="line.465"></a>
-<span class="sourceLineNo">466</span> assertNull(topPath);<a name="line.466"></a>
-<span class="sourceLineNo">467</span><a name="line.467"></a>
-<span class="sourceLineNo">468</span> bottomF = new HStoreFile(this.fs, bottomPath, conf, cacheConf, BloomType.NONE, true);<a name="line.468"></a>
-<span class="sourceLineNo">469</span> bottomF.initReader();<a name="line.469"></a>
-<span class="sourceLineNo">470</span> bottom = bottomF.getReader();<a name="line.470"></a>
-<span class="sourceLineNo">471</span> first = true;<a name="line.471"></a>
-<span class="sourceLineNo">472</span> bottomScanner = bottom.getScanner(false, false);<a name="line.472"></a>
-<span class="sourceLineNo">473</span> while ((!bottomScanner.isSeeked() && bottomScanner.seekTo()) ||<a name="line.473"></a>
-<span class="sourceLineNo">474</span> bottomScanner.next()) {<a name="line.474"></a>
-<span class="sourceLineNo">475</span> key = ByteBuffer.wrap(((KeyValue) bottomScanner.getKey()).getKey());<a name="line.475"></a>
-<span class="sourceLineNo">476</span> if (first) {<a name="line.476"></a>
-<span class="sourceLineNo">477</span> first = false;<a name="line.477"></a>
-<span class="sourceLineNo">478</span> keyKV = KeyValueUtil.createKeyValueFromKey(key);<a name="line.478"></a>
-<span class="sourceLineNo">479</span> LOG.info("First bottom when key > top: " + keyKV);<a name="line.479"></a>
-<span class="sourceLineNo">480</span> tmp = Bytes.toString(keyKV.getRowArray(), keyKV.getRowOffset(), keyKV.getRowLength());<a name="line.480"></a>
-<span class="sourceLineNo">481</span> for (int i = 0; i < tmp.length(); i++) {<a name="line.481"></a>
-<span class="sourceLineNo">482</span> assertTrue(tmp.charAt(i) == 'a');<a name="line.482"></a>
-<span class="sourceLineNo">483</span> }<a name="line.483"></a>
-<span class="sourceLineNo">484</span> }<a name="line.484"></a>
-<span class="sourceLineNo">485</span> }<a name="line.485"></a>
-<span class="sourceLineNo">486</span> keyKV = KeyValueUtil.createKeyValueFromKey(key);<a name="line.486"></a>
-<span class="sourceLineNo">487</span> LOG.info("Last bottom when key > top: " + keyKV);<a name="line.487"></a>
-<span class="sourceLineNo">488</span> for (int i = 0; i < tmp.length(); i++) {<a name="line.488"></a>
-<span class="sourceLineNo">489</span> assertTrue(Bytes.toString(keyKV.getRowArray(), keyKV.getRowOffset(), keyKV.getRowLength())<a name="line.489"></a>
-<span class="sourceLineNo">490</span> .charAt(i) == 'z');<a name="line.490"></a>
-<span class="sourceLineNo">491</span> }<a name="line.491"></a>
-<span class="sourceLineNo">492</span> } finally {<a name="line.492"></a>
-<span class="sourceLineNo">493</span> if (top != null) {<a name="line.493"></a>
-<span class="sourceLineNo">494</span> top.close(true); // evict since we are about to delete the file<a name="line.494"></a>
-<span class="sourceLineNo">495</span> }<a name="line.495"></a>
-<span class="sourceLineNo">496</span> if (bottom != null) {<a name="line.496"></a>
-<span class="sourceLineNo">497</span> bottom.close(true); // evict since we are about to delete the file<a name="line.497"></a>
-<span class="sourceLineNo">498</span> }<a name="line.498"></a>
-<span class="sourceLineNo">499</span> fs.delete(f.getPath(), true);<a name="line.499"></a>
-<span class="sourceLineNo">500</span> }<a name="line.500"></a>
-<span class="sourceLineNo">501</span> }<a name="line.501"></a>
-<span class="sourceLineNo">502</span><a name="line.502"></a>
-<span class="sourceLineNo">503</span> private static StoreFileScanner get
<TRUNCATED>