You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/12/16 17:53:55 UTC
[GitHub] [camel-karavan] mgubaidullin opened a new issue #148: Run button doesn't work after VSCode upgrade to 1.63
mgubaidullin opened a new issue #148:
URL: https://github.com/apache/camel-karavan/issues/148
After upgrade VSCode from 1.62 to 1.63 `Run` button does not work anymore when Diargram (Webview) is opened.
For some reason arguments in `registerCommand` contains different `path` value, ex. `webview-panel/webview-XXXX`
than `host` value of `new URL(window.location.href)` in Webview itself.
In previous version of VSCode they was the same and we could match Button Click with the open WebView.
https://github.com/apache/camel-karavan/blob/0028aacfea847ea2a7f200faf42c85c43fdaf53c/karavan-vscode/src/extension.ts#L78
https://github.com/apache/camel-karavan/blob/0028aacfea847ea2a7f200faf42c85c43fdaf53c/karavan-vscode/webview/App.tsx#L66
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] apupier commented on issue #148: Run button doesn't work after VSCode upgrade to 1.63
Posted by GitBox <gi...@apache.org>.
apupier commented on issue #148:
URL: https://github.com/apache/camel-karavan/issues/148#issuecomment-996714693
I guess that now there is a distinction between the `host` and the iframe `name`, by using developer tools and inspecting the webview, I found:
```
<iframe name="05d3cd2a-7b10-4f87-a944-7dfcd6db49df" class="webview ready" sandbox="allow-scripts allow-same-origin allow-forms allow-pointer-lock allow-downloads" allow="clipboard-read; clipboard-write;" src="vscode-webview://2853133e-9bb6-49d8-a6c0-788031a21ab6/index.html?id=2853133e-9bb6-49d8-a6c0-788031a21ab6&swVersion=2&extensionId=camel-karavan.karavan&platform=electron&vscode-resource-base-authority=vscode-resource.vscode-webview.net&parentOrigin=vscode-file%3A%2F%2Fvscode-app" style="border: none; width: 100%; height: 100%;"></iframe>
```
I put log and the path provided to the command is now the iframe name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] mgubaidullin closed issue #148: Run button doesn't work after VSCode upgrade to 1.63
Posted by GitBox <gi...@apache.org>.
mgubaidullin closed issue #148:
URL: https://github.com/apache/camel-karavan/issues/148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org