You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/03/04 03:55:19 UTC

[GitHub] [dolphinscheduler] jxeditor opened a new pull request #8692: Fix positive integer judgment

jxeditor opened a new pull request #8692:
URL: https://github.com/apache/dolphinscheduler/pull/8692


   ## Purpose of the pull request
   
   Fix  positive integer judgment
   
   ## Brief change log
   
   Repair regular matching rules
   
   ## Verify this pull request
   
   This pull request is code cleanup without any test coverage.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] jxeditor commented on pull request #8692: [BUG] Fix positive integer judgment

Posted by GitBox <gi...@apache.org>.
jxeditor commented on pull request #8692:
URL: https://github.com/apache/dolphinscheduler/pull/8692#issuecomment-1060336080


   > Is there a related issue?
   
   <img width="646" alt="image" src="https://user-images.githubusercontent.com/51101283/156997398-40edece1-b001-454a-bfa2-764b4c08652c.png">
   There is no way to select 0 when using the dataX plug-in


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] songjianet commented on pull request #8692: [BUG] Fix positive integer judgment

Posted by GitBox <gi...@apache.org>.
songjianet commented on pull request #8692:
URL: https://github.com/apache/dolphinscheduler/pull/8692#issuecomment-1060380643


   > @songjianet please help review, and whether next-ui needs to be modified.
   
   In fact, there are many places in the old and new UI that have not been verified for positive integers, but if they are used normally, there will be basically no problems. Since time is relatively short, I plan to put this on the subsequent optimization and uniformly handle this in the project. problem, but will only be dealt with in the new UI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] jxeditor edited a comment on pull request #8692: [BUG] Fix positive integer judgment

Posted by GitBox <gi...@apache.org>.
jxeditor edited a comment on pull request #8692:
URL: https://github.com/apache/dolphinscheduler/pull/8692#issuecomment-1060350396


   Although I don't quite understand why selectors need regular matching,this should not be necessary,we cannot modify it manually.
   
   @zhuangchong 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] jxeditor commented on pull request #8692: [BUG] Fix positive integer judgment

Posted by GitBox <gi...@apache.org>.
jxeditor commented on pull request #8692:
URL: https://github.com/apache/dolphinscheduler/pull/8692#issuecomment-1060350396


   Although I don't quite understand why selectors need regular matching,this should not be necessary,we cannot modify it manually.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhuangchong commented on pull request #8692: [BUG] Fix positive integer judgment

Posted by GitBox <gi...@apache.org>.
zhuangchong commented on pull request #8692:
URL: https://github.com/apache/dolphinscheduler/pull/8692#issuecomment-1060375130


   @songjianet 
   please help review, and whether next-ui needs to be modified.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] jxeditor commented on pull request #8692: [BUG] Fix positive integer judgment

Posted by GitBox <gi...@apache.org>.
jxeditor commented on pull request #8692:
URL: https://github.com/apache/dolphinscheduler/pull/8692#issuecomment-1060279923


   @caishunfeng 
   @zhuangchong 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #8692: Fix positive integer judgment

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #8692:
URL: https://github.com/apache/dolphinscheduler/pull/8692#issuecomment-1058812353


   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8692&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8692&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8692&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8692&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8692&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8692&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=8692&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=8692&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=8692&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8692&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8692&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8692&resolved=false&types=CODE_SMELL)
   
   [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=8692&metric=coverage&view=list) No Coverage information  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=8692&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=8692&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] jxeditor edited a comment on pull request #8692: [BUG] Fix positive integer judgment

Posted by GitBox <gi...@apache.org>.
jxeditor edited a comment on pull request #8692:
URL: https://github.com/apache/dolphinscheduler/pull/8692#issuecomment-1060336080


   > Is there a related issue?
   
   <img width="646" alt="image" src="https://user-images.githubusercontent.com/51101283/156997398-40edece1-b001-454a-bfa2-764b4c08652c.png">
   There is no way to select 0 when using the dataX plug-in.
   
   In my opinion, regular expressions are wrong.
   <img width="938" alt="image" src="https://user-images.githubusercontent.com/51101283/156998029-12ea2ba3-ab63-4ac0-96ef-838f7bf52777.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhuangchong commented on pull request #8692: [BUG] Fix positive integer judgment

Posted by GitBox <gi...@apache.org>.
zhuangchong commented on pull request #8692:
URL: https://github.com/apache/dolphinscheduler/pull/8692#issuecomment-1060308377


   Is there a related issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org