You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by br...@apache.org on 2018/12/19 16:21:38 UTC

[cordova-ios] branch master updated: Ensure test failure on unexpected promise resolution (#485)

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-ios.git


The following commit(s) were added to refs/heads/master by this push:
     new fe01e5d  Ensure test failure on unexpected promise resolution (#485)
fe01e5d is described below

commit fe01e5dc8c756a6af1c3f8ec5daff7d2bac963ff
Author: Oliver Salzburg <ol...@gmail.com>
AuthorDate: Wed Dec 19 17:21:32 2018 +0100

    Ensure test failure on unexpected promise resolution (#485)
---
 tests/spec/component/versions.spec.js | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/tests/spec/component/versions.spec.js b/tests/spec/component/versions.spec.js
index fbc8dc2..0008a97 100644
--- a/tests/spec/component/versions.spec.js
+++ b/tests/spec/component/versions.spec.js
@@ -25,38 +25,40 @@ if (process.platform === 'darwin') {
     describe('versions', function () {
         describe('get_tool_version method', () => {
             it('should not have found tool by name.', (done) => {
-                versions.get_tool_version('unknown').catch((error) => {
-                    expect(error).toContain('is not valid tool name');
-                    done();
-                });
+                versions.get_tool_version('unknown')
+                    .then(() => done.fail('expected promise rejection'))
+                    .catch((error) => {
+                        expect(error).toContain('is not valid tool name');
+                        done();
+                    });
             });
 
             it('should find xcodebuild version.', (done) => {
                 versions.get_tool_version('xcodebuild').then((version) => {
                     expect(version).not.toBe(undefined);
                     done();
-                });
+                }).catch(() => done.fail('expected promise resolution'));
             });
 
             it('should find ios-sim version.', (done) => {
                 versions.get_tool_version('ios-sim').then((version) => {
                     expect(version).not.toBe(undefined);
                     done();
-                });
+                }).catch(() => done.fail('expected promise resolution'));
             });
 
             it('should find ios-deploy version.', (done) => {
                 versions.get_tool_version('ios-deploy').then((version) => {
                     expect(version).not.toBe(undefined);
                     done();
-                });
+                }).catch(() => done.fail('expected promise resolution'));
             });
 
             it('should find pod version.', (done) => {
                 versions.get_tool_version('pod').then((version) => {
                     expect(version).not.toBe(undefined);
                     done();
-                });
+                }).catch(() => done.fail('expected promise resolution'));
             });
         });
     });


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org