[GitHub] [helix] jiajunwang commented on a change in pull request #1715: Change MessageQueueMonitor from static to dynamic metric

[GitBox <gi...@apache.org>]

jiajunwang commented on a change in pull request #1715:
URL: https://github.com/apache/helix/pull/1715#discussion_r620807951



##########
File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/MessageQueueMonitorMBean.java
##########
@@ -21,6 +21,7 @@
 
 import org.apache.helix.monitoring.SensorNameProvider;
 
+@Deprecated

Review comment:
       Please remove it. There should be no direct reference to the MBean class. All usage should be done through the MBeanServer, so it is automatically backward compatible, and this class shall be removed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org