You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mcgilman <gi...@git.apache.org> on 2016/12/15 18:39:29 UTC
[GitHub] nifi pull request #1334: NIFI-3207: Incorrect URI generated when replicating...
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1334
NIFI-3207: Incorrect URI generated when replicating Template upload request
NIFI-3207
- Fixing the importUri when replicating a Template upload request. Previously was leveraging getResourceUri which considers proxy headers meant for client responses.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcgilman/nifi NIFI-3207
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1334.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1334
----
commit 5dc1b75092607d961259bc560106f44a7f4044d8
Author: Matt Gilman <ma...@gmail.com>
Date: 2016-12-15T18:36:46Z
NIFI-3207:
- Fixing the importUri when replicating a Template upload request. Previously was leveraging getResourceUri which considers proxy headers meant for client responses.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1334: NIFI-3207: Incorrect URI generated when replicating Templa...
Posted by rstjohn <gi...@git.apache.org>.
Github user rstjohn commented on the issue:
https://github.com/apache/nifi/pull/1334
After further testing of this Pull Request, I noticed a User-interface issue in Chrome that does not exist in Firefox or Safari. In Chrome, from the templates dialog, the "trash can" is missing. As such, I am unable to delete previously imported or saved templates. Here is a screenshot from Chrome. Note that the div is present, but not visible.
And here is the same screenshot from Firefox.
Here is Safari:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1334: NIFI-3207: Incorrect URI generated when replicating Templa...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1334
Thanks for the feedback. That button is present based on the users permission to modify the template [1]. Looking at the screenshot, the button has been added to the DOM so the permissions to the template are correct. I believe the button has just wrapped to the next line. Now the question is why has this happened.
Let's try to eliminate one other simple possibility first. The templates page is loaded via an iframe. This can sometimes cause caching issues. Resources are cached according to URL so if you access the instance differently (different scheme, host, or port) when bypassing the proxy, this may be what's happening. Opening the templates page directly (outside of the iframe) will allow you to clear the cache. This doesn't happen reliably when loading through an iframe.
Can you try popping the page out by clicking the arrow button next to the close 'X' in the upper right-hand corner of the shell? Once the page is in it's own page/tab can you clear the cache or do a hard refresh to see if that makes a difference?
Thanks.
[1] https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/templates/nf-templates-table.js#L265
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1334: NIFI-3207: Incorrect URI generated when replicating Templa...
Posted by rstjohn <gi...@git.apache.org>.
Github user rstjohn commented on the issue:
https://github.com/apache/nifi/pull/1334
Unfortunately, the browser is not zoomed when this occurs. The issue is far more convoluted than that. It appears that the issue is related, somehow, to the nginx reverse proxy issue. The delete button is missing only when the nginx proxy is used. If I connect to the NiFi cluster without the nginx reverse proxy, the button is visible and functional.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1334: NIFI-3207: Incorrect URI generated when replicating Templa...
Posted by rstjohn <gi...@git.apache.org>.
Github user rstjohn commented on the issue:
https://github.com/apache/nifi/pull/1334
Great job debugging the issue. It was, in fact, what you suspected: a caching issue. I was able to remedy the UI by extracting the template iframe into a separate tab. Then, I cleared the cache and did a hard refresh. After that the delete button was visible. Lastly, I refreshed the NiFi canvas and viewed the templates inside the iFrame and the delete button was visible. Thanks for taking the time to get this resolved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1334: NIFI-3207: Incorrect URI generated when replicating Templa...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1334
Thanks for checking back and providing these details. I think the button is wrapping to the next line. We've seen this sort of thing in the past. In fact, we just merged in a PR that addressed this in a few of the other tables. However, the issue has never been in Chrome. It's typically been with a different browser. Chrome seems to be rendering it ok for me right now.
Can you verify that the browser is not zoomed in at all? You should be able to go to View -> Actual Size and see if the button shows up again. Let me know if this doesn't help.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1334: NIFI-3207: Incorrect URI generated when replicating Templa...
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/1334
Reviewed the change, all looks good!
I was able to reproduce the issue on a docker environment with an un-secure NiFi cluster running behind a nginx which terminates SSL. Docker-compose file is available [here](https://github.com/ijokarumawak/nifi-integration-tests/blob/master/docker-compose-nginx-ssl-terminate-nifi-cluster.yml).
Then, confirmed that a template file can be uploaded after applying this PR.
Also, I double checked the usage of `isReplicateRequest()` and `getRequestReplicator()` methods. Confirmed that `ProcessGroupResource.uploadTemplate()` is the only one that construct URI without using uriInfo.
Thanks for reporting this issue, @rstjohn , and the fix, @mcgilman !
I'm merging this into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1334: NIFI-3207: Incorrect URI generated when replicating...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1334
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---