You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Padma Priya N <pa...@gmail.com> on 2017/01/04 09:25:24 UTC
Review Request 55167: AMBARI-19354 : Invalid message is shown after
saving the workflow
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55167/
-----------------------------------------------------------
Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
Bugs: AMBARI-19354
https://issues.apache.org/jira/browse/AMBARI-19354
Repository: ambari
Description
-------
Invalid message is shown after saving the workflow. The message "Transition deleted Undo" is shown even when no changes are made to the workflow.
Steps to reproduce :
1) Import a workflow.
2) Click on one of the action nodes and open settings.
3) Without making any change, click on 'Save'
After saving, message "Transition deleted Undo" is shown to the user.
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js c6264ba
contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-path-util.js c921455
Diff: https://reviews.apache.org/r/55167/diff/
Testing
-------
Manual
Thanks,
Padma Priya N
Re: Review Request 55167: AMBARI-19354 : Invalid message is shown
after saving the workflow
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55167/#review160482
-----------------------------------------------------------
Ship it!
Ship It!
- Nitiraj Rathore
On Jan. 4, 2017, 9:25 a.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55167/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2017, 9:25 a.m.)
>
>
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-19354
> https://issues.apache.org/jira/browse/AMBARI-19354
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Invalid message is shown after saving the workflow. The message "Transition deleted Undo" is shown even when no changes are made to the workflow.
> Steps to reproduce :
> 1) Import a workflow.
> 2) Click on one of the action nodes and open settings.
> 3) Without making any change, click on 'Save'
> After saving, message "Transition deleted Undo" is shown to the user.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js c6264ba
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-path-util.js c921455
>
> Diff: https://reviews.apache.org/r/55167/diff/
>
>
> Testing
> -------
>
> Manual
>
>
> Thanks,
>
> Padma Priya N
>
>
Re: Review Request 55167: AMBARI-19354 : Invalid message is shown
after saving the workflow
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55167/#review160700
-----------------------------------------------------------
Ship it!
Ship It!
- Pallav Kulshreshtha
On Jan. 4, 2017, 9:25 a.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55167/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2017, 9:25 a.m.)
>
>
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-19354
> https://issues.apache.org/jira/browse/AMBARI-19354
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Invalid message is shown after saving the workflow. The message "Transition deleted Undo" is shown even when no changes are made to the workflow.
> Steps to reproduce :
> 1) Import a workflow.
> 2) Click on one of the action nodes and open settings.
> 3) Without making any change, click on 'Save'
> After saving, message "Transition deleted Undo" is shown to the user.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js c6264ba
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-path-util.js c921455
>
> Diff: https://reviews.apache.org/r/55167/diff/
>
>
> Testing
> -------
>
> Manual
>
>
> Thanks,
>
> Padma Priya N
>
>