[jira] [Commented] (ZOOKEEPER-1460) IPv6 literal address not supported for quorum members

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225394#comment-15225394 ] 

Hadoop QA commented on ZOOKEEPER-1460:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12796945/ZOOKEEPER-1460-branch3.4.patch
  against trunk revision 1736259.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3136//console

This message is automatically generated.

> IPv6 literal address not supported for quorum members
> -----------------------------------------------------
>
>                 Key: ZOOKEEPER-1460
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1460
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: quorum
>    Affects Versions: 3.4.3
>            Reporter: Chris Dolan
>            Assignee: Joseph Walton
>             Fix For: 3.4.9, 3.5.2, 3.6.0
>
>         Attachments: ZOOKEEPER-1460-accept-square-bracket-delimited-IPv6-literals.2.diff, ZOOKEEPER-1460-accept-square-bracket-delimited-IPv6-literals.diff, ZOOKEEPER-1460-branch3.4.patch, ZOOKEEPER-1460-for-3.5.0.patch, ZOOKEEPER-1460.003.patch
>
>
> Via code inspection, I see that the "server.nnn" configuration key does not support literal IPv6 addresses because the property value is split on ":". In v3.4.3, the problem is in QuorumPeerConfig:
> {noformat}
> String parts[] = value.split(":");
> InetSocketAddress addr = new InetSocketAddress(parts[0],
>                         Integer.parseInt(parts[1]));
> {noformat}
> In the current trunk (http://svn.apache.org/viewvc/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java?view=markup) this code has been refactored into QuorumPeer.QuorumServer, but the bug remains:
> {noformat}
> String serverClientParts[] = addressStr.split(";");
> String serverParts[] = serverClientParts[0].split(":");
> addr = new InetSocketAddress(serverParts[0],
>                         Integer.parseInt(serverParts[1]));
> {noformat}
> This bug probably affects very few users because most will naturally use a hostname rather than a literal IP address. But given that IPv6 addresses are supported for clients via ZOOKEEPER-667 it seems that server support should be fixed too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)