You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2018/07/09 10:35:03 UTC
Review Request 67855: Added virtualenv requirements watcher to Python
3 mesos-style.py.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67855/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Till Toenshoff.
Bugs: MESOS-8882
https://issues.apache.org/jira/browse/MESOS-8882
Repository: mesos
Description
-------
Added virtualenv requirements watcher to Python 3 mesos-style.py.
Diffs
-----
support/python3/mesos-style.py 0a4b1b1a0287011faf4488522f88587e07b3c874
Diff: https://reviews.apache.org/r/67855/diff/1/
Testing
-------
Checked that this commit trigerred the script (I am using Python 3 by default).
Thanks,
Armand Grillet
Re: Review Request 67855: Added virtualenv requirements watcher to
Python 3 mesos-style.py.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67855/
-----------------------------------------------------------
(Updated July 11, 2018, 9:22 a.m.)
Review request for mesos, Benjamin Bannier, Kevin Klues, and Till Toenshoff.
Changes
-------
Improved commit message.
Bugs: MESOS-8882
https://issues.apache.org/jira/browse/MESOS-8882
Repository: mesos
Description (updated)
-------
The Python and JavaScript linters run by mesos-style.py, called
by our Git hooks, require a virtual environment. This virtual
environment needs to be rebuilt by running `build-virtualenv`
each time the pip dependencies of our Python codebase are
updated.
The check `should_build_virtualenv` had not been added to the Python 3
`mesos-style.py` for an unknown reason and this is now fixed.
We pass the Python interpreter used to run `mesos-style.py` when running
`build-virtualenv` in case Python 3 is used to run `mesos-style.py`
but Python 2 is still the default `python`.
Diffs (updated)
-----
support/python3/mesos-style.py 0a4b1b1a0287011faf4488522f88587e07b3c874
Diff: https://reviews.apache.org/r/67855/diff/2/
Changes: https://reviews.apache.org/r/67855/diff/1-2/
Testing
-------
Checked that this commit trigerred the script (I am using Python 3 by default).
Thanks,
Armand Grillet
Re: Review Request 67855: Added virtualenv requirements watcher to
Python 3 mesos-style.py.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67855/#review205916
-----------------------------------------------------------
Ship it!
Can you clarify the commit message? It should probably mention something about always using `venv` for `python3` and `virtualenv` for `python2`.
support/python3/mesos-style.py
Lines 516 (patched)
<https://reviews.apache.org/r/67855/#comment288846>
Next time we make a modification here we should introduce a variable for the list of touched files `sys.argv[1:]`.
- Benjamin Bannier
On July 9, 2018, 12:35 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67855/
> -----------------------------------------------------------
>
> (Updated July 9, 2018, 12:35 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Kevin Klues, and Till Toenshoff.
>
>
> Bugs: MESOS-8882
> https://issues.apache.org/jira/browse/MESOS-8882
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added virtualenv requirements watcher to Python 3 mesos-style.py.
>
>
> Diffs
> -----
>
> support/python3/mesos-style.py 0a4b1b1a0287011faf4488522f88587e07b3c874
>
>
> Diff: https://reviews.apache.org/r/67855/diff/1/
>
>
> Testing
> -------
>
> Checked that this commit trigerred the script (I am using Python 3 by default).
>
>
> Thanks,
>
> Armand Grillet
>
>