You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@predictionio.apache.org by takezoe <gi...@git.apache.org> on 2017/10/22 13:28:51 UTC
[GitHub] incubator-predictionio-template-text-classifier pull request #15: Update for...
GitHub user takezoe opened a pull request:
https://github.com/apache/incubator-predictionio-template-text-classifier/pull/15
Update for PredictionIO 0.12.0-incubating
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/takezoe/incubator-predictionio-template-text-classifier release-0.12.0-incubating
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-predictionio-template-text-classifier/pull/15.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15
----
commit 71731659ec2cce88a6a6d3836f67e78845264dbb
Author: Naoki Takezoe <ta...@gmail.com>
Date: 2017-10-22T13:20:34Z
Update for PredictionIO 0.12.0-incubating
----
---
[GitHub] incubator-predictionio-template-text-classifier issue #15: Update for Predic...
Posted by takezoe <gi...@git.apache.org>.
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio-template-text-classifier/pull/15
@nlauchande Sure! It looks to need to fix `Preparator` and `NBAlgorithmParams` additionally.
---
[GitHub] incubator-predictionio-template-text-classifier issue #15: Update for Predic...
Posted by takezoe <gi...@git.apache.org>.
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio-template-text-classifier/pull/15
Sorry, this pull request was not enough to move SparkML. Since I can't do it immediately, once close this pull request.
---
[GitHub] incubator-predictionio-template-text-classifier issue #15: Update for Predic...
Posted by nlauchande <gi...@git.apache.org>.
Github user nlauchande commented on the issue:
https://github.com/apache/incubator-predictionio-template-text-classifier/pull/15
@takezoe No problems, please go ahead wouldn't be able to start work on it
today !!
On Tue, Nov 14, 2017 at 11:25 AM, Naoki Takezoe <no...@github.com>
wrote:
> @nlauchande <https://github.com/nlauchande> Sorry, it was easier than my
> expectation.
>
> I could confirm to work this template by this fix:
> takezoe/incubator-predictionio-template-text-classifier@285da4f
> <https://github.com/takezoe/incubator-predictionio-template-text-classifier/commit/285da4f0523d155feaf9445fd6cd214883f2c94d>
>
> If you didn't start work on it, I would like to recreate pull request.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-predictionio-template-text-classifier/pull/15#issuecomment-344195989>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAnfQxjcEogoX-7BEU9x8Uhlk-ppp1NCks5s2VyTgaJpZM4QB8sj>
> .
>
---
[GitHub] incubator-predictionio-template-text-classifier issue #15: Update for Predic...
Posted by takezoe <gi...@git.apache.org>.
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio-template-text-classifier/pull/15
Fixed in #16
---
[GitHub] incubator-predictionio-template-text-classifier pull request #15: Update for...
Posted by takezoe <gi...@git.apache.org>.
Github user takezoe closed the pull request at:
https://github.com/apache/incubator-predictionio-template-text-classifier/pull/15
---
[GitHub] incubator-predictionio-template-text-classifier issue #15: Update for Predic...
Posted by nlauchande <gi...@git.apache.org>.
Github user nlauchande commented on the issue:
https://github.com/apache/incubator-predictionio-template-text-classifier/pull/15
Hey @takezoe i am interested on tackling this task. Can i work on it ?
---
[GitHub] incubator-predictionio-template-text-classifier issue #15: Update for Predic...
Posted by takezoe <gi...@git.apache.org>.
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio-template-text-classifier/pull/15
@nlauchande Sorry, it was easier than my expectation.
I could confirm to work this template by this fix:
https://github.com/takezoe/incubator-predictionio-template-text-classifier/commit/285da4f0523d155feaf9445fd6cd214883f2c94d
If you didn't start work on it, I would like to recreate pull request.
---