You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/05/20 12:51:06 UTC

[GitHub] [incubator-superset] villebro opened a new pull request #9859: fix: raise error in sqllab when using reserved column name

villebro opened a new pull request #9859:
URL: https://github.com/apache/incubator-superset/pull/9859


   ### SUMMARY
   Currently Sql Lab accepts the column name `__timestamp`, which causes problems when pressing the "Explore" button. This adds a check for column names starting with double underscores.
   
   ### BEFORE
   ![image](https://user-images.githubusercontent.com/33317356/82447710-54c05080-9ab1-11ea-9354-91181055157e.png)
   ![image](https://user-images.githubusercontent.com/33317356/82447785-6f92c500-9ab1-11ea-892a-c3ff8334c25a.png)
   
   ### AFTER
   ![image](https://user-images.githubusercontent.com/33317356/82447724-5d188b80-9ab1-11ea-9c3f-eb7877cb460c.png)
   
   ### TEST PLAN
   Local testing + new tests
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9859: fix: raise error in sqllab when using reserved column name

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9859:
URL: https://github.com/apache/incubator-superset/pull/9859#issuecomment-631456827


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9859?src=pr&el=h1) Report
   > Merging [#9859](https://codecov.io/gh/apache/incubator-superset/pull/9859?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/1a775e26124fb97c96c4872492819722f1123400&el=desc) will **increase** coverage by `6.27%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9859/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9859?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9859      +/-   ##
   ==========================================
   + Coverage   64.61%   70.89%   +6.27%     
   ==========================================
     Files         536      588      +52     
     Lines       29405    30793    +1388     
     Branches     2879     3238     +359     
   ==========================================
   + Hits        19001    21830    +2829     
   + Misses      10225     8845    -1380     
   + Partials      179      118      -61     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.17% <0.00%> (-0.87%)` | :arrow_down: |
   | #javascript | `59.30% <100.00%> (?)` | |
   | #python | `71.20% <ø> (-0.07%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9859?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `74.07% <100.00%> (+69.07%)` | :arrow_up: |
   | [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
   | [...rset-frontend/src/setup/setupErrorMessagesExtra.ts](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlc0V4dHJhLnRz) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupErrorMessages.ts](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlcy50cw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
   | [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [.../src/components/Select/WindowedSelect/windowed.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L3dpbmRvd2VkLnRzeA==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupApp.ts](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQXBwLnRz) | `25.00% <0.00%> (-3.58%)` | :arrow_down: |
   | [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `88.57% <0.00%> (-2.86%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-2.00%)` | :arrow_down: |
   | ... and [197 more](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9859?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9859?src=pr&el=footer). Last update [1a775e2...75e9615](https://codecov.io/gh/apache/incubator-superset/pull/9859?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] eugeniamz commented on pull request #9859: fix: raise error in sqllab when using reserved column name

Posted by GitBox <gi...@apache.org>.
eugeniamz commented on pull request #9859:
URL: https://github.com/apache/incubator-superset/pull/9859#issuecomment-641999735


   I understand that this the best solution for now, at list this will avoid the back and forward. Thanks Ville!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] eugeniamz commented on pull request #9859: fix: raise error in sqllab when using reserved column name

Posted by GitBox <gi...@apache.org>.
eugeniamz commented on pull request #9859:
URL: https://github.com/apache/incubator-superset/pull/9859#issuecomment-631455790


   It is a good fix to improve the error message but CHARTs generate the query with reserved words so if the workflow is 
   
   Chart -> SQL Lab : you get the reserved word and needs to be changed if you want to Explore the data again. 
   
   If in CHARTs we don't generate reserved words, that should resolve the issue to the root.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] villebro commented on pull request #9859: fix: raise error in sqllab when using reserved column name

Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #9859:
URL: https://github.com/apache/incubator-superset/pull/9859#issuecomment-632517957


   @eugeniamz the thing here is that the query as such is not really usable for re-exploration, as it has time grains, filters etc burned into the query. My interpretation is that this feature is used for throwaway analysis purposes only. Perhaps we should also add a comment above the query to that effect to explain that the query is only a reflection of a certain chart, and should usually not be used as a basis for a new chart?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9859: fix: raise error in sqllab when using reserved column name

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9859:
URL: https://github.com/apache/incubator-superset/pull/9859#issuecomment-631456827


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9859?src=pr&el=h1) Report
   > Merging [#9859](https://codecov.io/gh/apache/incubator-superset/pull/9859?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/1a775e26124fb97c96c4872492819722f1123400&el=desc) will **increase** coverage by `6.51%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9859/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9859?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9859      +/-   ##
   ==========================================
   + Coverage   64.61%   71.13%   +6.51%     
   ==========================================
     Files         536      588      +52     
     Lines       29405    30793    +1388     
     Branches     2879     3238     +359     
   ==========================================
   + Hits        19001    21904    +2903     
   + Misses      10225     8778    -1447     
   + Partials      179      111      -68     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.95% <0.00%> (-0.09%)` | :arrow_down: |
   | #javascript | `59.30% <100.00%> (?)` | |
   | #python | `71.27% <ø> (ø)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9859?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `74.07% <100.00%> (+69.07%)` | :arrow_up: |
   | [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
   | [...rset-frontend/src/setup/setupErrorMessagesExtra.ts](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlc0V4dHJhLnRz) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupErrorMessages.ts](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlcy50cw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
   | [.../src/components/Select/WindowedSelect/windowed.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L3dpbmRvd2VkLnRzeA==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupApp.ts](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQXBwLnRz) | `25.00% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `100.00% <0.00%> (ø)` | |
   | [superset-frontend/src/components/styles.ts](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvc3R5bGVzLnRz) | `100.00% <0.00%> (ø)` | |
   | [superset-frontend/src/SqlLab/utils/sqlKeywords.ts](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi91dGlscy9zcWxLZXl3b3Jkcy50cw==) | `100.00% <0.00%> (ø)` | |
   | [...et-frontend/src/dashboard/util/isDashboardEmpty.ts](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzRGFzaGJvYXJkRW1wdHkudHM=) | `100.00% <0.00%> (ø)` | |
   | ... and [192 more](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9859?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9859?src=pr&el=footer). Last update [1a775e2...75e9615](https://codecov.io/gh/apache/incubator-superset/pull/9859?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] villebro merged pull request #9859: fix: raise error in sqllab when using reserved column name

Posted by GitBox <gi...@apache.org>.
villebro merged pull request #9859:
URL: https://github.com/apache/incubator-superset/pull/9859


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #9859: fix: raise error in sqllab when using reserved column name

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9859:
URL: https://github.com/apache/incubator-superset/pull/9859#issuecomment-631456827


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9859?src=pr&el=h1) Report
   > Merging [#9859](https://codecov.io/gh/apache/incubator-superset/pull/9859?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/1a775e26124fb97c96c4872492819722f1123400&el=desc) will **increase** coverage by `1.39%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9859/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9859?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9859      +/-   ##
   ==========================================
   + Coverage   64.61%   66.01%   +1.39%     
   ==========================================
     Files         536      588      +52     
     Lines       29405    30610    +1205     
     Branches     2879     3238     +359     
   ==========================================
   + Hits        19001    20206    +1205     
   + Misses      10225    10217       -8     
   - Partials      179      187       +8     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.30% <100.00%> (?)` | |
   | #python | `70.79% <ø> (-0.48%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9859?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `74.07% <100.00%> (+69.07%)` | :arrow_up: |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [319 more](https://codecov.io/gh/apache/incubator-superset/pull/9859/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9859?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9859?src=pr&el=footer). Last update [1a775e2...75e9615](https://codecov.io/gh/apache/incubator-superset/pull/9859?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org