[jira] [Commented] (CURATOR-107) Regarding large number of watch count

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CURATOR-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14004626#comment-14004626 ] 

ASF GitHub Bot commented on CURATOR-107:
----------------------------------------

GitHub user domwong opened a pull request:

    https://github.com/apache/curator/pull/7

    Curator locks leaving dangling watches

    As per https://issues.apache.org/jira/browse/CURATOR-107 . I've seen this in our services too. 
    
    The issue is because the code is using exists() call rather than getData() for creating a watch for lock. exists() creates a watch regardless of whether the node exists or not, getData() will only create the watch if node exists

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/domwong/curator master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/7.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #7
    
----
commit 8a94985c07b3e6f74ac1a2935af008cbdb649410
Author: Dominic Wong <do...@hailocab.com>
Date:   2014-05-21T12:20:55Z

    Lock is leaving dangling watchers for nodes that don't exist.

commit c9716499642b2dd4a0d77e5df6f9b84e8dfc90d0
Author: Dominic Wong <do...@hailocab.com>
Date:   2014-05-21T12:40:39Z

    Catch no node exception

commit ac57e11b34bb2970775b385f5a1e94bccd287232
Author: Dominic Wong <do...@hailocab.com>
Date:   2014-05-21T12:45:54Z

    No need for null check

----


> Regarding large number of watch count
> -------------------------------------
>
>                 Key: CURATOR-107
>                 URL: https://issues.apache.org/jira/browse/CURATOR-107
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Recipes
>    Affects Versions: 2.4.1, 2.4.2
>         Environment: ZooKeeper 3.4.6
>            Reporter: Hyun Sik Kang
>              Labels: locks
>             Fix For: 2.5.0
>
>
> It's about issue that zookeeper's watch count is being increased.
> I wrote issue on zookeeper mailing list but I couldn't get cool answer yet.
> Please share any opinion with us if you have an idea..
> http://zookeeper-user.578899.n2.nabble.com/Regarding-large-number-of-watch-count-td7579811.html
> Refer to this article.
> I've used following code for getting and releasing lock
> try {
>  lock.acquire(...);
> } finally {
>  lock.release();
> }
> Please check if I misunderstood how to use curator properly.
> Thank you.



--
This message was sent by Atlassian JIRA
(v6.2#6252)