[GitHub] [dubbo] icodening commented on a diff in pull request #11965: optimize ThreadlessExecutor

["icodening (via GitHub)" <gi...@apache.org>]

icodening commented on code in PR #11965:
URL: https://github.com/apache/dubbo/pull/11965#discussion_r1152062109


##########
dubbo-common/src/main/java/org/apache/dubbo/common/threadpool/ThreadlessExecutor.java:
##########
@@ -56,60 +58,37 @@ public void setWaitingFuture(CompletableFuture<?> waitingFuture) {
         this.waitingFuture = waitingFuture;
     }
 
-    private boolean isFinished() {
-        return finished;
-    }
-
-    private void setFinished(boolean finished) {
-        this.finished = finished;
-    }
-
     public boolean isWaiting() {

Review Comment:
   no need here, to be considered



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org