You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "hudeqi (via GitHub)" <gi...@apache.org> on 2023/05/10 10:10:25 UTC

[GitHub] [kafka] hudeqi commented on a diff in pull request #13697: MINOR:code optimization in QuorumController

hudeqi commented on code in PR #13697:
URL: https://github.com/apache/kafka/pull/13697#discussion_r1189682174


##########
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java:
##########
@@ -350,6 +350,7 @@ public void testFenceMultipleBrokers() throws Throwable {
         }
     }
 
+    @Disabled

Review Comment:
   > I think we forgot a `@Test` here.
   thanks your reply.
   I saw that there was a “@Test” annotation before, but it was removed at this [commit](https://github.com/apache/kafka/commit/8c88cdb7186b1d594f991eb324356dcfcabdf18a). I wonder if it was intentional? @dengziming 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org