[GitHub] [openwhisk] mcdan commented on a change in pull request #4754: Mcdan/truncate keep running

[GitBox <gi...@apache.org>]

mcdan commented on a change in pull request #4754: Mcdan/truncate keep running
URL: https://github.com/apache/openwhisk/pull/4754#discussion_r350363778
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/core/entity/ActivationResult.scala
 ##########
 @@ -62,40 +63,47 @@ protected[core] object ActivationResponse extends DefaultJsonProtocol {
   val ApplicationError = 1 // action ran but there was an error and it was handled
   val DeveloperError = 2 // action ran but failed to handle an error, or action did not run and failed to initialize
   val WhiskError = 3 // internal system error
+  val Truncated = 4 // action ran correctly, but returned a response that was too large
 
 Review comment:
   I thought knowing the difference is useful as there might be other areas of code that might want to know that the response was really big.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services