You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/02/06 10:54:12 UTC
Re: Review Request 65298: Split test flags into header and source
files.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65298/#review196884
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/flags.hpp
Line 25 (original), 24 (patched)
<https://reviews.apache.org/r/65298/#comment276786>
This is not needed.
src/tests/flags.cpp
Line 17 (original), 28 (patched)
<https://reviews.apache.org/r/65298/#comment276785>
This one needs to be included first.
- Benjamin Bannier
On Jan. 25, 2018, 8:29 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65298/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2018, 8:29 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Gaston Kleiman.
>
>
> Bugs: MESOS-7016
> https://issues.apache.org/jira/browse/MESOS-7016
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Split the test flags into header and source files to reduce the amount
> of recompilation necessary when the implementation changes.
>
>
> Diffs
> -----
>
> src/tests/flags.hpp df4d4588f405ea884bb89021264e70218e054fae
> src/tests/flags.cpp 4542f3443830474edd97e8b695af0c61685e947c
>
>
> Diff: https://reviews.apache.org/r/65298/diff/6/
>
>
> Testing
> -------
>
> make check (Fedora 27)
>
>
> Thanks,
>
> James Peach
>
>