[GitHub] [lucene-solr] dweiss commented on a change in pull request #2295: LUCENE-9726: Hunspell: speed up spellchecking by stopping at a single…

[GitBox <gi...@apache.org>]

dweiss commented on a change in pull request #2295:
URL: https://github.com/apache/lucene-solr/pull/2295#discussion_r569575287



##########
File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Stemmer.java
##########
@@ -319,6 +345,11 @@ private boolean containsSharpS(char[] word, int offset, int length) {
     return deduped;
   }
 
+  interface RootProcessor {
+    /** @return whether the processing should be continued */
+    boolean processRoot(char[] buffer, int offset, int length, IntsRef forms, int formID);

Review comment:
       Use CharsRef instead of three separate parameters here? Shortens parameters list a bit. On the calling side it can be a short-lived wrapper (new CharsRef(...)).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org