You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "dlmarion (via GitHub)" <gi...@apache.org> on 2024/03/12 20:07:39 UTC
[PR] Resolved elasticity TODOs in Manager [accumulo]
dlmarion opened a new pull request, #4365:
URL: https://github.com/apache/accumulo/pull/4365
Removed the TODO for the bulkImports as it is still being set by BulkImport V2 and referenced in the Monitor. Implemented the suggestion in the other TODO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Resolved elasticity TODOs in Manager [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion merged PR #4365:
URL: https://github.com/apache/accumulo/pull/4365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Resolved elasticity TODOs in Manager [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #4365:
URL: https://github.com/apache/accumulo/pull/4365#discussion_r1522156779
##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -243,14 +243,16 @@ public synchronized ManagerState getManagerState() {
return state;
}
- // ELASTICITIY_TODO it would be nice if this method could take DataLevel as an argument and only
- // retrieve information about compactions in that data level. Attempted this and a lot of
- // refactoring was needed to get that small bit of information to this method. Would be best to
- // address this after issue. May be best to attempt this after #3576.
- public Map<FateId,Map<String,String>> getCompactionHints() {
+ public Map<FateId,Map<String,String>> getCompactionHints(DataLevel level) {
+ Predicate<TableId> tablePredicate = (tableId) -> true;
+ if (level == DataLevel.ROOT) {
+ tablePredicate = (tableId) -> AccumuloTable.ROOT.tableId().equals(tableId) ? true : false;
+ } else if (level == DataLevel.METADATA) {
+ tablePredicate = (tableId) -> AccumuloTable.METADATA.tableId().equals(tableId) ? true : false;
+ }
Review Comment:
May be able to do this
```suggestion
Predicate<TableId> tablePredicate = (tableId) -> DataLevel.of(tableId) == level;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org