You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/12/23 07:37:38 UTC
[GitHub] [rocketmq] TheNorthMemory opened a new issue, #5768: back-incompatible the RequestCode(`REGISTER_TOPIC_IN_NAMESRV`) with `217` value
TheNorthMemory opened a new issue, #5768:
URL: https://github.com/apache/rocketmq/issues/5768
1. Please describe the issue you observed:
There was described the `217` code as `GET_KV_CONFIG_BY_VALUE` label, see [here](https://github.com/apache/rocketmq-client-cpp/blob/master/src/protocol/MQProtos.h#L98-L100)
```c++
GET_KV_CONFIG_BY_VALUE = 217,
```
But since `5.0.0-beta`, the RequestCode(`217`) may be reusable as `REGISTER_TOPIC_IN_NAMESRV`
https://github.com/apache/rocketmq/blob/ec5d3236f65786be7dde712dda5f5ee152d0dce6/remoting/src/main/java/org/apache/rocketmq/remoting/protocol/RequestCode.java#L133
Those two kind of `RemotingCommand` operations looks like incompatible, the one `GET_KV_CONFIG_BY_VALUE` mostly same as fetching and another `REGISTER_TOPIC_IN_NAMESRV` sames to pushing.
It's suggest that toggle the `REGISTER_TOPIC_IN_NAMESRV` code to another one for the back compatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] TheNorthMemory commented on issue #5768: back-incompatible the RequestCode(`REGISTER_TOPIC_IN_NAMESRV`) with `217` value
Posted by "TheNorthMemory (via GitHub)" <gi...@apache.org>.
TheNorthMemory commented on issue #5768:
URL: https://github.com/apache/rocketmq/issues/5768#issuecomment-1464929296
> @TheNorthMemory @leizhiyuan @Oliverwqcwrw can I pick this up ?
Sure, I'm not good at JAVA and glad to see it is solved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Abhijeetmishr commented on issue #5768: back-incompatible the RequestCode(`REGISTER_TOPIC_IN_NAMESRV`) with `217` value
Posted by "Abhijeetmishr (via GitHub)" <gi...@apache.org>.
Abhijeetmishr commented on issue #5768:
URL: https://github.com/apache/rocketmq/issues/5768#issuecomment-1464853207
@TheNorthMemory @leizhiyuan @Oliverwqcwrw can I pick this up ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Abhijeetmishr commented on issue #5768: back-incompatible the RequestCode(`REGISTER_TOPIC_IN_NAMESRV`) with `217` value
Posted by "Abhijeetmishr (via GitHub)" <gi...@apache.org>.
Abhijeetmishr commented on issue #5768:
URL: https://github.com/apache/rocketmq/issues/5768#issuecomment-1489095993
@TheNorthMemory
In all the places except rocketmq we are using this
> // Namesrv gets all server ip information through project
> exports.GET_KV_CONFIG_BY_VALUE = 217;
but in rocketmq we are using this
> // for registering topic
> public static final int REGISTER_TOPIC_IN_NAMESRV = 217;
So you are suggesting to create different code for this **REGISTER_TOPIC_IN_NAMESRV**
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Oliverwqcwrw commented on issue #5768: back-incompatible the RequestCode(`REGISTER_TOPIC_IN_NAMESRV`) with `217` value
Posted by "Oliverwqcwrw (via GitHub)" <gi...@apache.org>.
Oliverwqcwrw commented on issue #5768:
URL: https://github.com/apache/rocketmq/issues/5768#issuecomment-1501098494
IMO, we will mainly maintain [rocketmq-clients](https://github.com/apache/rocketmq-clients) in the future. Is it necessary to solve this compatibility problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] TheNorthMemory commented on issue #5768: back-incompatible the RequestCode(`REGISTER_TOPIC_IN_NAMESRV`) with `217` value
Posted by "TheNorthMemory (via GitHub)" <gi...@apache.org>.
TheNorthMemory commented on issue #5768:
URL: https://github.com/apache/rocketmq/issues/5768#issuecomment-1483038939
@Abhijeetmishr
1. The `REGISTER_TOPIC_IN_NAMESRV` was added on 5.0+ version, but there were a lot of historic versions from 3.x to 4.x. In my opinion, toggle the one `REGISTER_TOPIC_IN_NAMESRV` to another code shall be a good choice.
2. see https://github.com/ali-sdk/ali-ons/blob/master/lib/protocol/request_code.js#L108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Abhijeetmishr commented on issue #5768: back-incompatible the RequestCode(`REGISTER_TOPIC_IN_NAMESRV`) with `217` value
Posted by "Abhijeetmishr (via GitHub)" <gi...@apache.org>.
Abhijeetmishr commented on issue #5768:
URL: https://github.com/apache/rocketmq/issues/5768#issuecomment-1479110552
@leizhiyuan @Oliverwqcwrw @Oliverwqcwrw are we planning to implement rocketmq-client-sdk for scala just asking if in case ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] leizhiyuan commented on issue #5768: back-incompatible the RequestCode(`REGISTER_TOPIC_IN_NAMESRV`) with `217` value
Posted by GitBox <gi...@apache.org>.
leizhiyuan commented on issue #5768:
URL: https://github.com/apache/rocketmq/issues/5768#issuecomment-1396166377
I see
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Abhijeetmishr commented on issue #5768: back-incompatible the RequestCode(`REGISTER_TOPIC_IN_NAMESRV`) with `217` value
Posted by "Abhijeetmishr (via GitHub)" <gi...@apache.org>.
Abhijeetmishr commented on issue #5768:
URL: https://github.com/apache/rocketmq/issues/5768#issuecomment-1483006620
@TheNorthMemory @leizhiyuan @Oliverwqcwrw what changes you suggest for this ?
> 1. Do we have to change GET_KV_CONFIG_BY_VALUE = 217 in rocketmq itself ?
> 2. or in the other places where it is used ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Oliverwqcwrw commented on issue #5768: back-incompatible the RequestCode(`REGISTER_TOPIC_IN_NAMESRV`) with `217` value
Posted by "Oliverwqcwrw (via GitHub)" <gi...@apache.org>.
Oliverwqcwrw commented on issue #5768:
URL: https://github.com/apache/rocketmq/issues/5768#issuecomment-1479516761
> @leizhiyuan @Oliverwqcwrw @Oliverwqcwrw are we planning to implement rocketmq-client-sdk for scala just asking if in case ?
cc @aaron-ai
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Abhijeetmishr commented on issue #5768: back-incompatible the RequestCode(`REGISTER_TOPIC_IN_NAMESRV`) with `217` value
Posted by "Abhijeetmishr (via GitHub)" <gi...@apache.org>.
Abhijeetmishr commented on issue #5768:
URL: https://github.com/apache/rocketmq/issues/5768#issuecomment-1501105044
> IMO, we will mainly maintain [rocketmq-clients](https://github.com/apache/rocketmq-clients) in the future. Is it necessary to solve this compatibility problem
@Oliverwqcwrw should i close this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Oliverwqcwrw commented on issue #5768: back-incompatible the RequestCode(`REGISTER_TOPIC_IN_NAMESRV`) with `217` value
Posted by "Oliverwqcwrw (via GitHub)" <gi...@apache.org>.
Oliverwqcwrw commented on issue #5768:
URL: https://github.com/apache/rocketmq/issues/5768#issuecomment-1465352857
> @TheNorthMemory @leizhiyuan @Oliverwqcwrw can I pick this up ?
Sure, I assigned it to you :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Abhijeetmishr commented on issue #5768: back-incompatible the RequestCode(`REGISTER_TOPIC_IN_NAMESRV`) with `217` value
Posted by "Abhijeetmishr (via GitHub)" <gi...@apache.org>.
Abhijeetmishr commented on issue #5768:
URL: https://github.com/apache/rocketmq/issues/5768#issuecomment-1490690853
@TheNorthMemory @Oliverwqcwrw I have raised PR for the above change that is one linear only, I maybe wrong.
Please check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] TheNorthMemory commented on issue #5768: back-incompatible the RequestCode(`REGISTER_TOPIC_IN_NAMESRV`) with `217` value
Posted by "TheNorthMemory (via GitHub)" <gi...@apache.org>.
TheNorthMemory commented on issue #5768:
URL: https://github.com/apache/rocketmq/issues/5768#issuecomment-1489633516
Searching the github with [**GET_KV_CONFIG_BY_VALUE with language Java**](https://github.com/search?l=Java&q=GET_KV_CONFIG_BY_VALUE&type=Code), there were a lots of `public static final int GET_KV_CONFIG_BY_VALUE = 217;` definitions on the rocketmq previous versions. The `GET_KV_CONFIG_BY_VALUE` is not a new `RequestCode`, It was already exists.
I think the code **217** was inappropriated mapping to `REGISTER_TOPIC_IN_NAMESRV` since **5.0.0-beta** and sugguest that creating a new code, eg: something like `1217` for the `REGISTER_TOPIC_IN_NAMESRV`.
@Abhijeetmishr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] back-incompatible the RequestCode(`REGISTER_TOPIC_IN_NAMESRV`) with `217` value [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #5768:
URL: https://github.com/apache/rocketmq/issues/5768#issuecomment-2050744667
This issue was closed because it has been inactive for 3 days since being marked as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] TheNorthMemory commented on issue #5768: back-incompatible the RequestCode(`REGISTER_TOPIC_IN_NAMESRV`) with `217` value
Posted by GitBox <gi...@apache.org>.
TheNorthMemory commented on issue #5768:
URL: https://github.com/apache/rocketmq/issues/5768#issuecomment-1386807539
> It seems only be defined in cpp api
>
> there is no use in cpp now。https://github.com/search?q=repo%3Aapache%2Frocketmq-client-cpp+GET_KV_CONFIG_BY_VALUE&type=code
please take a look at this one [[rocketmq-client-nodejs](https://github.com/apache/rocketmq-client-nodejs)](https://github.com/apache/rocketmq-client-nodejs)
> This official Node.js client is a lightweight wrapper around [rocketmq-client-cpp](https://github.com/apache/rocketmq-client-cpp), a finely tuned CPP client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] leizhiyuan commented on issue #5768: back-incompatible the RequestCode(`REGISTER_TOPIC_IN_NAMESRV`) with `217` value
Posted by GitBox <gi...@apache.org>.
leizhiyuan commented on issue #5768:
URL: https://github.com/apache/rocketmq/issues/5768#issuecomment-1386755073
It seems only be defined in cpp api
there is no use in cpp now。https://github.com/search?q=repo%3Aapache%2Frocketmq-client-cpp+GET_KV_CONFIG_BY_VALUE&type=code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] back-incompatible the RequestCode(`REGISTER_TOPIC_IN_NAMESRV`) with `217` value [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #5768:
URL: https://github.com/apache/rocketmq/issues/5768#issuecomment-2043914120
This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] back-incompatible the RequestCode(`REGISTER_TOPIC_IN_NAMESRV`) with `217` value [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #5768: back-incompatible the RequestCode(`REGISTER_TOPIC_IN_NAMESRV`) with `217` value
URL: https://github.com/apache/rocketmq/issues/5768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org