You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/10/12 14:38:32 UTC

[GitHub] [incubator-tvm] mbrookhart commented on pull request #6661: Fix(topi): missing out_shape argument of some batch_matmul ops.

mbrookhart commented on pull request #6661:
URL: https://github.com/apache/incubator-tvm/pull/6661#issuecomment-707160802


   Thanks for catching this, this looks great!
   
   I guess the BLAS-based versions of this op aren't tested in CI. Would it be possible to add a test so this doesn't regress again in the future?
   
   The CI failure appears to be an intermittent failure, I think we need to change that atol on that test from 0 to 1e-3


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org