You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/01/13 01:47:58 UTC
[GitHub] [shardingsphere] jingshanglu commented on a change in pull request #8997: support add feature in "alter replica_query rule"
jingshanglu commented on a change in pull request #8997:
URL: https://github.com/apache/shardingsphere/pull/8997#discussion_r556210022
##########
File path: shardingsphere-db-protocol/shardingsphere-db-protocol-core/src/main/java/org/apache/shardingsphere/db/protocol/error/CommonErrorCode.java
##########
@@ -37,6 +37,12 @@
RESOURCE_NOT_EXIST(11004, "C11004", "Can not drop resources, resources %s do not exist."),
+ REPLICA_QUERY_RULE_NOT_EXIST(11005, "C11005", "Replica query rule do not exist."),
Review comment:
ok
##########
File path: shardingsphere-db-protocol/shardingsphere-db-protocol-core/src/main/java/org/apache/shardingsphere/db/protocol/error/CommonErrorCode.java
##########
@@ -37,6 +37,12 @@
RESOURCE_NOT_EXIST(11004, "C11004", "Can not drop resources, resources %s do not exist."),
+ REPLICA_QUERY_RULE_NOT_EXIST(11005, "C11005", "Replica query rule do not exist."),
+
+ REPLICA_QUERY_RULE_DATASOURCE_NOT_EXIST(11006, "C11006", "Datasource %s in Replica query rule do not exist."),
Review comment:
ok
##########
File path: shardingsphere-db-protocol/shardingsphere-db-protocol-core/src/main/java/org/apache/shardingsphere/db/protocol/error/CommonErrorCode.java
##########
@@ -37,6 +37,12 @@
RESOURCE_NOT_EXIST(11004, "C11004", "Can not drop resources, resources %s do not exist."),
+ REPLICA_QUERY_RULE_NOT_EXIST(11005, "C11005", "Replica query rule do not exist."),
+
+ REPLICA_QUERY_RULE_DATASOURCE_NOT_EXIST(11006, "C11006", "Datasource %s in Replica query rule do not exist."),
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org