You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Puneet Gupta <pu...@gmail.com> on 2016/03/18 08:17:34 UTC
Review Request 45021: LENS-990: Seeing fecthresult failing with '
Expected state FINISHED, but found ERROR' for failed hive queries
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45021/
-----------------------------------------------------------
Review request for lens.
Bugs: lens-990
https://issues.apache.org/jira/browse/lens-990
Repository: lens
Description
-------
Updated isResultAvailableInDriver() to check for query success first (isDriverPersistent() is true even if query fails).
Diffs
-----
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 79d8bf1e8f9798714d14e5a0336e24a148c4ca27
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java d01e4a41c0cb1f4a604df27092b335e593b11ae4
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 4c95506269058554d5e32cb367deeb8a4b987966
Diff: https://reviews.apache.org/r/45021/diff/
Testing
-------
mvn clean install -Dtest=org.apache.lens.server.query.TestQueryService
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.247s]
[INFO] Lens .............................................. SUCCESS [3.706s]
[INFO] Lens API .......................................... SUCCESS [28.077s]
[INFO] Lens API for server and extensions ................ SUCCESS [16.889s]
[INFO] Lens Cube ......................................... SUCCESS [40.877s]
[INFO] Lens DB storage ................................... SUCCESS [8.629s]
[INFO] Lens Query Library ................................ SUCCESS [11.784s]
[INFO] Lens Hive Driver .................................. SUCCESS [14.949s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [15.763s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [15.070s]
[INFO] Lens Server ....................................... SUCCESS [7:16.786s]
[INFO] Lens client ....................................... SUCCESS [16.436s]
[INFO] Lens CLI .......................................... SUCCESS [14.067s]
[INFO] Lens Examples ..................................... SUCCESS [9.952s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.800s]
[INFO] Lens Distribution ................................. SUCCESS [10.034s]
[INFO] Lens ML Lib ....................................... SUCCESS [18.355s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.143s]
[INFO] Lens Regression ................................... SUCCESS [13.020s]
[INFO] Lens UI ........................................... SUCCESS [27.963s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
Thanks,
Puneet Gupta
Re: Review Request 45021: LENS-990: Seeing fecthresult failing with '
Expected state FINISHED, but found ERROR' for failed hive queries
Posted by Puneet Gupta <pu...@gmail.com>.
> On March 18, 2016, 10:15 a.m., Ajay Yadava wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java, line 340
> > <https://reviews.apache.org/r/45021/diff/1/?file=1305005#file1305005line340>
> >
> > nit: "through" instead of "thru"?
Just reformatted an old comment. Didnt feel the need to correct the abbrviation. Will leave it like that for now :-).
> On March 18, 2016, 10:15 a.m., Ajay Yadava wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, line 541
> > <https://reviews.apache.org/r/45021/diff/1/?file=1305006#file1305006line541>
> >
> > Will it make sense to catch Throwable?
Wanted to take care of just run time exceptions. This flow doesn't sit in critical path.
- Puneet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45021/#review124163
-----------------------------------------------------------
On March 18, 2016, 7:17 a.m., Puneet Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45021/
> -----------------------------------------------------------
>
> (Updated March 18, 2016, 7:17 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: lens-990
> https://issues.apache.org/jira/browse/lens-990
>
>
> Repository: lens
>
>
> Description
> -------
>
> Updated isResultAvailableInDriver() to check for query success first (isDriverPersistent() is true even if query fails).
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 79d8bf1e8f9798714d14e5a0336e24a148c4ca27
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java d01e4a41c0cb1f4a604df27092b335e593b11ae4
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 4c95506269058554d5e32cb367deeb8a4b987966
>
> Diff: https://reviews.apache.org/r/45021/diff/
>
>
> Testing
> -------
>
> mvn clean install -Dtest=org.apache.lens.server.query.TestQueryService
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.247s]
> [INFO] Lens .............................................. SUCCESS [3.706s]
> [INFO] Lens API .......................................... SUCCESS [28.077s]
> [INFO] Lens API for server and extensions ................ SUCCESS [16.889s]
> [INFO] Lens Cube ......................................... SUCCESS [40.877s]
> [INFO] Lens DB storage ................................... SUCCESS [8.629s]
> [INFO] Lens Query Library ................................ SUCCESS [11.784s]
> [INFO] Lens Hive Driver .................................. SUCCESS [14.949s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [15.763s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.070s]
> [INFO] Lens Server ....................................... SUCCESS [7:16.786s]
> [INFO] Lens client ....................................... SUCCESS [16.436s]
> [INFO] Lens CLI .......................................... SUCCESS [14.067s]
> [INFO] Lens Examples ..................................... SUCCESS [9.952s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.800s]
> [INFO] Lens Distribution ................................. SUCCESS [10.034s]
> [INFO] Lens ML Lib ....................................... SUCCESS [18.355s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.143s]
> [INFO] Lens Regression ................................... SUCCESS [13.020s]
> [INFO] Lens UI ........................................... SUCCESS [27.963s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Puneet Gupta
>
>
Re: Review Request 45021: LENS-990: Seeing fecthresult failing with '
Expected state FINISHED, but found ERROR' for failed hive queries
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45021/#review124163
-----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java (line 340)
<https://reviews.apache.org/r/45021/#comment186587>
nit: "through" instead of "thru"?
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 541)
<https://reviews.apache.org/r/45021/#comment186588>
Will it make sense to catch Throwable?
- Ajay Yadava
On March 18, 2016, 7:17 a.m., Puneet Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45021/
> -----------------------------------------------------------
>
> (Updated March 18, 2016, 7:17 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: lens-990
> https://issues.apache.org/jira/browse/lens-990
>
>
> Repository: lens
>
>
> Description
> -------
>
> Updated isResultAvailableInDriver() to check for query success first (isDriverPersistent() is true even if query fails).
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 79d8bf1e8f9798714d14e5a0336e24a148c4ca27
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java d01e4a41c0cb1f4a604df27092b335e593b11ae4
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 4c95506269058554d5e32cb367deeb8a4b987966
>
> Diff: https://reviews.apache.org/r/45021/diff/
>
>
> Testing
> -------
>
> mvn clean install -Dtest=org.apache.lens.server.query.TestQueryService
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.247s]
> [INFO] Lens .............................................. SUCCESS [3.706s]
> [INFO] Lens API .......................................... SUCCESS [28.077s]
> [INFO] Lens API for server and extensions ................ SUCCESS [16.889s]
> [INFO] Lens Cube ......................................... SUCCESS [40.877s]
> [INFO] Lens DB storage ................................... SUCCESS [8.629s]
> [INFO] Lens Query Library ................................ SUCCESS [11.784s]
> [INFO] Lens Hive Driver .................................. SUCCESS [14.949s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [15.763s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.070s]
> [INFO] Lens Server ....................................... SUCCESS [7:16.786s]
> [INFO] Lens client ....................................... SUCCESS [16.436s]
> [INFO] Lens CLI .......................................... SUCCESS [14.067s]
> [INFO] Lens Examples ..................................... SUCCESS [9.952s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.800s]
> [INFO] Lens Distribution ................................. SUCCESS [10.034s]
> [INFO] Lens ML Lib ....................................... SUCCESS [18.355s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.143s]
> [INFO] Lens Regression ................................... SUCCESS [13.020s]
> [INFO] Lens UI ........................................... SUCCESS [27.963s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Puneet Gupta
>
>
Re: Review Request 45021: LENS-990: Seeing fecthresult failing with '
Expected state FINISHED, but found ERROR' for failed hive queries
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45021/#review124150
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On March 18, 2016, 7:17 a.m., Puneet Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45021/
> -----------------------------------------------------------
>
> (Updated March 18, 2016, 7:17 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: lens-990
> https://issues.apache.org/jira/browse/lens-990
>
>
> Repository: lens
>
>
> Description
> -------
>
> Updated isResultAvailableInDriver() to check for query success first (isDriverPersistent() is true even if query fails).
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 79d8bf1e8f9798714d14e5a0336e24a148c4ca27
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java d01e4a41c0cb1f4a604df27092b335e593b11ae4
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 4c95506269058554d5e32cb367deeb8a4b987966
>
> Diff: https://reviews.apache.org/r/45021/diff/
>
>
> Testing
> -------
>
> mvn clean install -Dtest=org.apache.lens.server.query.TestQueryService
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.247s]
> [INFO] Lens .............................................. SUCCESS [3.706s]
> [INFO] Lens API .......................................... SUCCESS [28.077s]
> [INFO] Lens API for server and extensions ................ SUCCESS [16.889s]
> [INFO] Lens Cube ......................................... SUCCESS [40.877s]
> [INFO] Lens DB storage ................................... SUCCESS [8.629s]
> [INFO] Lens Query Library ................................ SUCCESS [11.784s]
> [INFO] Lens Hive Driver .................................. SUCCESS [14.949s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [15.763s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.070s]
> [INFO] Lens Server ....................................... SUCCESS [7:16.786s]
> [INFO] Lens client ....................................... SUCCESS [16.436s]
> [INFO] Lens CLI .......................................... SUCCESS [14.067s]
> [INFO] Lens Examples ..................................... SUCCESS [9.952s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.800s]
> [INFO] Lens Distribution ................................. SUCCESS [10.034s]
> [INFO] Lens ML Lib ....................................... SUCCESS [18.355s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.143s]
> [INFO] Lens Regression ................................... SUCCESS [13.020s]
> [INFO] Lens UI ........................................... SUCCESS [27.963s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Puneet Gupta
>
>