[GitHub] [iceberg] nssalian commented on pull request #3275: Support for Namespace properties in JDBC Catalog

[GitBox <gi...@apache.org>]

nssalian commented on pull request #3275:
URL: https://github.com/apache/iceberg/pull/3275#issuecomment-1009397878


   > I would personally say if there's no practical difference between the two, it would be ok to make them into one function.
   Possibly there could be one outer function, that contains all of the shared logic (like the interrupted exception and SQLException checks). And then two different functions that wrap that function with a code block for the building of the correct prepared statement. This might make the changes a bit easier to digest and be cleaner, but it's fine as it is otherwise.
   
   It seemed like the way to go from other catalogs. So I separated them out to separate methods.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org