[GitHub] [dubbo-go-pixiu] ztelur commented on a diff in pull request #425: Feat: SpringCloud subscribe strategy and Adapter add enabled config

[GitBox <gi...@apache.org>]

ztelur commented on code in PR #425:
URL: https://github.com/apache/dubbo-go-pixiu/pull/425#discussion_r878693708


##########
pkg/adapter/springcloud/cloud.go:
##########
@@ -347,8 +364,15 @@ func (a *CloudAdapter) stop() error {
 	err := a.sd.Unsubscribe()
 	if err != nil {
 		logger.Errorf("unsubscribe registry fail ", err.Error())
-		//return err
 	}
 	close(a.stopChan)
 	return nil
 }
+
+func (a *CloudAdapter) subscribeServiceDefinitely() bool {
+	return strings.EqualFold(a.cfg.SubscribePolicy, Definitely.String())
+}
+
+func (a *CloudAdapter) subscribeServiceAdapting() bool {

Review Comment:
   pl fix review dog comment issues



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org