You are viewing a plain text version of this content. The canonical link for it is here.
Posted to graffito-dev@incubator.apache.org by Randy Watler <wa...@wispertel.net> on 2005/11/20 07:55:08 UTC

[PATCH] graffito-J2-2.0-dev svn HEAD deployment patches

All,

Attached are my revised patches for graffito/J2 deployment against the
current J2 svn HEAD. Here are a few notes:

- as J2 commits move forward, watch the J2 src/webapp/WEB-INF/assembly
directory... the graffito J2 deployment builds are very sensitive to
changes there.
- jetspeed2-deploy/src/assembly/jetspeed-spring.xml has been removed.
-
applications/browser/src/java/org/apache/portals/graffito/portlets/browser/actions/DocumentAction.java has been patched to fix NPEs that occured on document insertion/save; I am not sure if that is a new problem in either J2 or graffito.

These patches have been tested against these versions:

graffito:  345725
J2:        345720

HTH, YMMV :-),

Randy

Re: [PATCH] graffito-J2-2.0-dev svn HEAD deployment patches

Posted by Christophe Lombart <ch...@gmail.com>.
Randy,

For me, that works. Your patches are apply and I fixed some issue in
the security area.
Ate solved the file upload issues. Anyway, the graffito portlet
application requitre more robust features.

What about your plan to make the J2 Page manager with a graffito
implementation ? Do you see other J2/Graffito integration ?

Christophe

On 11/30/05, Randy Watler <wa...@wispertel.net> wrote:
> Gang,
>
> Are these patches working in general? I had many of the same issues some
> of you have noted on this thread, but the fixes were supposed to be in
> the patches. Oh well... I think my linux patches don't always take
> cleanly on DOS files :-).
>
> Any more help needed here? I am available now that I am back from break.
>
> Randy
>
> On Wed, 2005-11-23 at 00:26 +0100, Christophe Lombart wrote:
> > On 11/23/05, Greg Reddin <gr...@apache.org> wrote:
> >
> > > Nope, that works.  Thanks.  I assume that's based on this document?
> > > (http://portals.apache.org/jetspeed-2/multiproject/jetspeed-security/
> > > hierarchy.html)
> > >
> >
> > Yes :-). As you can see, the documentation in Graffito is not very good.
> >
>
>

Re: [PATCH] graffito-J2-2.0-dev svn HEAD deployment patches

Posted by Greg Reddin <gr...@apache.org>.
On Nov 30, 2005, at 9:19 AM, Christophe Lombart wrote:

>> As of Monday everything is now working for me.  I still had to copy
>> the jetspeed-spring.xml file back over from the Jetspeed build after
>> doing the Graffito allDeploy, but that's the only manual step I had
>> to do.  Should I not be doing that?  It works :-)
>>
>
> This deploy issue is fixed. Can you try again ?

Not sure if I can today or not, but I will as soon as I can.

Thanks,
Greg

Re: [PATCH] graffito-J2-2.0-dev svn HEAD deployment patches

Posted by Christophe Lombart <ch...@gmail.com>.
On 11/30/05, Greg Reddin <gr...@apache.org> wrote:

>
> As of Monday everything is now working for me.  I still had to copy
> the jetspeed-spring.xml file back over from the Jetspeed build after
> doing the Graffito allDeploy, but that's the only manual step I had
> to do.  Should I not be doing that?  It works :-)

This deploy issue is fixed. Can you try again ?

Thanks
Christophe

Re: [PATCH] graffito-J2-2.0-dev svn HEAD deployment patches

Posted by Greg Reddin <gr...@apache.org>.
On Nov 29, 2005, at 11:14 PM, Randy Watler wrote:

> Gang,
>
> Are these patches working in general? I had many of the same issues  
> some
> of you have noted on this thread, but the fixes were supposed to be in
> the patches. Oh well... I think my linux patches don't always take
> cleanly on DOS files :-).

I did notice EOL issues when doing a svn diff.  But I think that  
would be fixed by setting the svn:eol-style property wouldn't it?

As of Monday everything is now working for me.  I still had to copy  
the jetspeed-spring.xml file back over from the Jetspeed build after  
doing the Graffito allDeploy, but that's the only manual step I had  
to do.  Should I not be doing that?  It works :-)

Greg

Re: [PATCH] graffito-J2-2.0-dev svn HEAD deployment patches

Posted by Randy Watler <wa...@wispertel.net>.
Gang,

Are these patches working in general? I had many of the same issues some
of you have noted on this thread, but the fixes were supposed to be in
the patches. Oh well... I think my linux patches don't always take
cleanly on DOS files :-).

Any more help needed here? I am available now that I am back from break.

Randy

On Wed, 2005-11-23 at 00:26 +0100, Christophe Lombart wrote:
> On 11/23/05, Greg Reddin <gr...@apache.org> wrote:
> 
> > Nope, that works.  Thanks.  I assume that's based on this document?
> > (http://portals.apache.org/jetspeed-2/multiproject/jetspeed-security/
> > hierarchy.html)
> >
> 
> Yes :-). As you can see, the documentation in Graffito is not very good.
>

Re: [PATCH] graffito-J2-2.0-dev svn HEAD deployment patches

Posted by Christophe Lombart <ch...@gmail.com>.
On 11/23/05, Greg Reddin <gr...@apache.org> wrote:

> Nope, that works.  Thanks.  I assume that's based on this document?
> (http://portals.apache.org/jetspeed-2/multiproject/jetspeed-security/
> hierarchy.html)
>

Yes :-). As you can see, the documentation in Graffito is not very good.

Re: [PATCH] graffito-J2-2.0-dev svn HEAD deployment patches

Posted by Greg Reddin <gr...@apache.org>.
On Nov 22, 2005, at 5:09 PM, Christophe Lombart wrote:

> Did you try some values like :
> /user/admin
> /role/manager
> /group/marketing
>
> But maybe it is a bug.

Nope, that works.  Thanks.  I assume that's based on this document?  
(http://portals.apache.org/jetspeed-2/multiproject/jetspeed-security/ 
hierarchy.html)

> I almost finish the issues on the unit tests (security) and
> deployement.  Than,  I can review this portlet in more details. I
> would like to add list box in this tab or a nice way to pick a user,
> group or a role.

That would be very cool.

Greg

Re: [PATCH] graffito-J2-2.0-dev svn HEAD deployment patches

Posted by Christophe Lombart <ch...@gmail.com>.
Did you try some values like :
/user/admin
/role/manager
/group/marketing

But maybe it is a bug.

I almost finish the issues on the unit tests (security) and
deployement.  Than,  I can review this portlet in more details. I
would like to add list box in this tab or a nice way to pick a user,
group or a role.

Christophe
On 11/22/05, Greg Reddin <gr...@apache.org> wrote:
>
> On Nov 22, 2005, at 12:53 AM, Christophe Lombart wrote:
>
> > On 11/22/05, Greg Reddin <gr...@apache.org> wrote:
> >
> >
> >> Now I will start to figure out the permissions stuff.
> >>
> >>
> > Thanks I'm also reviewing it. I checked with J2 M3 and that works.
> > I'm wondering what's the difference between M3 and M4 in point of view
> > permission management.
>
> I'm sure this is a newbie question, but what is supposed to go into
> the "User-Group-Role" field when adding a permission in the Graffito
> Browser portlet?  I tried entering the name of some roles I created
> but it doesn't seem to be working.  It adds the permission, but the
> User-Group-Role column is blank and it won't add any more.  Is this a
> bug or am I doing something wrong?
>
> Thanks,
> Greg
>
>

Re: [PATCH] graffito-J2-2.0-dev svn HEAD deployment patches

Posted by Greg Reddin <gr...@apache.org>.
On Nov 22, 2005, at 12:53 AM, Christophe Lombart wrote:

> On 11/22/05, Greg Reddin <gr...@apache.org> wrote:
>
>
>> Now I will start to figure out the permissions stuff.
>>
>>
> Thanks I'm also reviewing it. I checked with J2 M3 and that works.
> I'm wondering what's the difference between M3 and M4 in point of view
> permission management.

I'm sure this is a newbie question, but what is supposed to go into  
the "User-Group-Role" field when adding a permission in the Graffito  
Browser portlet?  I tried entering the name of some roles I created  
but it doesn't seem to be working.  It adds the permission, but the  
User-Group-Role column is blank and it won't add any more.  Is this a  
bug or am I doing something wrong?

Thanks,
Greg

Re: [PATCH] graffito-J2-2.0-dev svn HEAD deployment patches

Posted by Christophe Lombart <ch...@gmail.com>.
On 11/22/05, Greg Reddin <gr...@apache.org> wrote:

> Now I will start to figure out the permissions stuff.
>
Thanks I'm also reviewing it. I checked with J2 M3 and that works.
I'm wondering what's the difference between M3 and M4 in point of view
permission management.

Christophe

Re: [PATCH] graffito-J2-2.0-dev svn HEAD deployment patches

Posted by Greg Reddin <gr...@apache.org>.
On Nov 20, 2005, at 4:52 PM, Christophe Lombart wrote:

Thanks for the help.  I've been able to get it working.  Here's some  
newbie notes if anyone needs them.

> * The subproject "engine" doesn't compile because the constructor for
> SpringComponentManager in J2 head has been changed. This is not use
> with J2. It can be use only when Graffito is running outside J2.

I just changed the method to return null.  Seems like this could have  
some negative ramifications, but it's working so far.

> * The maven goal "allDeploy" deploy in the wrong folder. Maybe it is a
> invalid config on my machine.

I got the same thing.  I just move the 2 war files from $TOMCAT_HOME/ 
webapps/WEB-INF/deploy to $TOMCAT_HOME/webapps/jetspeed/WEB-INF/deploy

> * I think we have to change the jetspeed version reference (in
> etc/artifact-versions.ent). I set "2.0-dev" instead of "2.0-M3".

Did that.

Also removed the jetspeed-persistence dependency as someone noted,  
but it was in engine/project.xml not jetspeed-deploy/project.xml

>> - jetspeed2-deploy/src/assembly/jetspeed-spring.xml has been removed.

I had to copy back in the jetspeed-spring.xml from my jetspeed/trunk/ 
target/jetspeed/WEB-INF/assembly directory.

Now I will start to figure out the permissions stuff.

Thanks,
Greg

Re: [PATCH] graffito-J2-2.0-dev svn HEAD deployment patches

Posted by Edgar Poce <ed...@gmail.com>.
On 11/21/05, Greg Reddin <gr...@apache.org> wrote:
>
> On Nov 20, 2005, at 4:52 PM, Christophe Lombart wrote:
>
> > Nevertheless, it works if i skip the unit tests
>
> I'm sorry, how do you skip the unit tests during a build?  I know
> I've seen that before but I can't find it now.
>

with maven.test.skip=true. see
http://maven.apache.org/reference/plugins/test/properties.html

br,
edgar

> Thanks,
> Greg
>
>
>

Re: [PATCH] graffito-J2-2.0-dev svn HEAD deployment patches

Posted by Greg Reddin <gr...@apache.org>.
On Nov 20, 2005, at 4:52 PM, Christophe Lombart wrote:

> Nevertheless, it works if i skip the unit tests

I'm sorry, how do you skip the unit tests during a build?  I know  
I've seen that before but I can't find it now.

Thanks,
Greg

Re: [PATCH] graffito-J2-2.0-dev svn HEAD deployment patches

Posted by David Le Strat <dl...@yahoo.com>.
Regarding the Jetspeed version to use, we have moved
back to 2.0-dev before our final release.

Regards,

David Le Strat

--- Christophe Lombart <ch...@gmail.com>
wrote:

> Thank you very much Randy - That's great !
> It runs with the J2 Head source and with mysql.
> 
> A couple of comments before commit your changes :
> * Some unit tests failed in the subproject
> "components" :
> AllFileTestRbmsPolicy and TestRdbmsPolivy. I will
> try to fix thoses
> unit tests tomorrow.
> * The subproject "engine" doesn't compile because
> the constructor for
> SpringComponentManager in J2 head has been changed.
> This is not use
> with J2. It can be use only when Graffito is running
> outside J2.
> * The maven goal "allDeploy" deploy in the wrong
> folder. Maybe it is a
> invalid config on my machine.
> * I think we have to change the jetspeed version
> reference (in
> etc/artifact-versions.ent). I set "2.0-dev" instead
> of "2.0-M3". Can
> you confirm which J2 version to use (2.0-dev or
> 2.0-M4) ?
> 
> Nevertheless, it works if i skip the unit tests and
> deploy manually
> :-) I'm wondering if you got those issues. Tommorow
> I will try to fix
> them and commit your changes.
> 
> From now, I will made a new J2 build every week in
> order to have a
> stable integration for the Apache Conference.
> 
> Thanks,
> Christophe
> 
> On 11/20/05, Randy Watler <wa...@wispertel.net>
> wrote:
> > All,
> >
> > Attached are my revised patches for graffito/J2
> deployment against the
> > current J2 svn HEAD. Here are a few notes:
> >
> > - as J2 commits move forward, watch the J2
> src/webapp/WEB-INF/assembly
> > directory... the graffito J2 deployment builds are
> very sensitive to
> > changes there.
> > -
> jetspeed2-deploy/src/assembly/jetspeed-spring.xml
> has been removed.
> > -
> >
>
applications/browser/src/java/org/apache/portals/graffito/portlets/browser/actions/DocumentAction.java
> has been patched to fix NPEs that occured on
> document insertion/save; I am not sure if that is a
> new problem in either J2 or graffito.
> >
> > These patches have been tested against these
> versions:
> >
> > graffito:  345725
> > J2:        345720
> >
> > HTH, YMMV :-),
> >
> > Randy
> >
> >
> >
> >
> 


________________________
David Le Strat
Blogging @ http://dlsthoughts.blogspot.com


		
__________________________________ 
Yahoo! FareChase: Search multiple travel sites in one click.
http://farechase.yahoo.com

Re: [PATCH] graffito-J2-2.0-dev svn HEAD deployment patches

Posted by David Le Strat <dl...@yahoo.com>.
Christophe,

I am getting the same issue with the
SpringComponentManager.  Also, you need to remove
jetspeed-persistence from
jetspeed2-deploy/project.xml.

Regards,

David Le Strat 

--- Christophe Lombart <ch...@gmail.com>
wrote:

> Thank you very much Randy - That's great !
> It runs with the J2 Head source and with mysql.
> 
> A couple of comments before commit your changes :
> * Some unit tests failed in the subproject
> "components" :
> AllFileTestRbmsPolicy and TestRdbmsPolivy. I will
> try to fix thoses
> unit tests tomorrow.
> * The subproject "engine" doesn't compile because
> the constructor for
> SpringComponentManager in J2 head has been changed.
> This is not use
> with J2. It can be use only when Graffito is running
> outside J2.
> * The maven goal "allDeploy" deploy in the wrong
> folder. Maybe it is a
> invalid config on my machine.
> * I think we have to change the jetspeed version
> reference (in
> etc/artifact-versions.ent). I set "2.0-dev" instead
> of "2.0-M3". Can
> you confirm which J2 version to use (2.0-dev or
> 2.0-M4) ?
> 
> Nevertheless, it works if i skip the unit tests and
> deploy manually
> :-) I'm wondering if you got those issues. Tommorow
> I will try to fix
> them and commit your changes.
> 
> From now, I will made a new J2 build every week in
> order to have a
> stable integration for the Apache Conference.
> 
> Thanks,
> Christophe
> 
> On 11/20/05, Randy Watler <wa...@wispertel.net>
> wrote:
> > All,
> >
> > Attached are my revised patches for graffito/J2
> deployment against the
> > current J2 svn HEAD. Here are a few notes:
> >
> > - as J2 commits move forward, watch the J2
> src/webapp/WEB-INF/assembly
> > directory... the graffito J2 deployment builds are
> very sensitive to
> > changes there.
> > -
> jetspeed2-deploy/src/assembly/jetspeed-spring.xml
> has been removed.
> > -
> >
>
applications/browser/src/java/org/apache/portals/graffito/portlets/browser/actions/DocumentAction.java
> has been patched to fix NPEs that occured on
> document insertion/save; I am not sure if that is a
> new problem in either J2 or graffito.
> >
> > These patches have been tested against these
> versions:
> >
> > graffito:  345725
> > J2:        345720
> >
> > HTH, YMMV :-),
> >
> > Randy
> >
> >
> >
> >
> 


________________________
David Le Strat
Blogging @ http://dlsthoughts.blogspot.com

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com

Re: [PATCH] graffito-J2-2.0-dev svn HEAD deployment patches

Posted by Christophe Lombart <ch...@gmail.com>.
Thank you very much Randy - That's great !
It runs with the J2 Head source and with mysql.

A couple of comments before commit your changes :
* Some unit tests failed in the subproject "components" :
AllFileTestRbmsPolicy and TestRdbmsPolivy. I will try to fix thoses
unit tests tomorrow.
* The subproject "engine" doesn't compile because the constructor for
SpringComponentManager in J2 head has been changed. This is not use
with J2. It can be use only when Graffito is running outside J2.
* The maven goal "allDeploy" deploy in the wrong folder. Maybe it is a
invalid config on my machine.
* I think we have to change the jetspeed version reference (in
etc/artifact-versions.ent). I set "2.0-dev" instead of "2.0-M3". Can
you confirm which J2 version to use (2.0-dev or 2.0-M4) ?

Nevertheless, it works if i skip the unit tests and deploy manually
:-) I'm wondering if you got those issues. Tommorow I will try to fix
them and commit your changes.

From now, I will made a new J2 build every week in order to have a
stable integration for the Apache Conference.

Thanks,
Christophe

On 11/20/05, Randy Watler <wa...@wispertel.net> wrote:
> All,
>
> Attached are my revised patches for graffito/J2 deployment against the
> current J2 svn HEAD. Here are a few notes:
>
> - as J2 commits move forward, watch the J2 src/webapp/WEB-INF/assembly
> directory... the graffito J2 deployment builds are very sensitive to
> changes there.
> - jetspeed2-deploy/src/assembly/jetspeed-spring.xml has been removed.
> -
> applications/browser/src/java/org/apache/portals/graffito/portlets/browser/actions/DocumentAction.java has been patched to fix NPEs that occured on document insertion/save; I am not sure if that is a new problem in either J2 or graffito.
>
> These patches have been tested against these versions:
>
> graffito:  345725
> J2:        345720
>
> HTH, YMMV :-),
>
> Randy
>
>
>
>