You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/03/07 04:12:04 UTC
Review Request: Changed default cgroup path to "/cgroup".
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9791/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
/cgroup is a more standard naming convention.
Diffs
-----
src/slave/flags.hpp 9cd436cae5772b906b3566eb1f344904d5894214
Diff: https://reviews.apache.org/r/9791/diff/
Testing
-------
Thanks,
Ben Mahler
Re: Review Request: Changed default cgroup path to "/cgroup".
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9791/#review17509
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 7, 2013, 3:12 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9791/
> -----------------------------------------------------------
>
> (Updated March 7, 2013, 3:12 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> /cgroup is a more standard naming convention.
>
>
> Diffs
> -----
>
> src/slave/flags.hpp 9cd436cae5772b906b3566eb1f344904d5894214
>
> Diff: https://reviews.apache.org/r/9791/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Changed default cgroup path to "/cgroup".
Posted by Ben Mahler <be...@gmail.com>.
> On March 7, 2013, 8:24 a.m., Benjamin Hindman wrote:
> > src/slave/flags.hpp, line 112
> > <https://reviews.apache.org/r/9791/diff/1/?file=267805#file267805line112>
> >
> > I've always wanted to s/cgroups_hierarchy_root/cgroups_hierarchy/ too.
Agreed, but I'm hesitant to change flag names until we fix: https://issues.apache.org/jira/browse/MESOS-140
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9791/#review17524
-----------------------------------------------------------
On March 7, 2013, 3:12 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9791/
> -----------------------------------------------------------
>
> (Updated March 7, 2013, 3:12 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> /cgroup is a more standard naming convention.
>
>
> Diffs
> -----
>
> src/slave/flags.hpp 9cd436cae5772b906b3566eb1f344904d5894214
>
> Diff: https://reviews.apache.org/r/9791/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Changed default cgroup path to "/cgroup".
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9791/#review17524
-----------------------------------------------------------
Ship it!
src/slave/flags.hpp
<https://reviews.apache.org/r/9791/#comment37197>
I've always wanted to s/cgroups_hierarchy_root/cgroups_hierarchy/ too.
- Benjamin Hindman
On March 7, 2013, 3:12 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9791/
> -----------------------------------------------------------
>
> (Updated March 7, 2013, 3:12 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> /cgroup is a more standard naming convention.
>
>
> Diffs
> -----
>
> src/slave/flags.hpp 9cd436cae5772b906b3566eb1f344904d5894214
>
> Diff: https://reviews.apache.org/r/9791/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ben Mahler
>
>