You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/05/21 20:01:41 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #7570:
[testconn] Explicit closing engine connection
codecov-io edited a comment on issue #7570: [testconn] Explicit closing engine connection
URL: https://github.com/apache/incubator-superset/pull/7570#issuecomment-494536653
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7570?src=pr&el=h1) Report
> Merging [#7570](https://codecov.io/gh/apache/incubator-superset/pull/7570?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/1ae000a26220c024f3f904d9049cfcd4b1e461e7?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/7570?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7570 +/- ##
==========================================
+ Coverage 65.17% 65.17% +<.01%
==========================================
Files 433 433
Lines 21428 21429 +1
Branches 2360 2360
==========================================
+ Hits 13966 13967 +1
Misses 7342 7342
Partials 120 120
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7570?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.94% <100%> (+0.01%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7570?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7570?src=pr&el=footer). Last update [1ae000a...84aded3](https://codecov.io/gh/apache/incubator-superset/pull/7570?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org