[GitHub] [kafka] showuon commented on pull request #12167: KAFKA-13716 Added the DeleteRecordsCommandTest to test the CLI front end of the D…

[GitBox <gi...@apache.org>]

showuon commented on PR #12167:
URL: https://github.com/apache/kafka/pull/12167#issuecomment-1131061627

   > 1. When you say add some test for wrong & good configs, do you mean to remove the particular unit tests and then add it to the TopicCommandTest.scala instead? Or are you suggesting that there should be a couple more tests added to cover the usage a bit more completely?
   
   I mean add more tests to cover the usage in `DeleteRecordsCommandTest.scala` (and you can refer to TopicCommandTest
   
   > 2. In terms of integration testing, that was what I understood this Jira to be originally but upon getting clarification in the Jira I was under the impression that this was only related to the CLI portion of the command and not the functionality. [Link to the comment](https://issues.apache.org/jira/browse/KAFKA-13716?focusedCommentId=17528047&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17528047). So I don't think there is a need for integration testing but I'm happy to be wrong here.
   
   It's fine we only add unit tests (cli command tests) in this PR. But it'd better if we can add integration tests for it, too. I'm OK if you want to keep this PR scope as unit test only. 
   
   Thanks for the contribution!
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org