You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/29 02:50:39 UTC
[GitHub] [flink] TsReaper opened a new pull request #13831: [FLINK-19624][fix] Fix special case when the reuse of exchange causes the deadlock
TsReaper opened a new pull request #13831:
URL: https://github.com/apache/flink/pull/13831
## What is the purpose of the change
This PR fixes the special case when the reuse of exchange causes the deadlock.
Currently the reuse of exchange is not considered to be a deadlock because although the exec node of an exchange is reused, its underlying transformation is not reused. However if this behavior changes a deadlock may occur.
## Brief change log
- Fix special case when the reuse of exchange causes the deadlock
## Verifying this change
This change is already covered by existing tests, also this change added tests and can be verified by running the added cases.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] TsReaper commented on pull request #13831: [FLINK-19870][table-planner-blink] Fix special case when the reuse of exchange causes the deadlock
Posted by GitBox <gi...@apache.org>.
TsReaper commented on pull request #13831:
URL: https://github.com/apache/flink/pull/13831#issuecomment-719127709
Azure passed in https://dev.azure.com/tsreaper96/Flink/_build/results?buildId=106&view=results
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13831: [FLINK-19624][fix] Fix special case when the reuse of exchange causes the deadlock
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13831:
URL: https://github.com/apache/flink/pull/13831#issuecomment-718326098
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit f7a377f9a04c5d630cb578ebc9040e936e6a60a4 (Thu Oct 29 02:52:32 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13831: [FLINK-19870][table-planner-blink] Fix special case when the reuse of exchange causes the deadlock
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13831:
URL: https://github.com/apache/flink/pull/13831#issuecomment-718332223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f7a377f9a04c5d630cb578ebc9040e936e6a60a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8553",
"triggerID" : "f7a377f9a04c5d630cb578ebc9040e936e6a60a4",
"triggerType" : "PUSH"
}, {
"hash" : "181dc3d76c4be37dd42910ddc8640b3bd76beb93",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8565",
"triggerID" : "181dc3d76c4be37dd42910ddc8640b3bd76beb93",
"triggerType" : "PUSH"
}, {
"hash" : "e3f9f1ed19dfa8f795680f3537ca51e92bcf8a1b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8574",
"triggerID" : "e3f9f1ed19dfa8f795680f3537ca51e92bcf8a1b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e3f9f1ed19dfa8f795680f3537ca51e92bcf8a1b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8574)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13831: [FLINK-19870][table-planner-blink] Fix special case when the reuse of exchange causes the deadlock
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13831:
URL: https://github.com/apache/flink/pull/13831#issuecomment-718332223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f7a377f9a04c5d630cb578ebc9040e936e6a60a4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8553",
"triggerID" : "f7a377f9a04c5d630cb578ebc9040e936e6a60a4",
"triggerType" : "PUSH"
}, {
"hash" : "181dc3d76c4be37dd42910ddc8640b3bd76beb93",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "181dc3d76c4be37dd42910ddc8640b3bd76beb93",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f7a377f9a04c5d630cb578ebc9040e936e6a60a4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8553)
* 181dc3d76c4be37dd42910ddc8640b3bd76beb93 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13831: [FLINK-19624][fix] Fix special case when the reuse of exchange causes the deadlock
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13831:
URL: https://github.com/apache/flink/pull/13831#issuecomment-718332223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f7a377f9a04c5d630cb578ebc9040e936e6a60a4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f7a377f9a04c5d630cb578ebc9040e936e6a60a4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f7a377f9a04c5d630cb578ebc9040e936e6a60a4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13831: [FLINK-19870][table-planner-blink] Fix special case when the reuse of exchange causes the deadlock
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13831:
URL: https://github.com/apache/flink/pull/13831#issuecomment-718332223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f7a377f9a04c5d630cb578ebc9040e936e6a60a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8553",
"triggerID" : "f7a377f9a04c5d630cb578ebc9040e936e6a60a4",
"triggerType" : "PUSH"
}, {
"hash" : "181dc3d76c4be37dd42910ddc8640b3bd76beb93",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8565",
"triggerID" : "181dc3d76c4be37dd42910ddc8640b3bd76beb93",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 181dc3d76c4be37dd42910ddc8640b3bd76beb93 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8565)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13831: [FLINK-19870][table-planner-blink] Fix special case when the reuse of exchange causes the deadlock
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13831:
URL: https://github.com/apache/flink/pull/13831#issuecomment-718332223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f7a377f9a04c5d630cb578ebc9040e936e6a60a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8553",
"triggerID" : "f7a377f9a04c5d630cb578ebc9040e936e6a60a4",
"triggerType" : "PUSH"
}, {
"hash" : "181dc3d76c4be37dd42910ddc8640b3bd76beb93",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8565",
"triggerID" : "181dc3d76c4be37dd42910ddc8640b3bd76beb93",
"triggerType" : "PUSH"
}, {
"hash" : "e3f9f1ed19dfa8f795680f3537ca51e92bcf8a1b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8574",
"triggerID" : "e3f9f1ed19dfa8f795680f3537ca51e92bcf8a1b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 181dc3d76c4be37dd42910ddc8640b3bd76beb93 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8565)
* e3f9f1ed19dfa8f795680f3537ca51e92bcf8a1b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8574)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13831: [FLINK-19624][fix] Fix special case when the reuse of exchange causes the deadlock
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13831:
URL: https://github.com/apache/flink/pull/13831#issuecomment-718332223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f7a377f9a04c5d630cb578ebc9040e936e6a60a4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8553",
"triggerID" : "f7a377f9a04c5d630cb578ebc9040e936e6a60a4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f7a377f9a04c5d630cb578ebc9040e936e6a60a4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8553)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe merged pull request #13831: [FLINK-19870][table-planner-blink] Fix special case when the reuse of exchange causes the deadlock
Posted by GitBox <gi...@apache.org>.
godfreyhe merged pull request #13831:
URL: https://github.com/apache/flink/pull/13831
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13831: [FLINK-19870][table-planner-blink] Fix special case when the reuse of exchange causes the deadlock
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13831:
URL: https://github.com/apache/flink/pull/13831#issuecomment-718332223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f7a377f9a04c5d630cb578ebc9040e936e6a60a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8553",
"triggerID" : "f7a377f9a04c5d630cb578ebc9040e936e6a60a4",
"triggerType" : "PUSH"
}, {
"hash" : "181dc3d76c4be37dd42910ddc8640b3bd76beb93",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8565",
"triggerID" : "181dc3d76c4be37dd42910ddc8640b3bd76beb93",
"triggerType" : "PUSH"
}, {
"hash" : "e3f9f1ed19dfa8f795680f3537ca51e92bcf8a1b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e3f9f1ed19dfa8f795680f3537ca51e92bcf8a1b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 181dc3d76c4be37dd42910ddc8640b3bd76beb93 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8565)
* e3f9f1ed19dfa8f795680f3537ca51e92bcf8a1b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org