You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/02 19:56:30 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #4092: minor: Use Operator::swap
alamb opened a new pull request, #4092:
URL: https://github.com/apache/arrow-datafusion/pull/4092
# Which issue does this PR close?
N/A
# Rationale for this change
While reviewing https://github.com/apache/arrow-datafusion/pull/3912 from @isidentical I noticed there was some duplication of "reverse the operator" logic in DataFusion
Less duplication I think leads to easier to understand code
# What changes are included in this PR?
Use `Operator::swap()` in pruning predicate rather than another copy
# Are there any user-facing changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] isidentical commented on pull request #4092: minor: Use Operator::swap
Posted by GitBox <gi...@apache.org>.
isidentical commented on PR #4092:
URL: https://github.com/apache/arrow-datafusion/pull/4092#issuecomment-1301163768
I didn't notice something similar was already in the codebase when adding the `swap()`, thanks for catching it! Looks great ☑️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4092: minor: Use Operator::swap
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4092:
URL: https://github.com/apache/arrow-datafusion/pull/4092#issuecomment-1301747275
Benchmark runs are scheduled for baseline = 52930cd07b5c1fcb193e3c81ce56586496d2712c and contender = 8741372bd250338f90335ec49641adf733dbc243. 8741372bd250338f90335ec49641adf733dbc243 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c7a72157d1c84a79b9f44334d31a4bb5...67d8a62a98164dae9e0a4ec02bb99bf2/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/cbe0bf7ea9cb44e79e4230620de08506...38894409c5f6487a880208a7337ee06a/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/87c684d3803c4f0da34071feeb5f274e...eae44661433244b48ba2ada552729c49/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/bad3ec7c3a364a34b13410b782474b83...08a06dd1b19b434aa03febc7ded8640b/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] xudong963 merged pull request #4092: minor: Use Operator::swap
Posted by GitBox <gi...@apache.org>.
xudong963 merged PR #4092:
URL: https://github.com/apache/arrow-datafusion/pull/4092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org