You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2022/12/06 07:15:49 UTC

Review Request 74236: RANGER-3997: option to use default value when user/group/tag does not have the attribute

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74236/
-----------------------------------------------------------

Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Siddhesh Phatak, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.


Bugs: RANGER-3997
    https://issues.apache.org/jira/browse/RANGER-3997


Repository: ranger


Description
-------

- added several macros that support following:
  -- option to use default values when no value is found
  -- option to use custom separators for CSV values, like: 'group1'|'group2'
  -- option to use custom quote characters, like: {group1},{group2}
- examples:
  -- GET_USER_ATTR('dept', -1)
  -- GET_UG_NAMES('none', '|')
  -- GET_UG_NAMES('none', ',', '{', '}')


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerRequestScriptEvaluator.java 71802662f 
  agents-common/src/main/java/org/apache/ranger/plugin/util/RangerCommonConstants.java 73e3dadbf 
  agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerRequestScriptEvaluatorTest.java c398e0205 


Diff: https://reviews.apache.org/r/74236/diff/1/


Testing
-------

- added unit tests to cover new macros
- verified that all existing test cases pass successfully


Thanks,

Madhan Neethiraj


Re: Review Request 74236: RANGER-3997: option to use default value when user/group/tag does not have the attribute

Posted by Ankita Sinha <an...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74236/#review224971
-----------------------------------------------------------


Ship it!




Ship It!

- Ankita Sinha


On Dec. 6, 2022, 7:15 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74236/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2022, 7:15 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Siddhesh Phatak, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3997
>     https://issues.apache.org/jira/browse/RANGER-3997
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> - added several macros that support following:
>   -- option to use default values when no value is found
>   -- option to use custom separators for CSV values, like: 'group1'|'group2'
>   -- option to use custom quote characters, like: {group1},{group2}
> - examples:
>   -- GET_USER_ATTR('dept', -1)
>   -- GET_UG_NAMES('none', '|')
>   -- GET_UG_NAMES('none', ',', '{', '}')
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerRequestScriptEvaluator.java 71802662f 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/RangerCommonConstants.java 73e3dadbf 
>   agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerRequestScriptEvaluatorTest.java c398e0205 
> 
> 
> Diff: https://reviews.apache.org/r/74236/diff/1/
> 
> 
> Testing
> -------
> 
> - added unit tests to cover new macros
> - verified that all existing test cases pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>