You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "msyavuz (via GitHub)" <gi...@apache.org> on 2025/07/30 12:10:40 UTC
[I] Show dataset column labels in drilling menus [superset]
msyavuz opened a new issue, #34402:
URL: https://github.com/apache/superset/issues/34402
### Bug description
In the dataset editor, we have labels for columns and calculated columns that users can use as a nicer display name for columns. However, in Sueprset, we use the label some of the time and the original column name other times.
When the label exists, we should use it in the following places (that aren't currently using it)
- Drill to detail
- Drill to detail by
For reference, the label is used in these places:
Charts
Drill by results
Downloads
### Screenshots/recordings
<img width="924" height="787" alt="Image" src="https://github.com/user-attachments/assets/b1262193-ed79-47ec-af7f-e23ac113e04d" />
### Superset version
master / latest-dev
### Python version
3.11
### Node version
18 or greater
### Browser
Firefox
### Additional context
_No response_
### Checklist
- [x] I have searched Superset docs and Slack and didn't find a solution to my problem.
- [x] I have searched the GitHub issue tracker and didn't find a similar bug report.
- [x] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Show dataset column labels in drilling menus [superset]
Posted by "Vitor-Avila (via GitHub)" <gi...@apache.org>.
Vitor-Avila closed issue #34402: Show dataset column labels in drilling menus
URL: https://github.com/apache/superset/issues/34402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Show dataset column labels in drilling menus [superset]
Posted by "developerzohaib786 (via GitHub)" <gi...@apache.org>.
developerzohaib786 commented on issue #34402:
URL: https://github.com/apache/superset/issues/34402#issuecomment-3160650328
Hi 👋, I'd like to work on this issue.
Could you please clarify if both "Drill to detail" and "Drill to detail by" are missing label support across all datasets, or only in specific cases? Any pointers to where this logic currently exists in the codebase would also be helpful.
If it's okay, @msyavuz kindly assign this issue to me. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Show dataset column labels in drilling menus [superset]
Posted by "msyavuz (via GitHub)" <gi...@apache.org>.
msyavuz commented on issue #34402:
URL: https://github.com/apache/superset/issues/34402#issuecomment-3160727227
Thank you for your interest @developerzohaib786 . I don't think it's specific to dataset. Logic likely sits around `src/components/Chart/DrillDetail/DrillDetailPane.tsx`, React DevTools should point you to the right component. Good luck!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Show dataset column labels in drilling menus [superset]
Posted by "dosubot[bot] (via GitHub)" <gi...@apache.org>.
dosubot[bot] commented on issue #34402:
URL: https://github.com/apache/superset/issues/34402#issuecomment-3136037859
<!-- Answer -->
You're right—column labels (verbose_name) from the dataset editor aren't consistently shown in the "Drill to detail" and "Drill to detail by" menus. The menus are implemented in the frontend, mainly in `DrillDetailMenuItems.tsx` and `ChartContextMenu.tsx`. While the "Drill by" menu already uses the label if available, the "Drill to detail by" submenu currently displays `filter.formattedVal`, which may just be the column name, not the label.
Superset has utilities like `useVerboseMap` and `columnChoices` that map column names to labels, but not all components use them. To make the drill menus consistent with charts and downloads, update the relevant menu components to resolve and display the column label (verbose_name) when it exists, falling back to the column name otherwise. Centralizing this logic (for example, always using `useVerboseMap`) would help maintain consistency across the UI.
No existing tickets or docs cover this specific issue, so this would be a new improvement for the frontend codebase. For reference, see the current implementations in [`DrillDetailMenuItems.tsx`](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/src/components/Chart/DrillDetail/DrillDetailMenuItems.tsx), [`ChartContextMenu.tsx`](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/src/components/Chart/ChartContextMenu/ChartContextMenu.tsx), and the label mapping utility [`useVerboseMap`](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/src/hooks/apiResources/datasets.ts).
<!-- Dosu Comment Footer -->
*To reply, just mention [@dosu](https://go.dosu.dev/dosubot).*
---
<sup>How did I do? [Good](https://app.dosu.dev/response-feedback/bdb98b79-863f-4030-ae3d-6331a95f7ef1?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/bdb98b79-863f-4030-ae3d-6331a95f7ef1?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/bdb98b79-863f-4030-ae3d-6331a95f7ef1?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/bdb98b79-863f-4030-ae3d-6331a95f7ef1?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/bdb98b79-863f-4030-ae3d-6331a95f7ef1?feedback_type=hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/bdb98b79-863f-4030-ae3d-6331a95f7ef1?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/bdb98b79-863f-4030-ae3d-6331a95f7ef1?feedback_type=other)</sup> [](https://app.dosu.dev/a28d3c7e-a9d3-459e-9fb6-3a6f9ff4f357/ask?utm_source=githu
b) [](https://go.dosu.dev/discord-bot) [](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/34402)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Show dataset column labels in drilling menus [superset]
Posted by "msyavuz (via GitHub)" <gi...@apache.org>.
msyavuz commented on issue #34402:
URL: https://github.com/apache/superset/issues/34402#issuecomment-3160840261
@developerzohaib786 The bounty is not attached yet, if you want to work on this as part of the bounty program you need to wait for the bounty comments in the issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Show dataset column labels in drilling menus [superset]
Posted by "developerzohaib786 (via GitHub)" <gi...@apache.org>.
developerzohaib786 commented on issue #34402:
URL: https://github.com/apache/superset/issues/34402#issuecomment-3160757798
please assign this issue to me. and can you point out the bounty info?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Show dataset column labels in drilling menus [superset]
Posted by "msyavuz (via GitHub)" <gi...@apache.org>.
msyavuz commented on issue #34402:
URL: https://github.com/apache/superset/issues/34402#issuecomment-3163406832
@developerzohaib786 I am sorry but thats not how the process works. Until the bounty comment is attached this issue is not part of the program and you can't claim it before it is. I recommend taking a look at the bounty guide document in notion and joining the slack channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Show dataset column labels in drilling menus [superset]
Posted by "developerzohaib786 (via GitHub)" <gi...@apache.org>.
developerzohaib786 commented on issue #34402:
URL: https://github.com/apache/superset/issues/34402#issuecomment-3163387925
@msyavuz I have started working on this issue and please if bounty comes assign this issue to me. and i will be very nearly to the solving this issue at that time. Thank U
Regards,
Zohaib Irshad
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org