You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "stoty (via GitHub)" <gi...@apache.org> on 2024/10/10 07:13:58 UTC

[PR] PHOENIX-7423 End2EndTestDriver doesn't compile with latest hbase-thir… [phoenix]

stoty opened a new pull request, #2000:
URL: https://github.com/apache/phoenix/pull/2000

   …dparty


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] PHOENIX-7423 End2EndTestDriver doesn't compile with latest hbase-thir… [phoenix]

Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #2000:
URL: https://github.com/apache/phoenix/pull/2000#issuecomment-2413219780

   The proper fix is #2003 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] PHOENIX-7423 End2EndTestDriver doesn't compile with latest hbase-thir… [phoenix]

Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #2000:
URL: https://github.com/apache/phoenix/pull/2000#issuecomment-2413218614

   This is not the right way to fix this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] PHOENIX-7423 End2EndTestDriver doesn't compile with latest hbase-thir… [phoenix]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #2000:
URL: https://github.com/apache/phoenix/pull/2000#discussion_r1797637677


##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/End2EndTestDriver.java:
##########
@@ -117,7 +117,7 @@ protected void addOptions() {
 
     @Override
     protected void processOptions(CommandLine cmd) {
-      String testFilterString = cmd.getOptionValue(SHORT_REGEX_ARG, null);
+      String testFilterString = cmd.getOptionValue(SHORT_REGEX_ARG, (String)null);

Review Comment:
   we could remove the 2nd argument altogether, as the default value is anyways null. https://commons.apache.org/proper/commons-cli/apidocs/org/apache/commons/cli/CommandLine.html#getOptionValue(char)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] PHOENIX-7423 End2EndTestDriver doesn't compile with latest hbase-thir… [phoenix]

Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on PR #2000:
URL: https://github.com/apache/phoenix/pull/2000#issuecomment-2408399852

   Well, its not this Jira but PHOENIX-7418 seems to have broken many tests for HBase 2.4 and 2.5 profiles. Here is the build results: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-mulitbranch/job/master/749/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] PHOENIX-7423 End2EndTestDriver doesn't compile with latest hbase-thir… [phoenix]

Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on PR #2000:
URL: https://github.com/apache/phoenix/pull/2000#issuecomment-2408398731

   This is not working for BackwardCompatibilityIT


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] PHOENIX-7423 End2EndTestDriver doesn't compile with latest hbase-thir… [phoenix]

Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #2000:
URL: https://github.com/apache/phoenix/pull/2000#discussion_r1798962298


##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/End2EndTestDriver.java:
##########
@@ -117,7 +117,7 @@ protected void addOptions() {
 
     @Override
     protected void processOptions(CommandLine cmd) {
-      String testFilterString = cmd.getOptionValue(SHORT_REGEX_ARG, null);
+      String testFilterString = cmd.getOptionValue(SHORT_REGEX_ARG, (String)null);

Review Comment:
   Removed explcit default.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] PHOENIX-7423 End2EndTestDriver doesn't compile with latest hbase-thir… [phoenix]

Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on PR #2000:
URL: https://github.com/apache/phoenix/pull/2000#issuecomment-2408400410

   Same is the case on 5.2 https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-mulitbranch/job/5.2/66/
   We will have to fix this first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] PHOENIX-7423 End2EndTestDriver doesn't compile with latest hbase-thir… [phoenix]

Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #2000:
URL: https://github.com/apache/phoenix/pull/2000#discussion_r1798857442


##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/End2EndTestDriver.java:
##########
@@ -117,7 +117,7 @@ protected void addOptions() {
 
     @Override
     protected void processOptions(CommandLine cmd) {
-      String testFilterString = cmd.getOptionValue(SHORT_REGEX_ARG, null);
+      String testFilterString = cmd.getOptionValue(SHORT_REGEX_ARG, (String)null);

Review Comment:
   Yes, that's more elegant.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] PHOENIX-7423 End2EndTestDriver doesn't compile with latest hbase-thir… [phoenix]

Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty closed pull request #2000: PHOENIX-7423 End2EndTestDriver doesn't compile with latest hbase-thir…
URL: https://github.com/apache/phoenix/pull/2000


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org