You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "David Van Couvering (JIRA)" <de...@db.apache.org> on 2006/08/02 07:24:17 UTC
[jira] Commented: (DERBY-1630) NetConnection40 references an engine
class, org.apache.derby.impl.jdbc.Util
[ http://issues.apache.org/jira/browse/DERBY-1630?page=comments#action_12425129 ]
David Van Couvering commented on DERBY-1630:
--------------------------------------------
Your patch looks good, although I think there is a helper method in SqlException that takes three Objects, so you don't need to create the object array.
And you don't need to specify a SQLException subclass here, that happens by magic in the getSQLException() logic, as determined by the SQL State.
David
> NetConnection40 references an engine class, org.apache.derby.impl.jdbc.Util
> ---------------------------------------------------------------------------
>
> Key: DERBY-1630
> URL: http://issues.apache.org/jira/browse/DERBY-1630
> Project: Derby
> Issue Type: Bug
> Components: Network Client
> Affects Versions: 10.2.0.0
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Priority: Critical
> Fix For: 10.2.0.0
>
> Attachments: derby-1630-v1.diff
>
>
> NetConnection40.java contains this:
> ...
> import org.apache.derby.impl.jdbc.Util;
> ...
> public boolean isValid(int timeout) throws SQLException {
> // Validate that the timeout has a legal value
> if (timeout < 0) {
> throw Util.generateCsSQLException(SQLState.INVALID_API_PARAMETER,
> new Integer(timeout), "timeout",
> "java.sql.Connection.isValid");
> }
> ...
> This was added as part of DERBY-1090. This should be changed to use the client's method of throwing exceptions.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira