[jira] [Commented] (OPENJPA-2773) set minIdle to > 0 in DBCPDriverDataSource

["Romain Manni-Bucau (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENJPA-2773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16759099#comment-16759099 ] 

Romain Manni-Bucau commented on OPENJPA-2773:
---------------------------------------------

[~struberg] if it is named DBCPAnything it must have the exact same default as DBCP itself IMHO so let's ensure it is aligned through this ticket more than anything splitting openjpa from dbcp.

> set minIdle to > 0 in DBCPDriverDataSource
> ------------------------------------------
>
>                 Key: OPENJPA-2773
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2773
>             Project: OpenJPA
>          Issue Type: Improvement
>          Components: jdbc
>    Affects Versions: 3.0.0
>            Reporter: Mark Struberg
>            Assignee: Mark Struberg
>            Priority: Major
>             Fix For: 3.0.1
>
>
> Right now our {{DBCPDriverDataSource}} by default sets the {{maxIdle}} to 1. 
> This is not wrong but also not really good in terms of performance.
> It is usually much better to keep it at a much higher number. Usually somewhere around {{maxActive}}, except when maxActive is really high.
> So I'd rather keep it at 10 or even at maxActive if this param is set.
> If the connections are not used, then they will get unlocked after some time anyway.
> But keeping the number 1 for {{maxIdle}} basically disables the pool, which is not wise.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)