maven 1.0-rc2 build fails, maven 1.0-rc1 builds OK

[George Cox <gj...@extremis.net>]

Hi there,

The HEAD builds successfully with Maven 1.0-rc1-SNAPSHOT, but does not with
Maven 1.0-rc2, failing with this error:

+----------------------------------------
| Executing (default): Geronimo maven deployment plugin
| Memory: 18M/45M
+----------------------------------------

BUILD FAILED
File......
file:/home/gjvc/incubator.apache.org/incubator-geronimo/maven.xml
Element... maven:reactor
Line...... 180
Column.... 27
java.lang.ClassNotFoundException:
org.apache.geronimo.kernel.log.GeronimoLogFactory
Total time: 8 minutes 2 seconds
Finished at: Wed Mar 31 16:40:21 BST 2004

HTH

-- 
[gjvc]

Re: maven 1.0-rc2 build fails, maven 1.0-rc1 builds OK

[Uijin Hong <He...@runeconsulting.com>]

George Cox wrote:
> Hi there,
> 
> The HEAD builds successfully with Maven 1.0-rc1-SNAPSHOT, but does not with
> Maven 1.0-rc2, failing with this error:
> 
> +----------------------------------------
> | Executing (default): Geronimo maven deployment plugin
> | Memory: 18M/45M
> +----------------------------------------
> 

I got another error message as following, when I do 'maven clean' and 
'maven' with Maven 1.0-RC2.

+----------------------------------------
| Executing (default): Geronimo :: Servlet Specification
| Memory: 4M/6M
+----------------------------------------

BUILD FAILED
File...... file:/C:/Documents and Settings/HeartBit/My Documents/My 
Projects/Eclipse Workspace/incubator-geronimo/maven.
xml
Element... maven:reactor
Line...... 180
Column.... 27
Unable to obtain goal [default] -- file:/C:/Documents and 
Settings/HeartBit/My Documents/My Projects/Eclipse Workspace/i
ncubator-geronimo/etc/maven.xml:50:41: <attainGoal> No goal 
[java:jar-resources]
Total time: 8 seconds
Finished at: Sun Apr 04 13:06:56 GMT+09:00 2004


I think somebody should re-write the maven build script.

By the way, is there any possible way to make Geronimo build fully 
compatiable with Maven's default goal(multiproject:install)? It seems 
like the current script doing too much jobs which you should delegate to 
Maven -such as dependency handling between 'spec's and 'module's-.

Re: maven 1.0-rc2 build fails, maven 1.0-rc1 builds OK

[Sriram N <sr...@yahoo.com>]

--- Jason Dillon <ja...@planet57.com> wrote:
> This is because the assembly module uses a Jelly bean 
> (org.apache.geronimo.deployment.Bootstrap) which causes GeronimoLogging 
> to force commons logging to use the GeronimoLogFactory.
> 
> The problem is that maven plugins also use commons logging, but do not 
> have access to the GeronimoLogFactory class.

Hi, I'm travelling at the moment, and have zero access to source code, but you
could try the following:

-  Alter the Maven plugin to load the commonslogging via
Thread.currentThread().getContextClassLoader().load("commonsLogger");

 
-- SRiram

__________________________________
Do you Yahoo!?
Yahoo! Small Business $15K Web Design Giveaway 
http://promotions.yahoo.com/design_giveaway/

Re: maven 1.0-rc2 build fails, maven 1.0-rc1 builds OK

[Jason Dillon <ja...@planet57.com>]

This is because the assembly module uses a Jelly bean 
(org.apache.geronimo.deployment.Bootstrap) which causes GeronimoLogging 
to force commons logging to use the GeronimoLogFactory.

The problem is that maven plugins also use commons logging, but do not 
have access to the GeronimoLogFactory class.

IMO it is a very bad idea to force commons logging to use 
GeronimoLogFactory, though I am sure there is some reason for it.

Currently Log4jService will throw exceptions if the factory is not a 
GeronimoLogFactory, presumably so that doStart() can change all loggers 
over to use log4j.  In general I believe it is a very bad idea to force 
one logging system, as we can not assume what then end user will want 
or need for a logging system.

I suggest we do not force the setting of the log factory inside of 
GeronimoLogging.  If we want this to be set by default, then change the 
server bootstrap to set this (so that tools like o.a.g.d.Bootstrap do 
not pick this up, but regular running of the server will).  As well as 
change Log4jService to allow any log factory and only attempt to do 
GeronimoLogFactory specific fluff, if the factory is indeed and 
instance.

What is the motivation behind forcing the log factory in the first 
place?

--jason


On Mar 31, 2004, at 7:42 AM, George Cox wrote:

> Hi there,
>
> The HEAD builds successfully with Maven 1.0-rc1-SNAPSHOT, but does not 
> with
> Maven 1.0-rc2, failing with this error:
>
> +----------------------------------------
> | Executing (default): Geronimo maven deployment plugin
> | Memory: 18M/45M
> +----------------------------------------
>
> BUILD FAILED
> File......
> file:/home/gjvc/incubator.apache.org/incubator-geronimo/maven.xml
> Element... maven:reactor
> Line...... 180
> Column.... 27
> java.lang.ClassNotFoundException:
> org.apache.geronimo.kernel.log.GeronimoLogFactory
> Total time: 8 minutes 2 seconds
> Finished at: Wed Mar 31 16:40:21 BST 2004
>
> HTH
>
> -- 
> [gjvc]
>