You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/11/22 06:59:53 UTC

[GitHub] [openwhisk] markusthoemmes commented on a change in pull request #4744: Remove usages of rxscala and replace with Java based code.

markusthoemmes commented on a change in pull request #4744: Remove usages of rxscala and replace with Java based code.
URL: https://github.com/apache/openwhisk/pull/4744#discussion_r349454712
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/core/database/cosmosdb/RxObservableImplicits.scala
 ##########
 @@ -34,8 +34,12 @@ private[cosmosdb] trait RxObservableImplicits {
      * @return the head result of the [[Observable]].
      */
     def head(): Future[T] = {
+      def toHandler[T](f: (T) => Unit): Action1[T] = new Action1[T] {
 
 Review comment:
   Good point! You can tell my scala is a little on the rusty side 😂 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services