You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by jd...@apache.org on 2009/12/30 18:01:47 UTC

svn commit: r894676 - /wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/AjaxEditableLabel.java

Author: jdonnerstag
Date: Wed Dec 30 17:01:46 2009
New Revision: 894676

URL: http://svn.apache.org/viewvc?rev=894676&view=rev
Log:
AjaxEditableLabel fails to focus editor upon validation errors
Issue: WICKET-2633

Modified:
    wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/AjaxEditableLabel.java

Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/AjaxEditableLabel.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/AjaxEditableLabel.java?rev=894676&r1=894675&r2=894676&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/AjaxEditableLabel.java (original)
+++ wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/AjaxEditableLabel.java Wed Dec 30 17:01:46 2009
@@ -456,9 +456,8 @@
 			target.appendJavascript("window.status='" +
 				JavascriptUtils.escapeQuotes((String)errorMessage) + "';");
 		}
-		String editorMarkupId = editor.getMarkupId();
-		target.appendJavascript(editorMarkupId + ".select();");
-		target.appendJavascript(editorMarkupId + ".focus();");
+		target.appendJavascript("{var el=wicketGet('" + editor.getMarkupId() +
+			"'); el.select(); el.focus();}");
 		target.addComponent(editor);
 	}