You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "rickyma (via GitHub)" <gi...@apache.org> on 2024/05/20 15:39:46 UTC

[PR] [#1698] fix(test): Increase tests running memory for better stability [incubator-uniffle]

rickyma opened a new pull request, #1726:
URL: https://github.com/apache/incubator-uniffle/pull/1726

   ### What changes were proposed in this pull request?
   
   Increase tests running memory for better stability.
   
   ### Why are the changes needed?
   
   Fix: https://github.com/apache/incubator-uniffle/issues/1698.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Unnecessary.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

Re: [PR] [#1698] fix(test): Increase tests running memory for better stability [incubator-uniffle]

Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #1726:
URL: https://github.com/apache/incubator-uniffle/pull/1726#issuecomment-2124416596

   When you merge a pull request, you should say which branch is merged. like
   ```
   merged to master & branch 0.9.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

Re: [PR] [#1698] fix(test): Increase tests running memory for better stability [incubator-uniffle]

Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston merged PR #1726:
URL: https://github.com/apache/incubator-uniffle/pull/1726


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

Re: [PR] [#1698] fix(test): Increase tests running memory for better stability [incubator-uniffle]

Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma commented on PR #1726:
URL: https://github.com/apache/incubator-uniffle/pull/1726#issuecomment-2124132991

   What's your idea? Gently ping @zuston @jerqi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

Re: [PR] [#1698] fix(test): Increase tests running memory for better stability [incubator-uniffle]

Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #1726:
URL: https://github.com/apache/incubator-uniffle/pull/1726#issuecomment-2126159175

   > @zuston When you merge a pull request, you should say which branch is merged. like
   > 
   > ```
   > merged to master & branch 0.9.
   > ```
   
   Needn't. Like this, if this PR is cherry-picked to other branches, github will show this.
   
   ![image](https://github.com/apache/incubator-uniffle/assets/8609142/b356d13b-ff78-480f-8007-355bf966d9ca)
   
   BTW. Some PRs for me is not necessary to cherry-pick to branch-0.9 . If you want this, feel free to tell me advancely
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

Re: [PR] [#1698] fix(test): Increase tests running memory for better stability [incubator-uniffle]

Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #1726:
URL: https://github.com/apache/incubator-uniffle/pull/1726#issuecomment-2124415264

   @zuston Have you committed this to branch 0.9?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

Re: [PR] [#1698] fix(test): Increase tests running memory for better stability [incubator-uniffle]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1726:
URL: https://github.com/apache/incubator-uniffle/pull/1726#issuecomment-2120765550

   ## Test Results
    2 405 files  ±0   2 405 suites  ±0   4h 58m 0s :stopwatch: -18s
      931 tests ±0     930 :white_check_mark: ±0   1 :zzz: ±0  0 :x: ±0 
   10 791 runs  ±0  10 777 :white_check_mark: ±0  14 :zzz: ±0  0 :x: ±0 
   
   Results for commit 7bd9132c. ± Comparison against base commit c3cbdec4.
   
   [test-results]:data:application/gzip;base64,H4sIAFl2S2YC/03MSw6DIBSF4a0Yxh0A8vB2M41cJCH10SCMmu69YEAdno/L/yXOz9NOnh0XVD46sicf79umMEa/rVmYHgaaKb/HcgE9a+u1J8SD6EVv/ym/TnCjnzNcF1MIW6gS0lqajGpgdbZoNq1Pq1XR4FY99j2K27L4mAfRxgLrOYLmBsEZKaiTFoD3CkFJVAO3RlpDfn8Xf66+EgEAAA==
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

Re: [PR] [#1698] fix(test): Increase tests running memory for better stability [incubator-uniffle]

Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma commented on PR #1726:
URL: https://github.com/apache/incubator-uniffle/pull/1726#issuecomment-2122657710

   PTAL @zuston @jerqi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

Re: [PR] [#1698] fix(test): Increase tests running memory for better stability [incubator-uniffle]

Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #1726:
URL: https://github.com/apache/incubator-uniffle/pull/1726#issuecomment-2126298359

   > > @zuston When you merge a pull request, you should say which branch is merged. like
   > > ```
   > > merged to master & branch 0.9.
   > > ```
   > 
   > Needn't. Like this, if this PR is cherry-picked to other branches, github will show this.
   > 
   > ![image](https://private-user-images.githubusercontent.com/8609142/333022338-b356d13b-ff78-480f-8007-355bf966d9ca.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTY0NDQyNjksIm5iZiI6MTcxNjQ0Mzk2OSwicGF0aCI6Ii84NjA5MTQyLzMzMzAyMjMzOC1iMzU2ZDEzYi1mZjc4LTQ4MGYtODAwNy0zNTViZjk2NmQ5Y2EucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDUyMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA1MjNUMDU1OTI5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MzgxMzJhZDk5YmQwYzdjN2M5ZjAwNTk4ZDZjN2FkMTQ5YzYxODM2MDRlM2VlZGZmNDNiYmM5ODU2ZTFlMDdhYiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.lXEOWig6TvATwKO-B45mCPx9C_pW-sD90-kkLyuPt0c)
   > 
   > BTW. Some PRs for me is not necessary to cherry-pick to branch-0.9 . If you want this, feel free to tell me advancely
   
   If one pull request is a fix, this must be back port to the branch unless the change has great affect. Improvement is optional. We would better to avoid backing port feature.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org