You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/01/11 22:11:16 UTC

[jira] [Commented] (FLINK-5461) Remove Superflous TypeInformation Declaration

    [ https://issues.apache.org/jira/browse/FLINK-5461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15819331#comment-15819331 ] 

ASF GitHub Bot commented on FLINK-5461:
---------------------------------------

GitHub user greghogan opened a pull request:

    https://github.com/apache/flink/pull/3096

    [FLINK-5461] [gelly] Remove Superflous TypeInformation Declaration

    FLINK-4624 updated Gelly's Summarization algorithm to use Either<NullValue, VV> in order to support types for which the serialization does not support null values. This required the use of explicit TypeInformation due to TypeExtractor. FLINK-4673 created a TypeInfoFactory for EitherType so the explicit TypeInformation can be removed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greghogan/flink 5461_remove_superflous_typeinformation_declaration

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3096.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3096
    
----
commit 55ae204beb013fe567ee427265d4b0400f96447e
Author: Greg Hogan <co...@greghogan.com>
Date:   2017-01-11T18:43:58Z

    [FLINK-5461] [gelly] Remove Superflous TypeInformation Declaration
    
    FLINK-4624 updated Gelly's Summarization algorithm to use
    Either<NullValue, VV> in order to support types for which the
    serialization does not support null values. This required the use of
    explicit TypeInformation due to TypeExtractor. FLINK-4673 created a
    TypeInfoFactory for EitherType so the explicit TypeInformation can be
    removed.

----


> Remove Superflous TypeInformation Declaration
> ---------------------------------------------
>
>                 Key: FLINK-5461
>                 URL: https://issues.apache.org/jira/browse/FLINK-5461
>             Project: Flink
>          Issue Type: Improvement
>          Components: Gelly
>    Affects Versions: 1.3.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>            Priority: Minor
>             Fix For: 1.3.0
>
>
> FLINK-4624 updated Gelly's Summarization algorithm to use {{Either<NullValue, VV>}} in order to support types for which the serialization does not support null values. This required the use of explicit {{TypeInformation}} due to {{TypeExtractor}}. FLINK-4673 created a {{TypeInfoFactory}} for {{EitherType}} so the explicit {{TypeInformation}} can be removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)