You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/05/13 22:00:10 UTC
[GitHub] [incubator-superset] codecov-io commented on pull request #9796: feat: return security errors in the SIP-40 format
codecov-io commented on pull request #9796:
URL: https://github.com/apache/incubator-superset/pull/9796#issuecomment-628268133
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9796?src=pr&el=h1) Report
> Merging [#9796](https://codecov.io/gh/apache/incubator-superset/pull/9796?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/cf30e1655081ef886c0d5f0484898bd5e0142beb&el=desc) will **increase** coverage by `6.48%`.
> The diff coverage is `86.20%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9796?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9796 +/- ##
==========================================
+ Coverage 64.35% 70.84% +6.48%
==========================================
Files 536 184 -352
Lines 29106 17881 -11225
Branches 2806 0 -2806
==========================================
- Hits 18732 12668 -6064
+ Misses 10194 5213 -4981
+ Partials 180 0 -180
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #python | `70.84% <86.20%> (-0.22%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9796?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9796/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.90% <40.00%> (-0.21%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9796/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.62% <80.00%> (-0.51%)` | :arrow_down: |
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/9796/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9796/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9796/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.21% <100.00%> (+0.86%)` | :arrow_up: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9796/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9796/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9796/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9796/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9796/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
| ... and [357 more](https://codecov.io/gh/apache/incubator-superset/pull/9796/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9796?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9796?src=pr&el=footer). Last update [cf30e16...c8a25b7](https://codecov.io/gh/apache/incubator-superset/pull/9796?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org