[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5057: arm/riscv/xtensa: enhance the task dump

[GitBox <gi...@apache.org>]

gustavonihei commented on a change in pull request #5057:
URL: https://github.com/apache/incubator-nuttx/pull/5057#discussion_r773761132



##########
File path: arch/risc-v/src/rv64gc/riscv_assert.c
##########
@@ -132,63 +132,171 @@ static inline void riscv_registerdump(volatile uintptr_t *regs)
 }
 
 /****************************************************************************
- * Name: up_taskdump
+ * Name: riscv_dump_stak

Review comment:
       ```suggestion
    * Name: riscv_dump_task
   ```
   Typo in the function name.

##########
File path: arch/risc-v/src/rv64gc/riscv_assert.c
##########
@@ -132,63 +132,171 @@ static inline void riscv_registerdump(volatile uintptr_t *regs)
 }
 
 /****************************************************************************
- * Name: up_taskdump
+ * Name: riscv_dump_stak
  ****************************************************************************/
 
-#if defined(CONFIG_STACK_COLORATION) || defined(CONFIG_SCHED_BACKTRACE)
-static void up_taskdump(struct tcb_s *tcb, void *arg)
+static void riscv_dump_stak(FAR struct tcb_s *tcb, FAR void *arg)

Review comment:
       ```suggestion
   static void riscv_dump_task(FAR struct tcb_s *tcb, FAR void *arg)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org