You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/11/21 14:14:32 UTC
[GitHub] [ignite] isapego opened a new pull request, #10388: IGNITE-17708: Add support for Java 15+ to Ignite C++
isapego opened a new pull request, #10388:
URL: https://github.com/apache/ignite/pull/10388
Added java options to make it possible to start Apache Ignite node on Java 15+ from Ignite C++.
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] isapego commented on a diff in pull request #10388: IGNITE-17708: Add support for Java 15+ to Ignite C++
Posted by GitBox <gi...@apache.org>.
isapego commented on code in PR #10388:
URL: https://github.com/apache/ignite/pull/10388#discussion_r1028202765
##########
modules/platforms/cpp/core/src/ignition.cpp:
##########
@@ -149,6 +149,24 @@ namespace ignite
opts.push_back(CopyChars("--add-exports=java.base/sun.reflect.generics.reflectiveObjects=ALL-UNNAMED"));
opts.push_back(CopyChars("--add-opens=jdk.management/com.sun.management.internal=ALL-UNNAMED"));
opts.push_back(CopyChars("--illegal-access=permit"));
+
+ // Those are only needed for Java 15+, but Java 15 can not be detected easily using JNI,
+ // so just putting it here in case we are running on 15+. It is OK to have them on Java 9-14 too.
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on a diff in pull request #10388: IGNITE-17708: Add support for Java 15+ to Ignite C++
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on code in PR #10388:
URL: https://github.com/apache/ignite/pull/10388#discussion_r1028196338
##########
modules/platforms/cpp/core/src/ignition.cpp:
##########
@@ -149,6 +149,24 @@ namespace ignite
opts.push_back(CopyChars("--add-exports=java.base/sun.reflect.generics.reflectiveObjects=ALL-UNNAMED"));
opts.push_back(CopyChars("--add-opens=jdk.management/com.sun.management.internal=ALL-UNNAMED"));
opts.push_back(CopyChars("--illegal-access=permit"));
+
+ // Those are only needed for Java 15+, but Java 15 can not be detected easily using JNI,
+ // so just putting it here in case we are running on 15+. It is OK to have them on Java 9-14 too.
Review Comment:
We can add a link to https://docs.oracle.com/en/java/javase/17/docs/specs/jni/functions.html#getversion, which shows why it is not possible to detect Java version with JNI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] isapego merged pull request #10388: IGNITE-17708: Add support for Java 15+ to Ignite C++
Posted by GitBox <gi...@apache.org>.
isapego merged PR #10388:
URL: https://github.com/apache/ignite/pull/10388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org