You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by shils <gi...@git.apache.org> on 2017/05/07 18:48:29 UTC
[GitHub] groovy pull request #539: GROOVY-8074: Statically compiled dot property acce...
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/539
GROOVY-8074: Statically compiled dot property accesses instance prope…
…rty instead of Map property
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shils/groovy GROOVY-8074
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/groovy/pull/539.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #539
----
commit abff6c7bf8a953f8f41d4f5080004c436757cb7e
Author: Shil Sinha <sh...@apache.org>
Date: 2017-05-07T18:47:19Z
GROOVY-8074: Statically compiled dot property accesses instance property instead of Map property
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] groovy pull request #539: GROOVY-8074: Statically compiled dot property acce...
Posted by shils <gi...@git.apache.org>.
Github user shils commented on a diff in the pull request:
https://github.com/apache/groovy/pull/539#discussion_r116149015
--- Diff: src/test/org/codehaus/groovy/classgen/asm/sc/ArraysAndCollectionsStaticCompileTest.groovy ---
@@ -128,6 +128,18 @@ class ArraysAndCollectionsStaticCompileTest extends ArraysAndCollectionsSTCTest
}
}
+ void testMapSubclassPropertyStyleAccess() {
--- End diff --
Added, thanks for the reminder.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] groovy pull request #539: GROOVY-8074: Statically compiled dot property acce...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/539
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] groovy pull request #539: GROOVY-8074: Statically compiled dot property acce...
Posted by paulk-asert <gi...@git.apache.org>.
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/539#discussion_r115862393
--- Diff: src/test/org/codehaus/groovy/classgen/asm/sc/ArraysAndCollectionsStaticCompileTest.groovy ---
@@ -128,6 +128,18 @@ class ArraysAndCollectionsStaticCompileTest extends ArraysAndCollectionsSTCTest
}
}
+ void testMapSubclassPropertyStyleAccess() {
--- End diff --
maybe add in:
`// GROOVY-8074`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---