You are viewing a plain text version of this content. The canonical link for it is here.
Posted to slide-dev@jakarta.apache.org by "Pill, Juergen" <Ju...@softwareag.com> on 2001/07/23 11:15:16 UTC

RE: cvs commit: jakarta-slide/src/stores/slidestore/reference Mem oryDescriptorsStore.java

Hello Dirk,

We have added this some time ago to be able to do a very simple
specification of the memory store in the domain.xml file:

      <store name="memory" />
      <scope match="/" store="memory" />

In this case the memory store needs to inherit from a content store to be
able to set the content store in AbstractStore without a class cast
exception. We knew that it was a little bit ugly, the alternative would be
to have a new store class (say defaultStore) and modify
AbstractStore.defaultStore accordingly.

There is one draw back: for java does not support multiple inheritances,
either in the MemoryStore or in the DefaultStore code needs to be
replicated.

What do you think?

Juergen



 -----Original Message-----
From: 	dirkv@apache.org [mailto:dirkv@apache.org] 
Sent:	Saturday, July 21, 2001 15.11 PM
To:	jakarta-slide-cvs@apache.org
Subject:	cvs commit: jakarta-slide/src/stores/slidestore/reference
MemoryDescriptorsStore.java

dirkv       01/07/21 06:11:15

  Modified:    src/stores/slidestore/reference MemoryDescriptorsStore.java
  Log:
  MemoryDescriptorsStore shouldn't extend FileContentStore
  
  Revision  Changes    Path
  1.7       +5 -8
jakarta-slide/src/stores/slidestore/reference/MemoryDescriptorsStore.java
  
  Index: MemoryDescriptorsStore.java
  ===================================================================
  RCS file:
/home/cvs/jakarta-slide/src/stores/slidestore/reference/MemoryDescriptorsSto
re.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- MemoryDescriptorsStore.java	2001/05/16 12:09:12	1.6
  +++ MemoryDescriptorsStore.java	2001/07/21 13:11:15	1.7
  @@ -1,7 +1,7 @@
   /*
  - * $Header:
/home/cvs/jakarta-slide/src/stores/slidestore/reference/MemoryDescriptorsSto
re.java,v 1.6 2001/05/16 12:09:12 juergen Exp $
  - * $Revision: 1.6 $
  - * $Date: 2001/05/16 12:09:12 $
  + * $Header:
/home/cvs/jakarta-slide/src/stores/slidestore/reference/MemoryDescriptorsSto
re.java,v 1.7 2001/07/21 13:11:15 dirkv Exp $
  + * $Revision: 1.7 $
  + * $Date: 2001/07/21 13:11:15 $
    *
    * ====================================================================
    *
  @@ -80,9 +80,9 @@
    * Reference implementation.
    *
    * @author <a href="mailto:remm@apache.org">Remy Maucherat</a>
  - * @version $Revision: 1.6 $
  + * @version $Revision: 1.7 $
    */
  -public class MemoryDescriptorsStore extends FileContentStore
  +public class MemoryDescriptorsStore extends AbstractService
       implements LockStore, NodeStore, RevisionDescriptorsStore,
       RevisionDescriptorStore, SecurityStore {
       
  @@ -138,8 +138,6 @@
       public void setParameters(Hashtable parameters)
           throws ServiceParameterErrorException,
           ServiceParameterMissingException {
  -        super.setParameters(parameters);
  -        // A parameter will tell were serialization files are.
       }
       
       
  @@ -195,7 +193,6 @@
       public synchronized void reset()
           throws ServiceResetFailedException {
               
  -        super.reset();
           objects = new Hashtable();
           permissions = new Hashtable();
           locks = new Hashtable();
  
  
  

Re: cvs commit: jakarta-slide/src/stores/slidestore/reference MemoryDescriptorsStore.java

Posted by Dirk Verbeeck <di...@pandora.be>.
ah, that's the reason,

When running the default example, I saw 2 FileContentStores initializing and
fixed that...
But I will implement a DefaultStore to be the default.

Dirk