You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/12/09 06:45:31 UTC

[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #2532: [Enhancement] Method stores return result in local before immediately returning it [SimpleMessage]

Alonexc opened a new issue, #2532:
URL: https://github.com/apache/incubator-eventmesh/issues/2532

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Enhancement Request
   
   ![image](https://user-images.githubusercontent.com/91315508/206640415-bab3beec-c3db-4555-a894-4b3607c70b6a.png)
   ![image](https://user-images.githubusercontent.com/91315508/206640388-00769a42-cc89-465d-9da4-1908b589a8d6.png)
   located at:
   eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/grpc/protos/SimpleMessage.java line 678 817
   analysis and explanation:
   This method stores the return result in a local variable, and then immediately returns the local variable. It would be simpler just to return the value that is assigned to the local variable.
   
   ### Describe the solution you'd like
   
   Returns the value of a local variable directly.
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] jonyangx commented on issue #2532: [Enhancement] Method stores return result in local before immediately returning it [SimpleMessage]

Posted by GitBox <gi...@apache.org>.
jonyangx commented on issue #2532:
URL: https://github.com/apache/incubator-eventmesh/issues/2532#issuecomment-1348553742

   I want to fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] xwm1992 closed issue #2532: [Enhancement] Method stores return result in local before immediately returning it [SimpleMessage]

Posted by GitBox <gi...@apache.org>.
xwm1992 closed issue #2532: [Enhancement] Method stores return result in local before immediately returning it [SimpleMessage]
URL: https://github.com/apache/incubator-eventmesh/issues/2532


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org